From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1585114-1516796387-2-6914313914042056068 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516796387; b=DG2MT8S0ZyxhkaB64VHqnWUcqSrZ3XpmEs0GYsyHcGaZr9m zW+f9yCKtC/J/iRbAdNc0zY+uSQwwpqaIAk3rOjdf1xa5VDVHY+ZJV2ctXQc8T0H Tc0i/tjuSQnnb3Ah/+qTQJ7lPwZ8lapsWIb6BKarjY8oguECajlfYWL0wZF0wruz IjajD7WYvbhCfmxyRgW/nRPohkwxLL37HtSNU4fhvXRC6SpigCO1l/4GCj6hOHiC 924hTId8JeN8yUzFMxweqrDutPxHw+WcR7OksXdyTW1/Xkj3fQ+lWKqq95mN1FxB d8LuijCZbBjeUw6GYlS12C4Q6n65fxhYUTdBecw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:from:to:cc:references:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516796387; bh=3thwyVeZmvBhWzjdNPNjy5OssQMes4TAkC/y8lcpbDo=; b=W 84OBsVUs7GSxVMXzVEiJryHKwToEuiswhk98gleBXnNOQwLCzD1aTizHl9DmeWVt RpiwaJHJ8qVl9G8bl6A7Q9ZQmg1e+dgEi5yGEU+Sx/UyQVjraLrJFclkcz1N6ixl AN4ant0JcuRObANWyjmI09P8euggsUI0OPY29q0vSXx3ja1B7S//zGP92Wo8w39n eVs1YsrB1tRM1Udaj539UeK0m80W/0FYgNneumEDB1Y9T/TwhZr+P3xMwsxTsAJ6 2KT6HHwvvBfRlraBhng9yu7XRxAw+d1BUg3UVs2cWYcmYlzXXF4XCvO8c26q3Bfr fyIp4WgkEwL1vKLk1sM/A== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=oV2fj8VP x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=oV2fj8VP x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933397AbeAXMTc (ORCPT ); Wed, 24 Jan 2018 07:19:32 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:29663 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932953AbeAXMTb (ORCPT ); Wed, 24 Jan 2018 07:19:31 -0500 Subject: Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume From: Roger Quadros To: Manu Gautam , CC: , References: <1516626103-1969-1-git-send-email-rogerq@ti.com> <1516626103-1969-3-git-send-email-rogerq@ti.com> <522f639a-466f-ae72-745e-61cbcc6fbfc7@codeaurora.org> <557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com> Message-ID: <8c4da216-7468-df31-01e3-644601421049@ti.com> Date: Wed, 24 Jan 2018 14:19:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 23/01/18 14:41, Roger Quadros wrote: > Hi Manu, > > On 23/01/18 05:45, Manu Gautam wrote: >> Hi, >> >> >> On 1/22/2018 6:31 PM, Roger Quadros wrote: >>> Adding/removing host/gadget controller before .pm_complete() >>> causes a lock-up. Let's prevent any dual-role state change >>> between .pm_prepare() and .pm_complete() to fix this. >> >> What kind of lock-up are you seeing? Some hardware lockup or software deadlock? >> IMO using a freezable_wq for drd_work should address that? >> > > I was seeing a software deadlock. freezable_wq is a good idea. I'll try it out. using freezable_wq doesn't get rid of the deadlock. If I use freezable_wq plus add some delay before I do a dwc3_host_init() in the work function then it starts to work. As dependence on delay looks fragile so I'll stick to the current implementation based on .pm_prepare/complete(). -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume From: Roger Quadros Message-Id: <8c4da216-7468-df31-01e3-644601421049@ti.com> Date: Wed, 24 Jan 2018 14:19:24 +0200 To: Manu Gautam , balbi@kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gMjMvMDEvMTggMTQ6NDEsIFJvZ2VyIFF1YWRyb3Mgd3JvdGU6Cj4gSGkgTWFudSwKPiAKPiBP biAyMy8wMS8xOCAwNTo0NSwgTWFudSBHYXV0YW0gd3JvdGU6Cj4+IEhpLAo+Pgo+Pgo+PiBPbiAx LzIyLzIwMTggNjozMSBQTSwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPj4+IEFkZGluZy9yZW1vdmlu ZyBob3N0L2dhZGdldCBjb250cm9sbGVyIGJlZm9yZSAucG1fY29tcGxldGUoKQo+Pj4gY2F1c2Vz IGEgbG9jay11cC4gTGV0J3MgcHJldmVudCBhbnkgZHVhbC1yb2xlIHN0YXRlIGNoYW5nZQo+Pj4g YmV0d2VlbiAucG1fcHJlcGFyZSgpIGFuZCAucG1fY29tcGxldGUoKSB0byBmaXggdGhpcy4KPj4K Pj4gV2hhdCBraW5kIG9mIGxvY2stdXAgYXJlIHlvdSBzZWVpbmc/IFNvbWUgaGFyZHdhcmUgbG9j a3VwIG9yIHNvZnR3YXJlIGRlYWRsb2NrPwo+PiBJTU8gdXNpbmcgYSBmcmVlemFibGVfd3EgZm9y IGRyZF93b3JrIHNob3VsZCBhZGRyZXNzIHRoYXQ/Cj4+Cj4gCj4gSSB3YXMgc2VlaW5nIGEgc29m dHdhcmUgZGVhZGxvY2suIGZyZWV6YWJsZV93cSBpcyBhIGdvb2QgaWRlYS4gSSdsbCB0cnkgaXQg b3V0LgoKdXNpbmcgZnJlZXphYmxlX3dxIGRvZXNuJ3QgZ2V0IHJpZCBvZiB0aGUgZGVhZGxvY2su CklmIEkgdXNlIGZyZWV6YWJsZV93cSBwbHVzIGFkZCBzb21lIGRlbGF5IGJlZm9yZSBJIGRvIGEg ZHdjM19ob3N0X2luaXQoKQppbiB0aGUgd29yayBmdW5jdGlvbiB0aGVuIGl0IHN0YXJ0cyB0byB3 b3JrLgoKQXMgZGVwZW5kZW5jZSBvbiBkZWxheSBsb29rcyBmcmFnaWxlIHNvIEknbGwgc3RpY2sg dG8gdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24KYmFzZWQgb24gLnBtX3ByZXBhcmUvY29tcGxl dGUoKS4K