From: "William A. Kennington III" <wak@google.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] gitsm: Add need_update method to determine when we are going to a new SRCREV
Date: Wed, 27 Mar 2019 18:52:41 -0700 [thread overview]
Message-ID: <8c4f14ad-0886-a715-4c81-42b68ff2ae4d@google.com> (raw)
In-Reply-To: <CAPnigKnBVSa5rr11xQ3Qs0Gv4uyyTpQKQ0ANS0ezzTrSO=xxSQ@mail.gmail.com>
Sorry, bad send from gmail which seems to want to wrap and deduplicate
my text. You can apply the following patch to test against over pessimism.
diff --git a/lib/bb/tests/fetch.py b/lib/bb/tests/fetch.py
index 429998b3..718605e2 100644
--- a/lib/bb/tests/fetch.py
+++ b/lib/bb/tests/fetch.py
@@ -961,6 +961,26 @@ class FetcherNetworkTest(FetcherTest):
self.assertTrue(os.path.exists(os.path.join(repo_path,
'.git/modules/extern/json/config')), msg='Missing submodule config
"extern/json"')
self.assertTrue(os.path.exists(os.path.join(repo_path,
'.git/modules/extern/sanitizers/config')), msg='Missing submodule config
"extern/sanitizers"')
+ def test_git_submodule_no_update_CLI11(self):
+ """ Prevent regression on update detection not finding already
downloaded commits """
+ url =
"gitsm://github.com/CLIUtils/CLI11;protocol=git;rev=da901cca542612a133efcb04e8e78080186991e4"
+ fetcher = bb.fetch.Fetch([url], self.d)
+ fetcher.download()
+
+ self.d.setVar("BB_NO_NETWORK", 1)
+ # CLI11 that pulls in a newer nlohmann-json which we already
fetched
+ url =
"gitsm://github.com/CLIUtils/CLI11;protocol=git;rev=899100c1619ea1282620604ac9199010e65f907e"
+ fetcher = bb.fetch.Fetch([url], self.d)
+ fetcher.download()
+ # Previous cwd has been deleted
+ os.chdir(os.path.dirname(self.unpackdir))
+ fetcher.unpack(self.unpackdir)
+
+ repo_path = os.path.join(self.tempdir, 'unpacked', 'git')
+ self.assertTrue(os.path.exists(os.path.join(repo_path,
'.git/modules/extern/googletest/config')), msg='Missing submodule config
"extern/googletest"')
+ self.assertTrue(os.path.exists(os.path.join(repo_path,
'.git/modules/extern/json/config')), msg='Missing submodule config
"extern/json"')
+ self.assertTrue(os.path.exists(os.path.join(repo_path,
'.git/modules/extern/sanitizers/config')), msg='Missing submodule config
"extern/sanitizers"')
+
def test_git_submodule_aktualizr(self):
url =
"gitsm://github.com/advancedtelematic/aktualizr;branch=master;protocol=git;rev=d00d1a04cc2366d1a5f143b84b9f507f8bd32c44"
fetcher = bb.fetch.Fetch([url], self.d)
next prev parent reply other threads:[~2019-03-28 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 17:40 [PATCH 0/1] gitsm: When switching SRCREVs verify submodules Mark Hatle
2019-03-27 17:40 ` [PATCH 1/1] gitsm: Add need_update method to determine when we are going to a new SRCREV Mark Hatle
2019-03-27 20:22 ` William Kennington
2019-03-28 1:47 ` William Kennington
2019-03-28 1:52 ` William A. Kennington III [this message]
2019-03-28 1:59 ` William A. Kennington III
2019-03-28 15:22 ` Mark Hatle
2019-03-28 15:15 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4f14ad-0886-a715-4c81-42b68ff2ae4d@google.com \
--to=wak@google.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=mark.hatle@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.