All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Devi Priya <quic_devipriy@quicinc.com>,
	agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, quic_srichara@quicinc.com,
	quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com,
	quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com,
	quic_anusha@quicinc.com, quic_ipkumar@quicinc.com
Subject: Re: [PATCH V2 4/6] regulator: qcom_smd: Add support to define the bootup voltage
Date: Mon, 3 Apr 2023 19:14:04 +0100	[thread overview]
Message-ID: <8c513ddc-435e-40ce-b1f8-84eaf8241ed4@sirena.org.uk> (raw)
In-Reply-To: <3c5a9608-ecd2-a3c0-e866-7d0070e49b89@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Mon, Apr 03, 2023 at 07:53:48PM +0200, Konrad Dybcio wrote:
> On 3.04.2023 16:07, Devi Priya wrote:

> > But, when the regulator driver comes up, it tries to bring up the
> > regulators to the minimum supported voltage provided with the
> > regulator-min-microvolt property in the DT.

> Right, that exists.. 

> Mark, do you think it should be updated such that the requests are
> aggregated before assuming min_uV is "just fine"?

We can't tell if any consumers are ever going to appear, and the
regulator having a voltage outside of the constraints is an urgent
problem we need to fix quickly.  Since we try to bring the voltage to
the nearest end of the constraint the driver could always change the
bogus voltage it reports to one that is excessively high, this would
mean the core will try to bring the voltage down to the maximum rather
than up to the minimum.  The driver could also look at the constraints
when guessing at the hardware configuration rather than claiming an out
of spec voltage, this would mean we wouldn't need to correct anything.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-04-03 18:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 14:20 [PATCH V2 0/6] Add regulator support for IPQ9574 SoC Devi Priya
2023-02-17 14:20 ` [PATCH V2 1/6] dt-bindings: soc: qcom: smd-rpm: Add IPQ9574 compatible Devi Priya
2023-02-18 10:20   ` Krzysztof Kozlowski
2023-02-17 14:20 ` [PATCH V2 2/6] regulator: qcom_smd: Add s1 sub-node to mp5496 regulator Devi Priya
2023-02-28 14:31   ` Rob Herring
2023-02-17 14:20 ` [PATCH V2 3/6] regulator: qcom_smd: Add MP5496 S1 regulator Devi Priya
2023-02-17 14:20 ` [PATCH V2 4/6] regulator: qcom_smd: Add support to define the bootup voltage Devi Priya
2023-02-22 22:11   ` Konrad Dybcio
2023-02-22 23:01     ` Mark Brown
2023-03-03 13:21       ` Devi Priya
2023-03-03 13:27         ` Konrad Dybcio
     [not found]           ` <11b05b9f-b969-6648-2204-2da5f8465c96@quicinc.com>
2023-03-07  6:55             ` Devi Priya
2023-03-08 10:27               ` Konrad Dybcio
2023-03-14 17:15                 ` Devi Priya
2023-03-18 14:08                   ` Konrad Dybcio
2023-03-27  8:40                     ` Devi Priya
2023-03-27  9:26                       ` Konrad Dybcio
2023-03-28  6:12                         ` Devi Priya
2023-03-28  8:28                           ` Konrad Dybcio
2023-04-03 14:07                             ` Devi Priya
2023-04-03 17:53                               ` Konrad Dybcio
2023-04-03 18:14                                 ` Mark Brown [this message]
2023-04-03 18:21                                   ` Konrad Dybcio
2023-04-03 18:28                                     ` Mark Brown
2023-02-17 14:20 ` [PATCH V2 5/6] arm64: dts: qcom: ipq9574: Add RPM related nodes Devi Priya
2023-02-17 14:50   ` Konrad Dybcio
2023-02-20 13:53     ` Devi Priya
2023-02-20 14:36       ` Konrad Dybcio
2023-02-20 15:22         ` Devi Priya
2023-02-17 14:20 ` [PATCH V2 6/6] arm64: dts: qcom: ipq9574: Add cpufreq support Devi Priya
2023-03-16  3:20 ` (subset) [PATCH V2 0/6] Add regulator support for IPQ9574 SoC Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c513ddc-435e-40ce-b1f8-84eaf8241ed4@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_anusha@quicinc.com \
    --cc=quic_arajkuma@quicinc.com \
    --cc=quic_devipriy@quicinc.com \
    --cc=quic_gokulsri@quicinc.com \
    --cc=quic_ipkumar@quicinc.com \
    --cc=quic_kathirav@quicinc.com \
    --cc=quic_sjaganat@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.