From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH] execveat.2: srcfix
Date: Fri, 1 Jan 2021 23:29:05 +0100 [thread overview]
Message-ID: <8c66c28d-2ff1-b629-33f9-df057998f80e@gmail.com> (raw)
In-Reply-To: <4611ff34-2322-1e66-7b14-dc61200404f9@gmail.com>
Hi Alex,
On 1/1/21 2:49 PM, Alejandro Colomar (man-pages) wrote:
>
>
> On 1/1/21 12:41 PM, Michael Kerrisk (man-pages) wrote:
>> On 12/31/20 7:55 PM, Alejandro Colomar (man-pages) wrote:
>>> Hi Michael,
>>>
>>> I'm not sure about some cases, but have a look at this:
>>>
>>> a64l.3: compact
>
> Oops, I meant s/compact/ffix!!/
>
> That one made it into the page, so ffix!!
Done.
>
>>> atan.3: wsfix
>
> still wsfix: s/( long/(long/
Done.
>>> backtrace.3: compact
Group.
>> bstring.3: compact? (and maybe align names?)
>>
>> Not sure about this one. Nothing done yet.
Still not sure on this one.
>>> catopen.3: compact
Done.
>>> envz_add.3: compact?
Compact is too much, and there's no obvious good grouping.
>>> fseeko.3: compact
I grouped. It's enough, I think.
>>> fts.3: compact (and maybe align?)
>>
>> Not sure about this one. Nothing done yet.
Compact feels too much, and there's no obvious good grouping.
>>> getaddrinfo_a.3: fix alignment (and maybe compact?)
>>
>> Not sure about this one. Nothing done yet.
Group.
> see also getaddrinfo.3
Compact feels too much, and there's no obvious grouping.
>>
>>> getdirentries.3: ffix!
>
> Fit into 78-col terminal
Done.
>>> getmntent.3: compact
>>
>> Not sure about this one. Nothing done yet.
Compact feels too much, and there's no obvious grouping.
>>> getspnam.3: compact or group
>>
>> Grouped.
>
> Fix alignment too (*_r functions)
Done.
>>> gsignal.3: group
>>
>> Not sure about that. I'll leave this for now.
Compact feels wrong.
>>> key_setsecret.3: compact
>>
>> Group.
Already okay, I think.
>>> login.3: group
>
> ffix!!
Done.
> The following may help:
>
> $ for p in $(git grep -l '.SH SYN' man?); do \
> echo "===================== $p"; \
> man -l $p 2> /dev/null \
> |sed -n '/^SYNOP/,/DESCR/p' \
> |sed '/Feat/,$d'; \
> done \
> |grep '); *[a-zA-Z_]' \
> |grep -v -e 'Note:' -e NOTES;
> int brk(void *addr); void *sbrk(intptr_t increment);
> set); ssize_t pwrite(int fd, const void *buf, size_t
> long a64l(const char *str64); char *l64a(long value);
> double fmax(double x, double y); float fmaxf(float x,
> float y); long double fmaxl(long double x, long double
> void login(const struct utmp *ut); int logout(const char
> place the result(s); inproc is used to encode the
> dress of where to place the result(s); inproc is
> ter(s); procname should return a pointer to its
> static result(s); inproc is used to decode the pa‐
> RPC socket(s); rdfds is the resultant read file
> int wordexp(const char *s, wordexp_t *p, int flags); void
> sp,MAXUN.UNSIGNED ); where MAXUN.UNSIGNED is the
> (SIGEV_THREAD_ID); Linux-specific */
Thanks. I fixed a few things.
>>> malloc_hook.3: compact
>>
>> That feels too busy. No change (yet).
Compact feels wrong, and even grouping feels wrong. The signatures are
already hard to read.
>>> mq_getattr.3: compact and fix alignment
>
> Fix alignment
Done.
>>> random[_r].3: group or compact
>>
>> Group.
>
> see random_r.3 too
Grouped.
>>> recno.3: There are no APIs? Why not?
It's a weird page. Probably something should be fixed. But
it's outside scope of this patch.
>>> regex.3: compact?
>>
>> Not sure about this one. Nothing done yet.
Actually, I did group, and I think it's enough.
>>
>>> I didn't read past that.
>
> Still I didn't read past that :)
;-)
>> Well thanks! What you did read was helpful!
>
> Thanks!
>
> I removed from the reply those already fixed,
> so what you see in this email is still pending
> (minus a few that I may have forgotten to remove).
Thanks again, Alex. I've pushed the fixed I made.
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2021-01-01 22:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 21:41 [PATCH] execveat.2: srcfix Alejandro Colomar
2020-12-30 22:27 ` Michael Kerrisk (man-pages)
2020-12-30 23:28 ` Alejandro Colomar (man-pages)
2020-12-31 10:06 ` Michael Kerrisk (man-pages)
2020-12-31 12:28 ` Alejandro Colomar (man-pages)
2020-12-31 15:26 ` Michael Kerrisk (man-pages)
2020-12-31 18:55 ` Alejandro Colomar (man-pages)
2020-12-31 23:29 ` Alejandro Colomar (man-pages)
2021-01-01 11:43 ` Michael Kerrisk (man-pages)
2021-01-01 11:41 ` Michael Kerrisk (man-pages)
2021-01-01 13:49 ` Alejandro Colomar (man-pages)
2021-01-01 22:29 ` Michael Kerrisk (man-pages) [this message]
2021-01-02 16:03 ` Alejandro Colomar (man-pages)
2021-01-02 19:59 ` Michael Kerrisk (man-pages)
2021-01-02 21:40 ` Alejandro Colomar (man-pages)
2021-01-03 12:11 ` Michael Kerrisk (man-pages)
2021-01-04 12:59 ` Alejandro Colomar (man-pages)
2021-01-04 13:21 ` Michael Kerrisk (man-pages)
2021-02-02 17:43 ` Alejandro Colomar (man-pages)
2021-02-13 19:15 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c66c28d-2ff1-b629-33f9-df057998f80e@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.