From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEs4B-0001LN-It for qemu-devel@nongnu.org; Tue, 23 Oct 2018 04:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEruB-0006Yg-OR for qemu-devel@nongnu.org; Tue, 23 Oct 2018 04:19:15 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEruB-0006Xe-BK for qemu-devel@nongnu.org; Tue, 23 Oct 2018 04:19:11 -0400 Received: by mail-wm1-x341.google.com with SMTP id x19-v6so773831wmc.2 for ; Tue, 23 Oct 2018 01:19:11 -0700 (PDT) References: <20181020071451.27808-1-kbastian@mail.uni-paderborn.de> <20181020071451.27808-10-kbastian@mail.uni-paderborn.de> From: Richard Henderson Message-ID: <8c941715-1e8c-c5cf-f67a-3d0f6d97ab32@linaro.org> Date: Tue, 23 Oct 2018 09:19:07 +0100 MIME-Version: 1.0 In-Reply-To: <20181020071451.27808-10-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/29] target/riscv: Convert RV32A insns to decodetree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , mjc@sifive.com, sagark@eecs.berkeley.edu, palmer@sifive.com Cc: peer.adelt@hni.uni-paderborn.de, Alistair.Francis@wdc.com, qemu-devel@nongnu.org On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v1 -> v2: > - simplified gen_amo() with function pointers > - rs2 @atom_ld is now decimal > > target/riscv/insn32.decode | 17 +++ > target/riscv/insn_trans/trans_rva.inc.c | 145 ++++++++++++++++++++++++ > target/riscv/translate.c | 1 + > 3 files changed, 163 insertions(+) > create mode 100644 target/riscv/insn_trans/trans_rva.inc.c Reviewed-by: Richard Henderson r~