From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kKFaY-0008TI-P1 for mharc-grub-devel@gnu.org; Mon, 21 Sep 2020 02:46:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKFaP-0008S3-8N for grub-devel@gnu.org; Mon, 21 Sep 2020 02:46:10 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:35182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKFaL-0004yN-6M for grub-devel@gnu.org; Mon, 21 Sep 2020 02:46:04 -0400 Received: by mail-pj1-x1043.google.com with SMTP id jw11so6633266pjb.0 for ; Sun, 20 Sep 2020 23:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=A/Bo54fBYNhIfmiUifCISKYfxjP/roSS+yrXuzPhHgQ=; b=vG+lGIZz5maSRPlGoVA/V2zFx1DtuE/xPuwmSFw6XfFwXb4SDpXpN+V8IkJeWWnjEs v1M+HvjutUXKdRY2yT3sSgZRSBsG+lLzrK51oPV3ihAGemgvh74gBUGVAI6PhqwH3TgI w/AxJIB4PvOCFLsP51lc4cTrygd1EGNiYg+8pILcLHwKo7SxZaZ9uEZieHLhB6saCP/a JGI31B/nl1X4fEDIXls9FQF9gIhE9w/sNbgCfQiGEqkrrsnXBKKoRDlCK7ivpo9dk7ty yvTKTkraRcAIOh3nE1mL7AfSOI96+pbYRIc8FUC/v0+T7UmYqGWM4GOgK7ebtYPvN+yB muhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=A/Bo54fBYNhIfmiUifCISKYfxjP/roSS+yrXuzPhHgQ=; b=IjUTO8Ui+6M+Azo14Za8cP+YDE5hs1cU9+YZMo3XwjUMIaQlpJ4KAc9oDDRobDIqvP vRGiu41SIztgLYHtv7yGVP+WVGrWOxd5se6d70geF1X8jPEahbA8qMvW/Mu9s9FwDBKe HR55jLqKdZVU1gbxVQS1WIl1gkU59OBZPUh6JvzwcmgJGN/DifFXwZcfbo1/O1gaXm7B a/EtRj1gHUM5cE1bqnE/ZDiP4E1LpyD4TbVApYPTw3IzO9OCiz1naIustNUBUz/l7BiR btxvSwcFUul8YoFgDCtuVd55BAgDKASijCYXXJ6ZCUz9AchyvlIsNVxc1CtmD9fusx04 XaDg== X-Gm-Message-State: AOAM532uHjB7eiy8KbvR0DM/4mXHXPS/wWgXHc4E5UhvA+sZcaE7vnaq 0zadSb/ywqPPlHU9yafoZpQPkQ== X-Google-Smtp-Source: ABdhPJwmqt08/5h4fFTAS4SyTyhoD7kdVPi6wZoEW6TQZU4UVx+QgC2L1+5shU0VLu02MUvjqf03Tw== X-Received: by 2002:a17:90b:208b:: with SMTP id hb11mr23972853pjb.201.1600670759737; Sun, 20 Sep 2020 23:45:59 -0700 (PDT) Received: from [127.0.0.1] ([172.58.46.198]) by smtp.gmail.com with ESMTPSA id l1sm10940487pfc.164.2020.09.20.23.45.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2020 23:45:59 -0700 (PDT) Date: Mon, 21 Sep 2020 06:45:57 +0000 (UTC) From: Glenn Washburn To: Daniel Kiper Cc: Patrick Steinhardt , grub-devel@gnu.org, Denis GNUtoo Carikli Message-ID: <8cd30ba6-53d2-43f9-afff-90caa0f1c690@efficientek.com> In-Reply-To: <20200908132803.47zheuofojcvpc6u@tomti.i.net-space.pl> References: <7ef38470b44756db74928b0ade215b566503ef0f.1599492346.git.ps@pks.im> <20200908132803.47zheuofojcvpc6u@tomti.i.net-space.pl> Subject: Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: <8cd30ba6-53d2-43f9-afff-90caa0f1c690@efficientek.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::1043; envelope-from=development@efficientek.com; helo=mail-pj1-x1043.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 06:46:12 -0000 Sep 8, 2020 7:28:13 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn >> >> Signed-off-by: Glenn Washburn >> Reviewed-by: Patrick Steinhardt >> --- >> grub-core/disk/cryptodisk.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c >> index 1897acc4b..b2c6e9a7d 100644 >> --- a/grub-core/disk/cryptodisk.c >> +++ b/grub-core/disk/cryptodisk.c >> @@ -1311,5 +1311,6 @@ GRUB_MOD_FINI (cryptodisk) >> { >> grub_disk_dev_unregister (&grub_cryptodisk_dev); >> cryptodisk_cleanup (); > > I am OK with this patch but I realized that cryptodisk_cleanup() body is > commented out, So, could you add another patch which drops > cryptodisk_cleanup() entirely from the GRUB code? Or make it work as it > supposed to work. Maybe the latter is better... > > Daniel > I can look in to this when I get to the other changes. Glenn