From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C310C43603 for ; Mon, 16 Dec 2019 13:16:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4716720684 for ; Mon, 16 Dec 2019 13:16:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4716720684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E34AE6E520; Mon, 16 Dec 2019 13:16:11 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00F786E520 for ; Mon, 16 Dec 2019 13:16:09 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 05:16:08 -0800 X-IronPort-AV: E=Sophos;i="5.69,321,1571727600"; d="scan'208";a="209298188" Received: from dtriolet-mobl1.ger.corp.intel.com (HELO [10.251.84.191]) ([10.251.84.191]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 16 Dec 2019 05:16:05 -0800 To: Chris Wilson , Intel-gfx@lists.freedesktop.org References: <20191216120704.958-1-tvrtko.ursulin@linux.intel.com> <20191216120704.958-3-tvrtko.ursulin@linux.intel.com> <157650094762.2428.12455931392724147119@skylake-alporthouse-com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <8cd36871-a00b-1a88-0a46-52c9183a2adc@linux.intel.com> Date: Mon, 16 Dec 2019 13:16:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <157650094762.2428.12455931392724147119@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 16/12/2019 12:55, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-12-16 12:07:01) >> +static void i915_gem_remove_client(struct drm_i915_file_private *file_priv) >> +{ >> + struct i915_drm_clients *clients = &file_priv->dev_priv->clients; >> + struct i915_drm_client *client = &file_priv->client; >> + >> + if (!client->name) >> + return; /* intel_fbdev_init registers a client before sysfs */ >> + >> + sysfs_remove_file(client->root, (struct attribute *)&client->attr.pid); >> + sysfs_remove_file(client->root, (struct attribute *)&client->attr.name); >> + kobject_put(client->root); > > Do we need to remove individual files if we unplug the root? > sysfs_remove_dir(client->root) ? Kerneldoc indeed suggests this should work. Will try. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx