From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A5CC433F5 for ; Sun, 27 Mar 2022 19:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234257AbiC0TPx (ORCPT ); Sun, 27 Mar 2022 15:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbiC0TPw (ORCPT ); Sun, 27 Mar 2022 15:15:52 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 641A5DFD3; Sun, 27 Mar 2022 12:14:13 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id 1so9916922qke.1; Sun, 27 Mar 2022 12:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=A9CFJgUP2awfrdRyvcJZlVsnkzemv2E9bRx9IkqLSpw=; b=RABDT1UvIgfs+0gsswBm8nKHVoEn9ahba0gZNNiPyBfg20ODYkKOkf+6w7wgCae2GB TOepgNu0ANmgOZTRuAsC5t7PK1Gd5kpJWxoycfuF7eH31ly8UD3/+CatusD8dRl9zZet +XhcSiOEG2isDxl5jHrBilPZ8VfkYyPKJA1PwdmqNEu5rI929SasNWqLcdExaht6V/yi pcvJhGdmtfm4b9tsimcfrVNw82AfnIKbrKL4pk1AwoBDkKLcnGxi/5MaxvFRj+Akec04 HjIXC0fNBw44T7nqIVpKfgtHMS+Ht2Dg+K04CvQcJdj8a2RIVuv9PmEUWnxFfj8kIlam 5fvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=A9CFJgUP2awfrdRyvcJZlVsnkzemv2E9bRx9IkqLSpw=; b=pqBSiGKAxnzUkh7WZJ8OQw5eIGIXXNzPR5b39eCcTY/b8M1+2IDY3eidIH07Fxmxhq vnumHsRF51a/vfHEsItJYSXOerAxDocl7XKSAebwAddtN1/gWz+ewCYBO/HAofyq7mbw 6A9bneFAXdKJyNatFVgR9v6LBSIU8qOGW8ySmqomJwkfsHa97iD2x/r5/eJ6EtWUBDEi UwmvMZ0VYUiCW88V+1O6nrAMjwlttm7KTe3F40bnznCB0POavhYQeX2nldtw8F60JFrc AscL25B1NHH5AGGkOmlIHw1UmYABgf29glOERiGuAWuEZPaQUXPi1iqnxuyQMXB9AZrv O/+g== X-Gm-Message-State: AOAM532n4fcmP8YC3L2bZDqU57VE2B6szLITNp5MiEyPao1lgE0K+swa mFsGpPT8Rbs77eZMfMU1Ulo= X-Google-Smtp-Source: ABdhPJwb3aJO02v5hTdlVjaWdOpqQQb7aYBwYQtrv+VUIaBVEI3QQ2+yzwBkjCsRNY85++BKSn/Jfw== X-Received: by 2002:a05:620a:199a:b0:67d:4bf0:4a73 with SMTP id bm26-20020a05620a199a00b0067d4bf04a73mr13511957qkb.684.1648408452470; Sun, 27 Mar 2022 12:14:12 -0700 (PDT) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id 64-20020a370343000000b0067b31f32693sm6888023qkd.109.2022.03.27.12.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Mar 2022 12:14:11 -0700 (PDT) Message-ID: <8ce4ea34-f389-6eff-2e5b-0f23641df219@gmail.com> Date: Sun, 27 Mar 2022 15:14:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v1 03/12] dt-bindings: pinctrl: add i.MXRT1170 pinctrl Documentation Content-Language: en-US To: Krzysztof Kozlowski , linux-imx@nxp.com Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, dev@lynxeye.de, marcel.ziswiler@toradex.com, tharvey@gateworks.com, leoyang.li@nxp.com, sebastian.reichel@collabora.com, cniedermaier@dh-electronics.com, clin@suse.com, giulio.benetti@benettiengineering.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org References: <20220326144313.673549-1-Mr.Bossman075@gmail.com> <20220326144313.673549-4-Mr.Bossman075@gmail.com> <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org> From: Jesse Taube In-Reply-To: <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 3/27/22 15:08, Krzysztof Kozlowski wrote: > On 26/03/2022 15:43, Jesse Taube wrote: >> Add i.MXRT1170 pinctrl binding Documentation >> >> Cc: Giulio Benetti >> Signed-off-by: Jesse Taube >> --- >> .../bindings/pinctrl/fsl,imxrt1170.yaml | 77 +++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> new file mode 100644 >> index 000000000000..2e880b3e537c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/fsl,imxrt1170.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Freescale i.MXRT1170 IOMUX Controller >> + >> +maintainers: >> + - Giulio Benetti >> + - Jesse Taube >> + >> +description: >> + Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this directory >> + for common binding part and usage. >> + >> +properties: >> + compatible: >> + const: fsl,imxrt1170-iomuxc >> + >> + reg: >> + maxItems: 1 >> + >> +# Client device subnode's properties >> +patternProperties: >> + 'grp$': >> + type: object >> + description: >> + Pinctrl node's client devices use subnodes for desired pin configuration. >> + Client device subnodes use below standard properties. >> + >> + properties: >> + fsl,pins: >> + description: >> + each entry consists of 6 integers and represents the mux and config >> + setting for one pin. The first 5 integers > + mux_val input_val> are specified using a PIN_FUNC_ID macro, which can >> + be found in . The last >> + integer CONFIG is the pad setting value like pull-up on this pin. Please >> + refer to i.MXRT1170 Reference Manual for detailed CONFIG settings. >> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >> + items: >> + items: >> + - description: | >> + "mux_reg" indicates the offset of mux register. >> + - description: | >> + "conf_reg" indicates the offset of pad configuration register. >> + - description: | >> + "input_reg" indicates the offset of select input register. >> + - description: | >> + "mux_val" indicates the mux value to be applied. >> + - description: | >> + "input_val" indicates the select input value to be applied. >> + - description: | >> + "pad_setting" indicates the pad configuration value to be applied. >> + required: >> + - fsl,pins >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg > > You miss pinctrl.yaml, why? In the file name? Because I forgot for the fsl,imxrt1050.yaml, I can change for both files. > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + iomuxc: iomuxc@400e8000 { >> + compatible = "fsl,imxrt1170-iomuxc"; >> + reg = <0x400e8000 0x4000>; >> + pinctrl_lpuart1: lpuart1grp { >> + fsl,pins = >> + <0x16C 0x3B0 0x620 0x0 0x0 0xf1>, >> + <0x170 0x3B4 0x61C 0x0 0x0 0xf1>; >> + }; >> + }; > > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21A1CC433F5 for ; Sun, 27 Mar 2022 19:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F49h0ZAuvASaKEQ8M9n7VIwK0q1SoZPXdAJCbdAwoqA=; b=R7XO6J4gjsUixX 3yNSP7ZFTVCpWHM/nMTrlSpMlAj95AYt24n8imJeGP8pozymich5Ldjaz6RnwLjjP9sP38ymQyBby Nr4HOILq/kiz+Fxe1yWSEBmvbYIqvzSeFKTApDlVoRUbMz8EzjGQgbzmVG9d5HKX5bh9yXe0V5kXw i55YLIuvtIDclYf8i14b8jWav1C3Ekgy16xrfgpQTpXN+dF9huRXyWpquIEZmAhfucWeBn3BwF5Eg KQPwXGUnBf68kG2Gpssf+5zw8tBzcwcnCftJvGMCwuhSM/alYVH4FgFKfhmIa2VxwPB3eGGmN7XZ2 hG777zrjj79QqcgZnUxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYYLC-005xpx-JQ; Sun, 27 Mar 2022 19:14:18 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYYL8-005xoY-NU for linux-arm-kernel@lists.infradead.org; Sun, 27 Mar 2022 19:14:16 +0000 Received: by mail-qk1-x72e.google.com with SMTP id v13so9913253qkv.3 for ; Sun, 27 Mar 2022 12:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=A9CFJgUP2awfrdRyvcJZlVsnkzemv2E9bRx9IkqLSpw=; b=RABDT1UvIgfs+0gsswBm8nKHVoEn9ahba0gZNNiPyBfg20ODYkKOkf+6w7wgCae2GB TOepgNu0ANmgOZTRuAsC5t7PK1Gd5kpJWxoycfuF7eH31ly8UD3/+CatusD8dRl9zZet +XhcSiOEG2isDxl5jHrBilPZ8VfkYyPKJA1PwdmqNEu5rI929SasNWqLcdExaht6V/yi pcvJhGdmtfm4b9tsimcfrVNw82AfnIKbrKL4pk1AwoBDkKLcnGxi/5MaxvFRj+Akec04 HjIXC0fNBw44T7nqIVpKfgtHMS+Ht2Dg+K04CvQcJdj8a2RIVuv9PmEUWnxFfj8kIlam 5fvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=A9CFJgUP2awfrdRyvcJZlVsnkzemv2E9bRx9IkqLSpw=; b=MQwh2hhOgB++O3AvzC8+eppZN3iFbq13dNkbCNeAR5WoSK71QlkPzgKNwDzLhJE/yG 0T47I8ktNiZRaX3niQFuzPTNeZoUTOY096e2L3qjCPTKaX9ucBNQLxD/S1kVSlMG6oLA mK0vtWA6x5Xcx2UOS7n2OwZ2eSokwp4SuHokO/J9bAtMxgDwB6RnlcchXnG6X4tsWt17 oOeuIauN2DA99WcGW6nywLgxiIXgeHURpahK5xkO2+q744rEGtsozq6Vns6g63N4bM1d OqGNsgD58gEynUqMSs5eWdbO35xbzK0oIJ1YEbJXiYkpFNdJHDZLV9Moxi0HAa+4U+w1 tsWw== X-Gm-Message-State: AOAM533mQZy/4atun/dU3oDB54N3fFkjpbU4C1yPCn7LRfFaOJlmg2wT i2Y4a5uE3DdFlIQdvcbaIT8= X-Google-Smtp-Source: ABdhPJwb3aJO02v5hTdlVjaWdOpqQQb7aYBwYQtrv+VUIaBVEI3QQ2+yzwBkjCsRNY85++BKSn/Jfw== X-Received: by 2002:a05:620a:199a:b0:67d:4bf0:4a73 with SMTP id bm26-20020a05620a199a00b0067d4bf04a73mr13511957qkb.684.1648408452470; Sun, 27 Mar 2022 12:14:12 -0700 (PDT) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id 64-20020a370343000000b0067b31f32693sm6888023qkd.109.2022.03.27.12.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Mar 2022 12:14:11 -0700 (PDT) Message-ID: <8ce4ea34-f389-6eff-2e5b-0f23641df219@gmail.com> Date: Sun, 27 Mar 2022 15:14:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v1 03/12] dt-bindings: pinctrl: add i.MXRT1170 pinctrl Documentation Content-Language: en-US To: Krzysztof Kozlowski , linux-imx@nxp.com Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, dev@lynxeye.de, marcel.ziswiler@toradex.com, tharvey@gateworks.com, leoyang.li@nxp.com, sebastian.reichel@collabora.com, cniedermaier@dh-electronics.com, clin@suse.com, giulio.benetti@benettiengineering.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org References: <20220326144313.673549-1-Mr.Bossman075@gmail.com> <20220326144313.673549-4-Mr.Bossman075@gmail.com> <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org> From: Jesse Taube In-Reply-To: <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220327_121414_815075_A327D7F9 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/27/22 15:08, Krzysztof Kozlowski wrote: > On 26/03/2022 15:43, Jesse Taube wrote: >> Add i.MXRT1170 pinctrl binding Documentation >> >> Cc: Giulio Benetti >> Signed-off-by: Jesse Taube >> --- >> .../bindings/pinctrl/fsl,imxrt1170.yaml | 77 +++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> new file mode 100644 >> index 000000000000..2e880b3e537c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/fsl,imxrt1170.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Freescale i.MXRT1170 IOMUX Controller >> + >> +maintainers: >> + - Giulio Benetti >> + - Jesse Taube >> + >> +description: >> + Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this directory >> + for common binding part and usage. >> + >> +properties: >> + compatible: >> + const: fsl,imxrt1170-iomuxc >> + >> + reg: >> + maxItems: 1 >> + >> +# Client device subnode's properties >> +patternProperties: >> + 'grp$': >> + type: object >> + description: >> + Pinctrl node's client devices use subnodes for desired pin configuration. >> + Client device subnodes use below standard properties. >> + >> + properties: >> + fsl,pins: >> + description: >> + each entry consists of 6 integers and represents the mux and config >> + setting for one pin. The first 5 integers > + mux_val input_val> are specified using a PIN_FUNC_ID macro, which can >> + be found in . The last >> + integer CONFIG is the pad setting value like pull-up on this pin. Please >> + refer to i.MXRT1170 Reference Manual for detailed CONFIG settings. >> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >> + items: >> + items: >> + - description: | >> + "mux_reg" indicates the offset of mux register. >> + - description: | >> + "conf_reg" indicates the offset of pad configuration register. >> + - description: | >> + "input_reg" indicates the offset of select input register. >> + - description: | >> + "mux_val" indicates the mux value to be applied. >> + - description: | >> + "input_val" indicates the select input value to be applied. >> + - description: | >> + "pad_setting" indicates the pad configuration value to be applied. >> + required: >> + - fsl,pins >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg > > You miss pinctrl.yaml, why? In the file name? Because I forgot for the fsl,imxrt1050.yaml, I can change for both files. > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + iomuxc: iomuxc@400e8000 { >> + compatible = "fsl,imxrt1170-iomuxc"; >> + reg = <0x400e8000 0x4000>; >> + pinctrl_lpuart1: lpuart1grp { >> + fsl,pins = >> + <0x16C 0x3B0 0x620 0x0 0x0 0xf1>, >> + <0x170 0x3B4 0x61C 0x0 0x0 0xf1>; >> + }; >> + }; > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel