From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] net/ixgbe: ensure link status is updated
Date: Mon, 10 Apr 2017 14:36:44 +0100
Message-ID: <8ce85605-3e52-6088-754e-29ee892681c6@intel.com>
References: <1479403792-11928-1-git-send-email-laurent.hardy@6wind.com>
 <1487262721-22370-1-git-send-email-olivier.matz@6wind.com>
 <20170330111959.43ac9078@platinum>
 <49759EB36A64CF4892C1AFEC9231E8D650A23CB0@PGSMSX101.gar.corp.intel.com>
 <58E24CC8.1080406@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Laurent Hardy <laurent.hardy@6wind.com>, "Dai, Wei" <wei.dai@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 7C38D2BBE
 for <dev@dpdk.org>; Mon, 10 Apr 2017 15:36:50 +0200 (CEST)
In-Reply-To: <58E24CC8.1080406@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/3/2017 2:23 PM, Laurent Hardy wrote:
> Hi Wei,
> Thanks for your reply.
> 
> If autoneg is false, then we set a default speed to the highest value 
> before performing the link setup.
> You are right, there is no relevant reason to keep this check on speed 
> mask> should be:
> +                       if (!autoneg)
> +                               speed = IXGBE_LINK_SPEED_10GB_FULL;

Hi Laurent,

Should we expect a new version of the patch with above update?

Thanks,
ferruh

> 
> Patch has been tested using testpmd with following setups:
> 
> Autoneg setup:
> =========
> - On dut, both ports of 82599 are connected to a switch with 1Gb ports
> - auto-negotiate option is enabled on switch
> 
> Defined speed setup:
> ============
> - set link speed to 1Gb on both ports of the switch connected to the dut
> 

<...>

> 
> 
> Thanks & regards,
> Laurent
> 
> On 03/30/2017 06:32 PM, Dai, Wei wrote:
>> Hi, Olivier
>>
>> Has anyone already tested this patch ?
>> Can you present some useful info on how to test it ?
>> Can I use ethtool with some argument to downgrade or upgrade the rate of peer port ?
>>
>> I have just run testpmd with 82599, the hw->phy. autoneg_advertised is 0 after rte_eal_init() and rte_eth_dev_start().
>> So I think the codes in if (!speed) { ... } is likely to be run.
>> I agree with most of your codes.
>> But why to limit speed of NIC to 10Gbps if autoneg is false and 10Gbps is supported ?
>> In this case,  how about setting multiple speed ?
>>
>> Thanks
>> -Wei
>>
>>
<...>