From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934029AbdIYJO6 (ORCPT ); Mon, 25 Sep 2017 05:14:58 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:36438 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbdIYJOz (ORCPT ); Mon, 25 Sep 2017 05:14:55 -0400 Subject: Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies To: Icenowy Zheng , Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-2-icenowy@aosc.io> From: Quentin Schulz Message-ID: <8cf69d3d-0004-b5dc-16e0-ce1a4f8c313b@free-electrons.com> Date: Mon, 25 Sep 2017 11:14:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170920151814.22461-2-icenowy@aosc.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has different Battery and USB power supplies than the > AXP series PMICs already supported by the kernel, but the AC power > supply is the same as AXP22x (as it can only detect the present/online > state of the AC power supply on both AXP22x and AXP803). > > Add compatible strings for the AXP803 Battery/USB power supplies. For AC > power supply the one on AXP803 is compatible with the one on AXP22x. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 1 + > Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > index c24886676a60..091e5471a8c6 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > @@ -4,6 +4,7 @@ Required Properties: > - compatible, one of: > "x-powers,axp209-battery-power-supply" > "x-powers,axp221-battery-power-supply" > + "x-powers,axp803-battery-power-supply" > > This node is a subnode of the axp20x/axp22x PMIC. > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > index ba8d35f66cbe..f30e3bf8d23f 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > @@ -4,6 +4,7 @@ Required Properties: > -compatible: One of: "x-powers,axp202-usb-power-supply" > "x-powers,axp221-usb-power-supply" > "x-powers,axp223-usb-power-supply" > + "x-powers,axp803-usb-power-supply" No. You are adding support for AC and battery power supply in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Date: Mon, 25 Sep 2017 11:14:42 +0200 Message-ID: <8cf69d3d-0004-b5dc-16e0-ce1a4f8c313b@free-electrons.com> References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-2-icenowy@aosc.io> Reply-To: quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170920151814.22461-2-icenowy-h8G6r0blFSE@public.gmane.org> Content-Language: en-US List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng , Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has different Battery and USB power supplies than the > AXP series PMICs already supported by the kernel, but the AC power > supply is the same as AXP22x (as it can only detect the present/online > state of the AC power supply on both AXP22x and AXP803). > > Add compatible strings for the AXP803 Battery/USB power supplies. For AC > power supply the one on AXP803 is compatible with the one on AXP22x. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 1 + > Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > index c24886676a60..091e5471a8c6 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > @@ -4,6 +4,7 @@ Required Properties: > - compatible, one of: > "x-powers,axp209-battery-power-supply" > "x-powers,axp221-battery-power-supply" > + "x-powers,axp803-battery-power-supply" > > This node is a subnode of the axp20x/axp22x PMIC. > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > index ba8d35f66cbe..f30e3bf8d23f 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > @@ -4,6 +4,7 @@ Required Properties: > -compatible: One of: "x-powers,axp202-usb-power-supply" > "x-powers,axp221-usb-power-supply" > "x-powers,axp223-usb-power-supply" > + "x-powers,axp803-usb-power-supply" No. You are adding support for AC and battery power supply in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: quentin.schulz@free-electrons.com (Quentin Schulz) Date: Mon, 25 Sep 2017 11:14:42 +0200 Subject: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies In-Reply-To: <20170920151814.22461-2-icenowy@aosc.io> References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-2-icenowy@aosc.io> Message-ID: <8cf69d3d-0004-b5dc-16e0-ce1a4f8c313b@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has different Battery and USB power supplies than the > AXP series PMICs already supported by the kernel, but the AC power > supply is the same as AXP22x (as it can only detect the present/online > state of the AC power supply on both AXP22x and AXP803). > > Add compatible strings for the AXP803 Battery/USB power supplies. For AC > power supply the one on AXP803 is compatible with the one on AXP22x. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 1 + > Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > index c24886676a60..091e5471a8c6 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt > @@ -4,6 +4,7 @@ Required Properties: > - compatible, one of: > "x-powers,axp209-battery-power-supply" > "x-powers,axp221-battery-power-supply" > + "x-powers,axp803-battery-power-supply" > > This node is a subnode of the axp20x/axp22x PMIC. > > diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > index ba8d35f66cbe..f30e3bf8d23f 100644 > --- a/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > +++ b/Documentation/devicetree/bindings/power/supply/axp20x_usb_power.txt > @@ -4,6 +4,7 @@ Required Properties: > -compatible: One of: "x-powers,axp202-usb-power-supply" > "x-powers,axp221-usb-power-supply" > "x-powers,axp223-usb-power-supply" > + "x-powers,axp803-usb-power-supply" No. You are adding support for AC and battery power supply in this patchset, not for USB. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com