From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjlPq-0007wa-S6 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjlPk-0003uO-Ug for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:58:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjlPk-0003u7-PY for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:58:08 -0400 References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-3-git-send-email-arei.gonglei@huawei.com> <20160913092050.GD30949@redhat.com> From: Paolo Bonzini Message-ID: <8cfc0ce6-babb-6115-f64d-4f17074ae8f7@redhat.com> Date: Tue, 13 Sep 2016 12:58:01 +0200 MIME-Version: 1.0 In-Reply-To: <20160913092050.GD30949@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 02/15] crypto: introduce crypto queue handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Gonglei Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, peter.huangpeng@huawei.com, luonengjun@huawei.com, mst@redhat.com, stefanha@redhat.com, weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de, xin.zeng@intel.com, claudio.fontana@huawei.com, nmorey@kalray.eu, vincent.jardin@6wind.com On 13/09/2016 11:20, Daniel P. Berrange wrote: >> > +typedef struct CryptoPacket CryptoPacket; >> > +typedef struct CryptoQueue CryptoQueue; >> > +typedef struct CryptoPacketBuf CryptoPacketBuf; >> > + >> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); > As previously, I'd expect naming of > > QCryptoCryptodevPacket > QCryptoCryptodevPacketBuf > QCryptoCryptodevQueue > Gonglei, you are copying a lot of code from network backends. I am not sure why you would need a queue for virtio-crypto rather than a direct connection between frontend and backend (and the backend would be QEMU crypto APIs, like Daniel suggested). Paolo