On 08/24/2017 11:05 AM, Stefan Hajnoczi wrote: > On Thu, Aug 24, 2017 at 4:52 PM, Eric Blake wrote: >> On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote: >>> See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage. >>> >>> This is a rare crash that we'll probably only see in testing. It only seems to >>> happen with UNIX domain sockets. >> >> Rare enough that I don't think it is 2.10-rc4 material. I'll review, >> and if I don't find anything needing a respin, I'll add it to my NBD >> queue for 2.11. > > Great. This is 2.11 material. Hmm - I wonder if https://bugs.launchpad.net/qemu/+bug/1712818 is related to this. I really don't want to delay 2.10 further (downstream distros can backport fixes) - but comment 3 stating that crashes are less frequent but still possible with -rc4 is not good. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org