From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052D8C10F13 for ; Thu, 11 Apr 2019 13:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8FA62133D for ; Thu, 11 Apr 2019 13:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbfDKNsP (ORCPT ); Thu, 11 Apr 2019 09:48:15 -0400 Received: from foss.arm.com ([217.140.101.70]:43524 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbfDKNsP (ORCPT ); Thu, 11 Apr 2019 09:48:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01C0480D; Thu, 11 Apr 2019 06:48:15 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 116B63F68F; Thu, 11 Apr 2019 06:48:13 -0700 (PDT) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs To: Heiko Stuebner Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> <2463729.IUJ8mRE5Ts@phil> From: Robin Murphy Message-ID: <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Date: Thu, 11 Apr 2019 14:48:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2463729.IUJ8mRE5Ts@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2019 13:46, Heiko Stuebner wrote: > Hi Robin, > > Am Samstag, 30. März 2019, 00:24:16 CEST schrieb Robin Murphy: >> On 2019-03-27 12:00 pm, Heiko Stuebner wrote: >>> Hi, >>> >>> Am Dienstag, 26. März 2019, 14:49:16 CET schrieb Katsuhiro Suzuki: >>>> Hello Robin, >>>> >>>> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, >>>> please revert my patch if you need. >>> >>> I've dropped the patch from my queue now. >>> >>>> BTW, there are DMA properties in RK3328 device-tree like as this patch. >>>> RK3328 UART DMA could not work correctly too...?? >>> >>> I remember Rockcihip dma-controllers having issues with burst-sizes >>> and flushing (there is a no-flushp option in pl330), so it's >>> possible that all share the same error up to rk3399 and rk3328 >>> >>> But so far no-one has shouted regarding the rk3328. >> >> Let me be the first, then, I guess :) >> >> I found an easy way to observe the problem on my 3399, and I've just >> fired up my 3328 box with a 5.0 distro kernel to find that it behaves >> the same. Basically just dump a large pile of text into 'less' on the >> serial console, and scroll through line-by-line - certain lines get >> dropped except for a few characters at the end. >> >> I'll see if I can narrow it down a bit, starting with trying >> broken-flushp... > > did you manage to find time for that test you wanted to do? Sadly not - I got somewhat distracted by the ethernet thing, and since then I've had too much else going on to follow up on any of my 'for fun' projects :( If it helps, from a quick look based on what I can remember off-hand, Rockchip UARTs in general have probably been using DMA since 4.19 with d8095f94e195 ("dmaengine: add support for reporting pause and resume separately"). Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEBBFC10F13 for ; Thu, 11 Apr 2019 13:48:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EAE42133D for ; Thu, 11 Apr 2019 13:48:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LHvCF/F1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EAE42133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KAQ+KRlacyyR5GrJgocBrwRABAW79eYztEXHzaa1xOk=; b=LHvCF/F1wmF5Q3dZD8NTaYzeh AeszGz0JCOsp9HUmVlPfU/cKRG12A0vLfkpvAJvxcbSoCTZS2jaOf3AEnBZpqO15WZU1EyWCP9Psr lAzMLU/0Fv33wtWyK18bGU4oy6GVRyLWtlOmpVL5D3y0+aLOAt8hUN/MkVVPACisZJM66Js72sYfu VQc/vdQKJN1krATl+f90DrBGLGzFfW2MkdL4vMraAqbVXQz3v1GEKeF8UL08kz/9zun5A4IiXI22Q AuuSLOSHhQ1GzFikSaN7fEcwRs3T8Ts5HsdKc5XI04CIMEKf5DGVlBJLVZkAzrqdnz6IOJHLlgze+ 7BRrw4qtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEa3x-0007Tm-1x; Thu, 11 Apr 2019 13:48:21 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEa3t-0007Ss-FP; Thu, 11 Apr 2019 13:48:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01C0480D; Thu, 11 Apr 2019 06:48:15 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 116B63F68F; Thu, 11 Apr 2019 06:48:13 -0700 (PDT) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs To: Heiko Stuebner References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> <2463729.IUJ8mRE5Ts@phil> From: Robin Murphy Message-ID: <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Date: Thu, 11 Apr 2019 14:48:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2463729.IUJ8mRE5Ts@phil> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_064817_524058_16079F6E X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMDQvMjAxOSAxMzo0NiwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4gSGkgUm9iaW4sCj4g Cj4gQW0gU2Ftc3RhZywgMzAuIE3DpHJ6IDIwMTksIDAwOjI0OjE2IENFU1Qgc2NocmllYiBSb2Jp biBNdXJwaHk6Cj4+IE9uIDIwMTktMDMtMjcgMTI6MDAgcG0sIEhlaWtvIFN0dWVibmVyIHdyb3Rl Ogo+Pj4gSGksCj4+Pgo+Pj4gQW0gRGllbnN0YWcsIDI2LiBNw6RyeiAyMDE5LCAxNDo0OToxNiBD RVQgc2NocmllYiBLYXRzdWhpcm8gU3V6dWtpOgo+Pj4+IEhlbGxvIFJvYmluLAo+Pj4+Cj4+Pj4g U29ycnkgZm9yIGluY29udmVuaWVuY2UuIFNpbmNlIEkgZG9uJ3QgYWRoZXJlIGVuYWJsaW5nIERN QSBmb3IgVUFSVHMsCj4+Pj4gcGxlYXNlIHJldmVydCBteSBwYXRjaCBpZiB5b3UgbmVlZC4KPj4+ Cj4+PiBJJ3ZlIGRyb3BwZWQgdGhlIHBhdGNoIGZyb20gbXkgcXVldWUgbm93Lgo+Pj4KPj4+PiBC VFcsIHRoZXJlIGFyZSBETUEgcHJvcGVydGllcyBpbiBSSzMzMjggZGV2aWNlLXRyZWUgbGlrZSBh cyB0aGlzIHBhdGNoLgo+Pj4+IFJLMzMyOCBVQVJUIERNQSBjb3VsZCBub3Qgd29yayBjb3JyZWN0 bHkgdG9vLi4uPz8KPj4+Cj4+PiBJIHJlbWVtYmVyIFJvY2tjaWhpcCBkbWEtY29udHJvbGxlcnMg aGF2aW5nIGlzc3VlcyB3aXRoIGJ1cnN0LXNpemVzCj4+PiBhbmQgZmx1c2hpbmcgKHRoZXJlIGlz IGEgbm8tZmx1c2hwIG9wdGlvbiBpbiBwbDMzMCksIHNvIGl0J3MKPj4+IHBvc3NpYmxlIHRoYXQg YWxsIHNoYXJlIHRoZSBzYW1lIGVycm9yIHVwIHRvIHJrMzM5OSBhbmQgcmszMzI4Cj4+Pgo+Pj4g QnV0IHNvIGZhciBuby1vbmUgaGFzIHNob3V0ZWQgcmVnYXJkaW5nIHRoZSByazMzMjguCj4+Cj4+ IExldCBtZSBiZSB0aGUgZmlyc3QsIHRoZW4sIEkgZ3Vlc3MgOikKPj4KPj4gSSBmb3VuZCBhbiBl YXN5IHdheSB0byBvYnNlcnZlIHRoZSBwcm9ibGVtIG9uIG15IDMzOTksIGFuZCBJJ3ZlIGp1c3QK Pj4gZmlyZWQgdXAgbXkgMzMyOCBib3ggd2l0aCBhIDUuMCBkaXN0cm8ga2VybmVsIHRvIGZpbmQg dGhhdCBpdCBiZWhhdmVzCj4+IHRoZSBzYW1lLiBCYXNpY2FsbHkganVzdCBkdW1wIGEgbGFyZ2Ug cGlsZSBvZiB0ZXh0IGludG8gJ2xlc3MnIG9uIHRoZQo+PiBzZXJpYWwgY29uc29sZSwgYW5kIHNj cm9sbCB0aHJvdWdoIGxpbmUtYnktbGluZSAtIGNlcnRhaW4gbGluZXMgZ2V0Cj4+IGRyb3BwZWQg ZXhjZXB0IGZvciBhIGZldyBjaGFyYWN0ZXJzIGF0IHRoZSBlbmQuCj4+Cj4+IEknbGwgc2VlIGlm IEkgY2FuIG5hcnJvdyBpdCBkb3duIGEgYml0LCBzdGFydGluZyB3aXRoIHRyeWluZwo+PiBicm9r ZW4tZmx1c2hwLi4uCj4gCj4gZGlkIHlvdSBtYW5hZ2UgdG8gZmluZCB0aW1lIGZvciB0aGF0IHRl c3QgeW91IHdhbnRlZCB0byBkbz8KClNhZGx5IG5vdCAtIEkgZ290IHNvbWV3aGF0IGRpc3RyYWN0 ZWQgYnkgdGhlIGV0aGVybmV0IHRoaW5nLCBhbmQgc2luY2UgCnRoZW4gSSd2ZSBoYWQgdG9vIG11 Y2ggZWxzZSBnb2luZyBvbiB0byBmb2xsb3cgdXAgb24gYW55IG9mIG15ICdmb3IgZnVuJyAKcHJv amVjdHMgOigKCklmIGl0IGhlbHBzLCBmcm9tIGEgcXVpY2sgbG9vayBiYXNlZCBvbiB3aGF0IEkg Y2FuIHJlbWVtYmVyIG9mZi1oYW5kLCAKUm9ja2NoaXAgVUFSVHMgaW4gZ2VuZXJhbCBoYXZlIHBy b2JhYmx5IGJlZW4gdXNpbmcgRE1BIHNpbmNlIDQuMTkgd2l0aCAKZDgwOTVmOTRlMTk1ICgiZG1h ZW5naW5lOiBhZGQgc3VwcG9ydCBmb3IgcmVwb3J0aW5nIHBhdXNlIGFuZCByZXN1bWUgCnNlcGFy YXRlbHkiKS4KClJvYmluLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=