* [PATCH] xfs_io: Add missing perror for write_once (-O)
@ 2017-12-06 18:36 Goldwyn Rodrigues
2018-03-02 3:12 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Goldwyn Rodrigues @ 2017-12-06 18:36 UTC (permalink / raw)
To: linux-xfs; +Cc: Goldwyn Rodrigues
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
This got missed in the last set of patches.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
io/pwrite.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/io/pwrite.c b/io/pwrite.c
index a89edfd0..afbe4284 100644
--- a/io/pwrite.c
+++ b/io/pwrite.c
@@ -271,8 +271,10 @@ write_once(
{
ssize_t bytes;
bytes = do_pwrite(file->fd, offset, count, count, pwritev2_flags);
- if (bytes < 0)
+ if (bytes < 0) {
+ perror("pwrite");
return -1;
+ }
*total = bytes;
return 1;
}
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_io: Add missing perror for write_once (-O)
2017-12-06 18:36 [PATCH] xfs_io: Add missing perror for write_once (-O) Goldwyn Rodrigues
@ 2018-03-02 3:12 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2018-03-02 3:12 UTC (permalink / raw)
To: Goldwyn Rodrigues, linux-xfs; +Cc: Goldwyn Rodrigues
On 12/6/17 12:36 PM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> This got missed in the last set of patches.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Sorry for missing this until now.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> io/pwrite.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/io/pwrite.c b/io/pwrite.c
> index a89edfd0..afbe4284 100644
> --- a/io/pwrite.c
> +++ b/io/pwrite.c
> @@ -271,8 +271,10 @@ write_once(
> {
> ssize_t bytes;
> bytes = do_pwrite(file->fd, offset, count, count, pwritev2_flags);
> - if (bytes < 0)
> + if (bytes < 0) {
> + perror("pwrite");
> return -1;
> + }
> *total = bytes;
> return 1;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-02 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 18:36 [PATCH] xfs_io: Add missing perror for write_once (-O) Goldwyn Rodrigues
2018-03-02 3:12 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.