From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA659C433E0 for ; Thu, 30 Jul 2020 13:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B430B20829 for ; Thu, 30 Jul 2020 13:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20150623.gappssmtp.com header.i=@ndufresne-ca.20150623.gappssmtp.com header.b="ElJmz2ZY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbgG3N5h (ORCPT ); Thu, 30 Jul 2020 09:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbgG3N5g (ORCPT ); Thu, 30 Jul 2020 09:57:36 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41C34C061574 for ; Thu, 30 Jul 2020 06:57:36 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id 2so21506259qkf.10 for ; Thu, 30 Jul 2020 06:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=swB4gM5/Sd34+RuLXe4ebGLoqKKPMlJrxzDtJ86OY8o=; b=ElJmz2ZYVZwbLk/3G64W4s/3aJGLxePkXOtMUKp0atmEd4+v8cnbJbC3GS1fxeMKXb RO0SxPF8d2cy2PqimJ+cI0MM4Umk4mHoHUyzINy/3fhrqK5ikEv/4MxDWTEBeowS6ROl b6CfyD/bZkLZnpUIkqED3RJwQC5vkGSJin0RctcQFE57iW8XDlgQlVbNt1mJ9AABAlI2 AT0Ac4QBita8mYG51kmHbZXIe3UUOvZKvPQk4gBTcy+Jc2jmvrw06dXQPX3aMeIv8ZiH b4yxobYO9/y9T1BUjqEz9HoEB9tPYD/+2CNStQpALXdf3lWzNV8X+ON5KqFx3czETx+M 5LMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=swB4gM5/Sd34+RuLXe4ebGLoqKKPMlJrxzDtJ86OY8o=; b=jDK5VDxLZqSIuJYpQtTp3uQMGai+h990rN5ZtRg12iG37Ubiia1JtXC7DgjMyfzBJB fnMtgB/q5aBX4HazAM9MLDOwBjBiy3C/9L2erYP5KL/xPFMCUK+UPosNiJGb8y+a9O/O CmxIdtCYkDJ5KiAhL+lQu0VsOoUWqnIzL6IF5aXr796yOECECJSRGUkic1JpX9YQKTe6 lBb0w6lgrI5rSvfbNfosb27Q2qnsinl4ugMTcpRUzJrEnZgMR3CSuPA745v64vVLc/q7 2h8lJ3FG04CQU/bYbMlC0ix28Dldud4R6gLdMGnq4rLAuGef575yRMckeBSKi9W7NAD/ VASQ== X-Gm-Message-State: AOAM5339S/ux68VMaglJZUHRBNNtWIsqTCVPZHFyzzM7AtJIQC6ih169 A4CnavUkxPZS6tkJlDjuMqCocg== X-Google-Smtp-Source: ABdhPJzPkHLNJBZVdH8dOzQCTNrpkJEAuR+3sHOQnsQ2ETHZ0yd/YXNBy4jXja0jaOUk3UBJBgCKDQ== X-Received: by 2002:a37:6644:: with SMTP id a65mr37224452qkc.4.1596117455468; Thu, 30 Jul 2020 06:57:35 -0700 (PDT) Received: from skullcanyon ([192.222.193.21]) by smtp.gmail.com with ESMTPSA id x29sm4824919qtx.74.2020.07.30.06.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 06:57:34 -0700 (PDT) Message-ID: <8d287abcc4e2e86b5eaeca5a97b57004be8f6669.camel@ndufresne.ca> Subject: Re: [PATCH v2 0/6] Add new controls for CQ and Frame-skip From: Nicolas Dufresne To: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Mauro Carvalho Chehab , Kyungmin Park , Kamil Debski , Jeongtae Park , Andrzej Hajda , Ezequiel Garcia , Maheshwar Ajja Date: Thu, 30 Jul 2020 09:57:33 -0400 In-Reply-To: <20200721074538.505-1-stanimir.varbanov@linaro.org> References: <20200721074538.505-1-stanimir.varbanov@linaro.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Le mardi 21 juillet 2020 à 10:45 +0300, Stanimir Varbanov a écrit : > Hello, > > Here is v2 with following changes: > > * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas Thanks for this enhancement. No more comments on the doc from me. > * 4/6 Fixed compile warning > > Previous version can be found at [1]. > > regards, > Stan > > [1] https://lkml.org/lkml/2020/7/20/619 > > Maheshwar Ajja (1): > media: v4l2-ctrls: Add encoder constant quality control > > Stanimir Varbanov (5): > venus: venc: Add support for constant quality control > media: v4l2-ctrl: Add frame-skip std encoder control > venus: venc: Add support for frame-skip mode v4l2 control > media: s5p-mfc: Use standard frame skip mode control > media: docs: Deprecate mfc frame skip control > > .../media/v4l/ext-ctrls-codec.rst | 53 +++++++++++++++++++ > drivers/media/platform/qcom/venus/core.h | 2 + > drivers/media/platform/qcom/venus/hfi_cmds.c | 37 ++++++++++++- > .../media/platform/qcom/venus/hfi_helper.h | 10 +++- > drivers/media/platform/qcom/venus/venc.c | 20 +++++-- > .../media/platform/qcom/venus/venc_ctrls.c | 18 ++++++- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 6 +++ > drivers/media/v4l2-core/v4l2-ctrls.c | 12 +++++ > include/uapi/linux/v4l2-controls.h | 8 +++ > 9 files changed, 160 insertions(+), 6 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96B8C433DF for ; Thu, 30 Jul 2020 13:59:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4DFF20829 for ; Thu, 30 Jul 2020 13:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kjcQ0ZFp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ndufresne-ca.20150623.gappssmtp.com header.i=@ndufresne-ca.20150623.gappssmtp.com header.b="ElJmz2ZY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4DFF20829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ndufresne.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mgGp6+0ku4dexodUuSxBLlMLRITDbwlnQSPYdQI9JN0=; b=kjcQ0ZFpKoa+Z4rQ4Vz5DU68d FpCe9nULdqbx3dnvWUC8FXEKRFM2HMsRszkGLGdIujKhXrjqZpNR2nM/It2KBDhLjP3P/JOjlOgF7 qYAnBixuTk4kwqnX6edYUtBo5BRY//PK7VoVoFf+OwOEcGf3Dk0uAcjS+r0Aan3UhNAyW22lDPcj8 uZI5gPE5O3Oapx4Ti2jiDfzlPYlZKcTcU+McCUtsjgu6AcBKMegcxDh+sIay5DYFbt7PbdMSnkA2u 12SAqiEQirYjEWOggUkeCjmcHd157ZN7QWu10DrJbmlwgttiiAH5XbsK7GaG6iE3uCwYyHpvXTBbM 1FzbYFmIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1942-0000Oe-EE; Thu, 30 Jul 2020 13:57:42 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k193z-0000Mr-2B for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 13:57:40 +0000 Received: by mail-qk1-x744.google.com with SMTP id g26so25663412qka.3 for ; Thu, 30 Jul 2020 06:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=swB4gM5/Sd34+RuLXe4ebGLoqKKPMlJrxzDtJ86OY8o=; b=ElJmz2ZYVZwbLk/3G64W4s/3aJGLxePkXOtMUKp0atmEd4+v8cnbJbC3GS1fxeMKXb RO0SxPF8d2cy2PqimJ+cI0MM4Umk4mHoHUyzINy/3fhrqK5ikEv/4MxDWTEBeowS6ROl b6CfyD/bZkLZnpUIkqED3RJwQC5vkGSJin0RctcQFE57iW8XDlgQlVbNt1mJ9AABAlI2 AT0Ac4QBita8mYG51kmHbZXIe3UUOvZKvPQk4gBTcy+Jc2jmvrw06dXQPX3aMeIv8ZiH b4yxobYO9/y9T1BUjqEz9HoEB9tPYD/+2CNStQpALXdf3lWzNV8X+ON5KqFx3czETx+M 5LMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=swB4gM5/Sd34+RuLXe4ebGLoqKKPMlJrxzDtJ86OY8o=; b=ceyMh2uSO+e40Nd+q0wRdtcCcI+YcCAgbGbNNzIctVVlnzVBVZNyFVvaKUyB2bD7CE kovm4dIsOUAxA3tqG0w9vQhAcgQNb8u7y60ANih+A84E5iYOKHa57o5UpMJTrVgaMAO9 TCyiO0azcohNxLDc4syu0+kfhjmKXmQRvO0h/RjtAogWb16IrEDF926t5EBiB6f0CNLl y5oVtB28qwNxJ+UrNnCbiYmBrZ/85H9mcJp0ew1hmNepMD82ajjCx7SZZxOlMd8Y36vG mv9Sup1+MH7Yd6nUcEqO/E/A1TtYhfm3J7BvJ3SKVWS5fQSDvlHArgR0+xDpSS3Aw+ye cjPQ== X-Gm-Message-State: AOAM530rTIE++pPOn/Q+31JGUy58VnWiMWCMFSE4MBYEvQoUF+rDaHOE sMtQOWOHIAIh+9Kf7Gq5994cQdV6NpPXsgeA X-Google-Smtp-Source: ABdhPJzPkHLNJBZVdH8dOzQCTNrpkJEAuR+3sHOQnsQ2ETHZ0yd/YXNBy4jXja0jaOUk3UBJBgCKDQ== X-Received: by 2002:a37:6644:: with SMTP id a65mr37224452qkc.4.1596117455468; Thu, 30 Jul 2020 06:57:35 -0700 (PDT) Received: from skullcanyon ([192.222.193.21]) by smtp.gmail.com with ESMTPSA id x29sm4824919qtx.74.2020.07.30.06.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 06:57:34 -0700 (PDT) Message-ID: <8d287abcc4e2e86b5eaeca5a97b57004be8f6669.camel@ndufresne.ca> Subject: Re: [PATCH v2 0/6] Add new controls for CQ and Frame-skip From: Nicolas Dufresne To: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Thu, 30 Jul 2020 09:57:33 -0400 In-Reply-To: <20200721074538.505-1-stanimir.varbanov@linaro.org> References: <20200721074538.505-1-stanimir.varbanov@linaro.org> User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_095739_169012_C6851FD6 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maheshwar Ajja , Andrzej Hajda , Kamil Debski , Jeongtae Park , Kyungmin Park , Mauro Carvalho Chehab , Ezequiel Garcia Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgbWFyZGkgMjEganVpbGxldCAyMDIwIMOgIDEwOjQ1ICswMzAwLCBTdGFuaW1pciBWYXJiYW5v diBhIMOpY3JpdCA6Cj4gSGVsbG8sCj4gCj4gSGVyZSBpcyB2MiB3aXRoIGZvbGxvd2luZyBjaGFu Z2VzOgo+IAo+ICAqIDMvNiBBZGRlZCByZWZlcmVuY2VzIGZvciBWQlYgc2l6ZSBhbmQgaDI2NCBD UEIgc2l6ZSAtIHJlcXVlc3RlZCBieSBOaWNvbGFzCgpUaGFua3MgZm9yIHRoaXMgZW5oYW5jZW1l bnQuIE5vIG1vcmUgY29tbWVudHMgb24gdGhlIGRvYyBmcm9tIG1lLgoKPiAgKiA0LzYgRml4ZWQg Y29tcGlsZSB3YXJuaW5nCj4gCj4gUHJldmlvdXMgdmVyc2lvbiBjYW4gYmUgZm91bmQgYXQgWzFd Lgo+IAo+IHJlZ2FyZHMsCj4gU3Rhbgo+IAo+IFsxXSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAy MC83LzIwLzYxOQo+IAo+IE1haGVzaHdhciBBamphICgxKToKPiAgIG1lZGlhOiB2NGwyLWN0cmxz OiBBZGQgZW5jb2RlciBjb25zdGFudCBxdWFsaXR5IGNvbnRyb2wKPiAKPiBTdGFuaW1pciBWYXJi YW5vdiAoNSk6Cj4gICB2ZW51czogdmVuYzogQWRkIHN1cHBvcnQgZm9yIGNvbnN0YW50IHF1YWxp dHkgY29udHJvbAo+ICAgbWVkaWE6IHY0bDItY3RybDogQWRkIGZyYW1lLXNraXAgc3RkIGVuY29k ZXIgY29udHJvbAo+ICAgdmVudXM6IHZlbmM6IEFkZCBzdXBwb3J0IGZvciBmcmFtZS1za2lwIG1v ZGUgdjRsMiBjb250cm9sCj4gICBtZWRpYTogczVwLW1mYzogVXNlIHN0YW5kYXJkIGZyYW1lIHNr aXAgbW9kZSBjb250cm9sCj4gICBtZWRpYTogZG9jczogRGVwcmVjYXRlIG1mYyBmcmFtZSBza2lw IGNvbnRyb2wKPiAKPiAgLi4uL21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0ICAgICAgICAg ICAgIHwgNTMgKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fj b20vdmVudXMvY29yZS5oICAgICAgfCAgMiArCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNv bS92ZW51cy9oZmlfY21kcy5jICB8IDM3ICsrKysrKysrKysrKy0KPiAgLi4uL21lZGlhL3BsYXRm b3JtL3Fjb20vdmVudXMvaGZpX2hlbHBlci5oICAgIHwgMTAgKysrLQo+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL3Fjb20vdmVudXMvdmVuYy5jICAgICAgfCAyMCArKysrKy0tCj4gIC4uLi9tZWRp YS9wbGF0Zm9ybS9xY29tL3ZlbnVzL3ZlbmNfY3RybHMuYyAgICB8IDE4ICsrKysrKy0KPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS9zNXAtbWZjL3M1cF9tZmNfZW5jLmMgIHwgIDYgKysrCj4gIGRy aXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItY3RybHMuYyAgICAgICAgICB8IDEyICsrKysrCj4g IGluY2x1ZGUvdWFwaS9saW51eC92NGwyLWNvbnRyb2xzLmggICAgICAgICAgICB8ICA4ICsrKwo+ ICA5IGZpbGVzIGNoYW5nZWQsIDE2MCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK