From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E71C43217 for ; Wed, 23 Mar 2022 03:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241439AbiCWDQQ (ORCPT ); Tue, 22 Mar 2022 23:16:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231637AbiCWDQN (ORCPT ); Tue, 22 Mar 2022 23:16:13 -0400 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CEF36545; Tue, 22 Mar 2022 20:14:44 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id DF5B9580259; Tue, 22 Mar 2022 23:14:43 -0400 (EDT) Received: from imap44 ([10.202.2.94]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 23:14:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=L0SvsihPk0D6/q 9wCsLi7ZzaZZ1wSYEuefF72MQXOXg=; b=PzEyKpMYj6Pf1xaYL4WZi9/YHBolcN DmW6NTOixVYflJ6WoBxgBksMGQxi56btWsGQ+DPWW0PlmsTb8FEkFUokuV1dv7zb 9qBApPrPkm0HpvWcBV4oBC6iLiZQqXn9ktNs1yZ6Efd4CgO1g3ndFxYDktUhBk6a c2IcQjO56Fb50VE04t1lwjxWYhN9N5rAFZuSTy/FlhBShf/AWuU//7QL5jj0p/so mLiA+6bbNL9y1BBfuc0nQ469oBZ0L6pho4kOmUugSR3H3PJZMHbs2aSd4lC7u4PB BpVnSpvK7PVt2R842XlVYePAkVEcwGei3WGG0MYnKNtyYKZlX50+Cw2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=L0SvsihPk0D6/q9wCsLi7ZzaZZ1wSYEuefF72MQXO Xg=; b=QJczCdVtsEOknGpSj6yCcMEeWP/9teRXgWQsyKc1JoI2hlSP5FprJ+6AZ wa2za9+Has9VuNsOfSAXfpLSmtDA+GKGMylVhjszUeOjrfXmHyErH9BK4i4cZdH+ SMpGvEYGpgSY7UUibE5Aj5eZP7LQ2niJbC7i/OpDxKmihAmN9SqWkoz2tw4NUgpT tHYDIk2lyUK+lD3qFtUO0tuRZmyk3L0KR3neZeHbi2WoFSlBbmFwrKiTV3Uz/dUU 8srcxAwMIQwS7hIgbfstcgWJu4ye5iQbT15VdeX7OOHiQfAITNqvy5r8vXpt7ZIV gffBnpeh3kpAlq/sIq7VoAgDGc2HA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegiedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedflfhi rgiguhhnucgjrghnghdfuceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh eqnecuggftrfgrthhtvghrnheptedtjedvvddthffgheeujedttddtgfektdeghfeltdek leefhffhleelvdejkeffnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigr nhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8646DFA0AA7; Tue, 22 Mar 2022 23:14:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4907-g25ce6f34a9-fm-20220311.001-g25ce6f34 Mime-Version: 1.0 Message-Id: <8d474c46-c354-4dec-920d-dbbc67377690@www.fastmail.com> In-Reply-To: References: <20220321162916.1116541-1-15330273260@189.cn> <20220321162916.1116541-3-15330273260@189.cn> <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com> <2c671752-6684-f87b-7b2d-90568d36adde@189.cn> <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> Date: Wed, 23 Mar 2022 03:14:23 +0000 From: "Jiaxun Yang" To: "Sui Jingfeng" <15330273260@189.cn>, "Maxime Ripard" , "Thomas Zimmermann" , "Roland Scheidegger" , "Zack Rusin" , "Christian Gmeiner" , "David Airlie" , "Daniel Vetter" , "Rob Herring" , "Thomas Bogendoerfer" , "Dan Carpenter" , "Krzysztof Kozlowski" , "Andrey Zhizhikin" , "Sam Ravnborg" , "David S . Miller" , "Lucas Stach" , "Maarten Lankhorst" , "Ilia Mirkin" , "Qing Zhang" , suijingfeng Cc: "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, "Huacai Chen" , "Tiezhu Yang" , liyi@loongson.cn Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E5=9C=A82022=E5=B9=B43=E6=9C=8823=E6=97=A5=E4=B8=89=E6=9C=88 =E4=B8=8A=E5= =8D=883:07=EF=BC=8CSui Jingfeng=E5=86=99=E9=81=93=EF=BC=9A > On 2022/3/23 10:29, Jiaxun Yang wrote: >> >> >> =E5=9C=A8 2022/3/23 1:53, Sui Jingfeng =E5=86=99=E9=81=93: >>> Hi, Jiaxun >>> >>> Build all dts into vmlinuz will make the vmlinuz bigger and bigger. >>> How does the kernel get the dtb is another big issue, either from=20 >>> built-in >>> dtb or pass from the firmware(pmon and uefi etc). This should be >>> solved with another patch carefully. Providing board specific dts >>> helps to code review, it helps reviewers understand that there are >>> variant boards and have to be express with different OF graph. >> Hi, >> >> I insist my taste on those code. If the only intention is to demonstr= ate >> the usage of the driver then please just leave them in dt document >> or commit message. >> >>> >>> Now, there are about 6 dts under arch/mips/boot/dts/loongson/, >>> Suppose loongson have 1000+ different board, do you want built all >>> of them into vmlinuz? >> Note that we are supporting all those boards on "platform" bias. Which >> means if they share similar design then they will use the same DTS. >> If we have a new design then unfortunately our kernel binary must gro= w. >> >> For those who intended to build a size-optimized kernel they will be >> able to disable unused DTS in Kconfig. >> >> If you want to blame somebody for the problem then please don't >> blame us. We tried very hard to fit all those stuff into kernel's mod= el >> of devices. You should blame those who did the initial design of >> Loongson's boot interface that failed to introduce a proper way >> to describe the platform. >> >>> >>> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver, >>> pwm driver, clk driver, can you pay more attention to salve those >>> problems, please ? >> Are you trying to make a TODO list for your colleague :-) >> >> We , community developers, don't owe you anything. So please >> don't expect anything from us. I lost access to most Loongson >> devices since I'm currently study abroad, but I'm determined to >> keep platform code in a good shape. That's my duty as a maintainer. >> >> Thanks. >> - Jiaxun > > Providing a few board specific dts doesn't hurt anybody. There are a lot of things that don't hurt anybody but we shouldn't do. The standard of reviewing the code is not "doesn't hurt anybody". It's "= do the right thing". Please reference: https://www.kernel.org/doc/html/latest/process/6.Followthrough.html > > Can we leave the problem(passing correct dts to the kernel) untouched = and > > solve it in the feature with a another patch, ok? Then please drop platform DTS part. I must NAK this part, sorry. Thanks --=20 - Jiaxun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3969DC433FE for ; Wed, 23 Mar 2022 03:14:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9850C10E578; Wed, 23 Mar 2022 03:14:46 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id A409D10E578 for ; Wed, 23 Mar 2022 03:14:44 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id DF5B9580259; Tue, 22 Mar 2022 23:14:43 -0400 (EDT) Received: from imap44 ([10.202.2.94]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 23:14:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=L0SvsihPk0D6/q 9wCsLi7ZzaZZ1wSYEuefF72MQXOXg=; b=PzEyKpMYj6Pf1xaYL4WZi9/YHBolcN DmW6NTOixVYflJ6WoBxgBksMGQxi56btWsGQ+DPWW0PlmsTb8FEkFUokuV1dv7zb 9qBApPrPkm0HpvWcBV4oBC6iLiZQqXn9ktNs1yZ6Efd4CgO1g3ndFxYDktUhBk6a c2IcQjO56Fb50VE04t1lwjxWYhN9N5rAFZuSTy/FlhBShf/AWuU//7QL5jj0p/so mLiA+6bbNL9y1BBfuc0nQ469oBZ0L6pho4kOmUugSR3H3PJZMHbs2aSd4lC7u4PB BpVnSpvK7PVt2R842XlVYePAkVEcwGei3WGG0MYnKNtyYKZlX50+Cw2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=L0SvsihPk0D6/q9wCsLi7ZzaZZ1wSYEuefF72MQXO Xg=; b=QJczCdVtsEOknGpSj6yCcMEeWP/9teRXgWQsyKc1JoI2hlSP5FprJ+6AZ wa2za9+Has9VuNsOfSAXfpLSmtDA+GKGMylVhjszUeOjrfXmHyErH9BK4i4cZdH+ SMpGvEYGpgSY7UUibE5Aj5eZP7LQ2niJbC7i/OpDxKmihAmN9SqWkoz2tw4NUgpT tHYDIk2lyUK+lD3qFtUO0tuRZmyk3L0KR3neZeHbi2WoFSlBbmFwrKiTV3Uz/dUU 8srcxAwMIQwS7hIgbfstcgWJu4ye5iQbT15VdeX7OOHiQfAITNqvy5r8vXpt7ZIV gffBnpeh3kpAlq/sIq7VoAgDGc2HA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegiedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedflfhi rgiguhhnucgjrghnghdfuceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh eqnecuggftrfgrthhtvghrnheptedtjedvvddthffgheeujedttddtgfektdeghfeltdek leefhffhleelvdejkeffnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigr nhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8646DFA0AA7; Tue, 22 Mar 2022 23:14:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4907-g25ce6f34a9-fm-20220311.001-g25ce6f34 Mime-Version: 1.0 Message-Id: <8d474c46-c354-4dec-920d-dbbc67377690@www.fastmail.com> In-Reply-To: References: <20220321162916.1116541-1-15330273260@189.cn> <20220321162916.1116541-3-15330273260@189.cn> <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com> <2c671752-6684-f87b-7b2d-90568d36adde@189.cn> <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> Date: Wed, 23 Mar 2022 03:14:23 +0000 From: "Jiaxun Yang" To: "Sui Jingfeng" <15330273260@189.cn>, "Maxime Ripard" , "Thomas Zimmermann" , "Roland Scheidegger" , "Zack Rusin" , "Christian Gmeiner" , "David Airlie" , "Daniel Vetter" , "Rob Herring" , "Thomas Bogendoerfer" , "Dan Carpenter" , "Krzysztof Kozlowski" , "Andrey Zhizhikin" , "Sam Ravnborg" , "David S . Miller" , "Lucas Stach" , "Maarten Lankhorst" , "Ilia Mirkin" , "Qing Zhang" , suijingfeng Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, liyi@loongson.cn, Huacai Chen , "linux-mips@vger.kernel.org" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tiezhu Yang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" =E5=9C=A82022=E5=B9=B43=E6=9C=8823=E6=97=A5=E4=B8=89=E6=9C=88 =E4=B8=8A=E5= =8D=883:07=EF=BC=8CSui Jingfeng=E5=86=99=E9=81=93=EF=BC=9A > On 2022/3/23 10:29, Jiaxun Yang wrote: >> >> >> =E5=9C=A8 2022/3/23 1:53, Sui Jingfeng =E5=86=99=E9=81=93: >>> Hi, Jiaxun >>> >>> Build all dts into vmlinuz will make the vmlinuz bigger and bigger. >>> How does the kernel get the dtb is another big issue, either from=20 >>> built-in >>> dtb or pass from the firmware(pmon and uefi etc). This should be >>> solved with another patch carefully. Providing board specific dts >>> helps to code review, it helps reviewers understand that there are >>> variant boards and have to be express with different OF graph. >> Hi, >> >> I insist my taste on those code. If the only intention is to demonstr= ate >> the usage of the driver then please just leave them in dt document >> or commit message. >> >>> >>> Now, there are about 6 dts under arch/mips/boot/dts/loongson/, >>> Suppose loongson have 1000+ different board, do you want built all >>> of them into vmlinuz? >> Note that we are supporting all those boards on "platform" bias. Which >> means if they share similar design then they will use the same DTS. >> If we have a new design then unfortunately our kernel binary must gro= w. >> >> For those who intended to build a size-optimized kernel they will be >> able to disable unused DTS in Kconfig. >> >> If you want to blame somebody for the problem then please don't >> blame us. We tried very hard to fit all those stuff into kernel's mod= el >> of devices. You should blame those who did the initial design of >> Loongson's boot interface that failed to introduce a proper way >> to describe the platform. >> >>> >>> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver, >>> pwm driver, clk driver, can you pay more attention to salve those >>> problems, please ? >> Are you trying to make a TODO list for your colleague :-) >> >> We , community developers, don't owe you anything. So please >> don't expect anything from us. I lost access to most Loongson >> devices since I'm currently study abroad, but I'm determined to >> keep platform code in a good shape. That's my duty as a maintainer. >> >> Thanks. >> - Jiaxun > > Providing a few board specific dts doesn't hurt anybody. There are a lot of things that don't hurt anybody but we shouldn't do. The standard of reviewing the code is not "doesn't hurt anybody". It's "= do the right thing". Please reference: https://www.kernel.org/doc/html/latest/process/6.Followthrough.html > > Can we leave the problem(passing correct dts to the kernel) untouched = and > > solve it in the feature with a another patch, ok? Then please drop platform DTS part. I must NAK this part, sorry. Thanks --=20 - Jiaxun