Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

From: Kamil Rytarowski <n54@gmx.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Drop AIX host support
Date: Mon, 4 Sep 2017 22:50:16 +0200	[thread overview]
Message-ID: <8d4a3664-0684-cf6e-0cdd-ad699674eebf@gmx.com> (raw)
In-Reply-To: <1504545540-8002-1-git-send-email-peter.maydell@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 3012 bytes --]

On 04.09.2017 19:19, Peter Maydell wrote:
> Nobody has mentioned AIX host support on the mailing list for years,
> and we have no test systems for it so it is most likely broken.
> We've advertised in configure for two releases now that we plan
> to drop support for this host OS, and have had no complaints.
> Drop the AIX host support code.
> 

There is AIX support in pkgsrc, but the activity is minimal. It
certainly does not pass perl and the amount of buildable packages is tiny.

> We can also drop the now-unused AIX version of sys_cache_info().
> 
> Note that the _CALL_AIX define used in the PPC tcg backend is
> also used for Linux PPC64, and so that code should not be removed.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure        | 13 +------------
>  util/cacheinfo.c | 11 +----------
>  2 files changed, 2 insertions(+), 22 deletions(-)
> 
> diff --git a/configure b/configure
> index fb7e34a..931b3ba 100755
> --- a/configure
> +++ b/configure
> @@ -350,7 +350,6 @@ cocoa="no"
>  softmmu="yes"
>  linux_user="no"
>  bsd_user="no"
> -aix="no"
>  blobs="yes"
>  pkgversion=""
>  pie=""
> @@ -554,8 +553,6 @@ elif check_define __NetBSD__; then
>    targetos='NetBSD'
>  elif check_define __APPLE__; then
>    targetos='Darwin'
> -elif check_define _AIX; then
> -  targetos='AIX'
>  else
>    # This is a fatal error, but don't report it yet, because we
>    # might be going to just print the --help text, or it might
> @@ -767,10 +764,6 @@ SunOS)
>    LIBS="$solarisnetlibs $LIBS"
>    libs_qga="$solarisnetlibs $libs_qga"
>  ;;
> -AIX)
> -  aix="yes"
> -  make="${MAKE-gmake}"
> -;;
>  Haiku)
>    haiku="yes"
>    QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS $QEMU_CFLAGS"
> @@ -4214,7 +4207,7 @@ elif compile_prog "" "$pthread_lib -lrt" ; then
>  fi
>  
>  if test "$darwin" != "yes" -a "$mingw32" != "yes" -a "$solaris" != yes -a \
> -        "$aix" != "yes" -a "$haiku" != "yes" ; then
> +        "$haiku" != "yes" ; then
>      libs_softmmu="-lutil $libs_softmmu"
>  fi
>  
> @@ -5523,10 +5516,6 @@ if test "$darwin" = "yes" ; then
>    echo "CONFIG_DARWIN=y" >> $config_host_mak
>  fi
>  
> -if test "$aix" = "yes" ; then
> -  echo "CONFIG_AIX=y" >> $config_host_mak
> -fi
> -
>  if test "$solaris" = "yes" ; then
>    echo "CONFIG_SOLARIS=y" >> $config_host_mak
>  fi
> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
> index 593940f..db5172d 100644
> --- a/util/cacheinfo.c
> +++ b/util/cacheinfo.c
> @@ -15,16 +15,7 @@ int qemu_dcache_linesize = 0;
>   * Operating system specific detection mechanisms.
>   */
>  
> -#if defined(_AIX)
> -# include <sys/systemcfg.h>
> -
> -static void sys_cache_info(int *isize, int *dsize)
> -{
> -    *isize = _system_configuration.icache_line;
> -    *dsize = _system_configuration.dcache_line;
> -}
> -
> -#elif defined(_WIN32)
> +#if defined(_WIN32)
>  
>  static void sys_cache_info(int *isize, int *dsize)
>  {
> 

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]