All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kees Cook <keescook@chromium.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Tejun Heo <tj@kernel.org>, Borislav Petkov <bp@alien8.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Manoj N. Kumar" <manoj@linux.vnet.ibm.com>,
	"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>,
	Uma Krishnan <ukrishn@linux.vnet.ibm.com>,
	linux-block <linux-block@vger.kernel.org>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI
Date: Tue, 22 May 2018 13:16:54 -0600	[thread overview]
Message-ID: <8d4af5c4-96fa-54ee-d5c1-b887b1de5a3c@kernel.dk> (raw)
In-Reply-To: <20180522191309.GA23615@infradead.org>

On 5/22/18 1:13 PM, Christoph Hellwig wrote:
> On Tue, May 22, 2018 at 01:09:41PM -0600, Jens Axboe wrote:
>> I think Martin and Christoph are objecting to moving the code to
>> block/scsi_ioctl.h. I don't care too much about where the code is, but
>> think it would be nice to have the definitions in a separate header. But
>> if they prefer just pulling in all of SCSI for it, well then I guess
>> it's pointless to move the header bits. Seems very heavy handed to me,
>> though.
> 
> It might be heavy handed for the 3 remaining users of drivers/ide,

Brutal :-)

> but as long as that stuff just keeps working I'd rather worry about
> everyone else, and keep the scsi code where it belongs.

Fine with me then, hopefully we can some day kill it off.

-- 
Jens Axboe

  reply	other threads:[~2018-05-22 19:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 18:15 [PATCH 0/6] block: Consolidate scsi sense buffer usage Kees Cook
2018-05-22 18:15 ` [PATCH 1/6] ide-cd: Drop unused sense buffers Kees Cook
2018-05-22 18:41   ` Christoph Hellwig
2018-05-22 18:15 ` [PATCH 2/6] scsi: cxlflash: " Kees Cook
2018-05-22 18:41   ` Christoph Hellwig
2018-05-22 21:03   ` Matthew R. Ochs
2018-05-22 18:15 ` [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI Kees Cook
2018-05-22 18:36   ` Christoph Hellwig
2018-05-22 18:50     ` Martin K. Petersen
2018-05-22 18:59       ` Kees Cook
2018-05-22 19:09         ` Jens Axboe
2018-05-22 19:13           ` Christoph Hellwig
2018-05-22 19:16             ` Jens Axboe [this message]
2018-05-22 23:31               ` Kees Cook
2018-05-22 23:34                 ` Randy Dunlap
2018-05-22 23:39                   ` Kees Cook
2018-05-22 23:41                     ` Randy Dunlap
2018-05-22 23:42                 ` Jens Axboe
2018-05-22 23:42                   ` Jens Axboe
2018-05-22 23:49                   ` Kees Cook
2018-05-22 23:49                     ` Kees Cook
2018-05-23 14:13                     ` Jens Axboe
2018-05-23 14:25                       ` Christoph Hellwig
2018-05-23 14:31                         ` Jens Axboe
2018-05-23 20:52                           ` Kees Cook
2018-05-23 21:06                             ` Martin K. Petersen
2018-05-23 21:17                               ` Kees Cook
2018-05-24  7:36                                 ` Christoph Hellwig
2018-05-23 21:14                             ` Jens Axboe
2018-05-23 21:20                               ` Randy Dunlap
2018-05-23 21:22                                 ` Jens Axboe
2018-05-23 21:23                                   ` Randy Dunlap
2018-05-24  8:00                               ` Christoph Hellwig
2018-05-24 17:06                                 ` Kees Cook
2018-05-25 14:48                                   ` Christoph Hellwig
2018-07-08 20:23                                   ` Christoph Hellwig
2018-07-09 15:56                                     ` Kees Cook
2018-07-31  7:53                                       ` Christoph Hellwig
2018-07-31 19:52                                         ` Kees Cook
2018-05-22 18:15 ` [PATCH 4/6] block: Consolidate scsi sense buffer usage Kees Cook
2018-05-22 18:15 ` [PATCH 5/6] libata-scsi: Move sense buffers onto stack Kees Cook
2018-05-22 18:15 ` [PATCH 6/6] scsi: Check sense buffer size at build time Kees Cook
2018-05-23  8:25   ` Sergei Shtylyov
2018-05-23 21:08     ` Kees Cook
2018-05-24 14:11   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d4af5c4-96fa-54ee-d5c1-b887b1de5a3c@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=keescook@chromium.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manoj@linux.vnet.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=mrochs@linux.vnet.ibm.com \
    --cc=tj@kernel.org \
    --cc=ukrishn@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.