From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyAH7-0006YQ-6P for qemu-devel@nongnu.org; Mon, 25 Feb 2019 02:02:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyAH6-0007Xr-26 for qemu-devel@nongnu.org; Mon, 25 Feb 2019 02:02:05 -0500 From: Vladimir Sementsov-Ogievskiy Date: Mon, 25 Feb 2019 07:01:37 +0000 Message-ID: <8d518b5f-81ff-e8b1-c120-bca14fcf29ca@virtuozzo.com> References: <20190223000614.13894-1-jsnow@redhat.com> <20190223000614.13894-3-jsnow@redhat.com> In-Reply-To: <20190223000614.13894-3-jsnow@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <5C503BB992433849900B41F953801F43@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , "qemu-devel@nongnu.org" , "qemu-block@nongnu.org" Cc: Markus Armbruster , Kevin Wolf , Juan Quintela , "eblake@redhat.com" , Max Reitz , "libvir-list@redhat.com" , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Fam Zheng MjMuMDIuMjAxOSAzOjA2LCBKb2huIFNub3cgd3JvdGU6DQo+ICJGcm96ZW4iIHdhcyBhIGdvb2Qg ZGVzY3JpcHRpb24gYSBsb25nIHRpbWUgYWdvLCBidXQgaXQgaXNuJ3QgYWRlcXVhdGUgbm93Lg0K PiBSZW5hbWUgdGhlIGZyb3plbiBwcmVkaWNhdGUgdG8gaGFzX3N1Y2Nlc3NvciB0byBtYWtlIHRo ZSBzZW1hbnRpY3Mgb2YgdGhlDQo+IHByZWRpY2F0ZSBtb3JlIGNsZWFyIHRvIG91dHNpZGUgY2Fs bGVycy4NCj4gDQo+IEluIHRoZSBwcm9jZXNzLCByZW1vdmUgc29tZSBjYWxscyB0byBmcm96ZW4o KSB0aGF0IG5vIGxvbmdlciBzZW1hbnRpY2FsbHkNCj4gbWFrZSBzZW5zZS4gRm9yIGJkcnZfZW5h YmxlX2RpcnR5X2JpdG1hcF9sb2NrZWQgYW5kDQo+IGJkcnZfZGlzYWJsZV9kaXJ0eV9iaXRtYXBf bG9ja2VkLCBpdCBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gcHJvaGliaXQgUUVNVQ0KPiBpbnRlcm5h bHMgZnJvbSBwZXJmb3JtaW5nIHRoaXMgYWN0aW9uIHdoZW4gd2Ugb25seSB3aXNoZWQgdG8gcHJv aGliaXQgUU1QDQo+IHVzZXJzIGZyb20gaXNzdWluZyB0aGVzZSBjb21tYW5kcy4gQWxsIG9mIHRo ZSBRTVAgQVBJIGNvbW1hbmRzIGZvciBiaXRtYXANCj4gbWFuaXB1bGF0aW9uIGFscmVhZHkgY2hl Y2sgYWdhaW5zdCB1c2VyX2xvY2tlZCgpIHRvIHByb2hpYml0IHRoZXNlIGFjdGlvbnMuDQo+IA0K PiBTZXZlcmFsIG90aGVyIGFzc2VydGlvbnMgcmVhbGx5IHdhbnQgdG8gY2hlY2sgdGhhdCB0aGUg Yml0bWFwIGlzbid0IGluLXVzZQ0KPiBieSBhbm90aGVyIG9wZXJhdGlvbiAtLSB1c2UgdGhlIGJp dG1hcF91c2VyX2xvY2tlZCBmdW5jdGlvbiBmb3IgdGhpcyBpbnN0ZWFkLA0KPiB3aGljaCBwcmVz ZW50bHkgYWxzbyBjaGVja3MgZm9yIGhhc19zdWNjZXNzb3IuIFRoaXMgbGVhdmVzIHNvbWUgcmVk dW5kYW50DQo+IGNoZWNrcyBvZiBoYXNfc3VjZXNzb3IgdGhyb3VnaCBkaWZmZXJlbnQgaGVscGVy cyB0aGF0IGFyZSBhZGRyZXNzZWQgaW4NCj4gZm9ydGhjb21pbmcgcGF0Y2hlcy4NCj4gDQo+IFNp Z25lZC1vZmYtYnk6IEpvaG4gU25vdyA8anNub3dAcmVkaGF0LmNvbT4NCj4gLS0tDQo+ICAgYmxv Y2svZGlydHktYml0bWFwLmMgICAgICAgICAgIHwgMzIgKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0NCj4gICBpbmNsdWRlL2Jsb2NrL2RpcnR5LWJpdG1hcC5oICAgfCAgMiArLQ0KPiAg IG1pZ3JhdGlvbi9ibG9jay1kaXJ0eS1iaXRtYXAuYyB8ICAyICstDQo+ICAgMyBmaWxlcyBjaGFu Z2VkLCAxOSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQg YS9ibG9jay9kaXJ0eS1iaXRtYXAuYyBiL2Jsb2NrL2RpcnR5LWJpdG1hcC5jDQo+IGluZGV4IDEw MTM4M2IzYWYuLmFhM2Y4NmJiNzMgMTAwNjQ0DQo+IC0tLSBhL2Jsb2NrL2RpcnR5LWJpdG1hcC5j DQo+ICsrKyBiL2Jsb2NrL2RpcnR5LWJpdG1hcC5jDQoNClsuLl0NCg0KPiBAQCAtMjg1LDcgKzI4 OCw3IEBAIHZvaWQgYmRydl9kaXJ0eV9iaXRtYXBfZW5hYmxlX3N1Y2Nlc3NvcihCZHJ2RGlydHlC aXRtYXAgKmJpdG1hcCkNCj4gICBzdGF0aWMgdm9pZCBiZHJ2X3JlbGVhc2VfZGlydHlfYml0bWFw X2xvY2tlZChCZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCkNCj4gICB7DQo+ICAgICAgIGFzc2VydCgh Yml0bWFwLT5hY3RpdmVfaXRlcmF0b3JzKTsNCj4gLSAgICBhc3NlcnQoIWJkcnZfZGlydHlfYml0 bWFwX2Zyb3plbihiaXRtYXApKTsNCj4gKyAgICBhc3NlcnQoIWJkcnZfZGlydHlfYml0bWFwX3Vz ZXJfbG9ja2VkKGJpdG1hcCkpOw0KDQpobW0uIEknZCBwcmVmZXJlIHRvIGtlZXAgYSBzZXBhcmF0 ZSBhc3NlcnRpb24gZm9yIHN1Y2Nlc3Nvcjogd2UgZG9uJ3QgZnJlZSBpdCBoZXJlLA0Kc28gd2Ug cmVhbGx5IGRlcGVuZCBvbiBhYnNlbmNlIG9mIHRoaXMgb2JqZWN0Lg0KDQo+ICAgICAgIGFzc2Vy dCghYml0bWFwLT5tZXRhKTsNCj4gICAgICAgUUxJU1RfUkVNT1ZFKGJpdG1hcCwgbGlzdCk7DQo+ ICAgICAgIGhiaXRtYXBfZnJlZShiaXRtYXAtPmJpdG1hcCk7DQo+IEBAIC0zMjUsNyArMzI4LDcg QEAgQmRydkRpcnR5Qml0bWFwICpiZHJ2X2RpcnR5X2JpdG1hcF9hYmRpY2F0ZShCbG9ja0RyaXZl clN0YXRlICpicywNCj4gICAvKioNCj4gICAgKiBJbiBjYXNlcyBvZiBmYWlsdXJlIHdoZXJlIHdl IGNhbiBubyBsb25nZXIgc2FmZWx5IGRlbGV0ZSB0aGUgcGFyZW50LA0KPiAgICAqIHdlIG1heSB3 aXNoIHRvIHJlLWpvaW4gdGhlIHBhcmVudCBhbmQgY2hpbGQvc3VjY2Vzc29yLg0KPiAtICogVGhl IG1lcmdlZCBwYXJlbnQgd2lsbCBiZSB1bi1mcm96ZW4sIGJ1dCBub3QgZXhwbGljaXRseSByZS1l bmFibGVkLg0KPiArICogVGhlIG1lcmdlZCBwYXJlbnQgd2lsbCBub3QgYmUgdXNlcl9sb2NrZWQs IG5vciBleHBsaWNpdGx5IHJlLWVuYWJsZWQuDQo+ICAgICogQ2FsbGVkIHdpdGhpbiBiZHJ2X2Rp cnR5X2JpdG1hcF9sb2NrLi51bmxvY2sgYW5kIHdpdGggQlFMIHRha2VuLg0KPiAgICAqLw0KPiAg IEJkcnZEaXJ0eUJpdG1hcCAqYmRydl9yZWNsYWltX2RpcnR5X2JpdG1hcF9sb2NrZWQoQmxvY2tE cml2ZXJTdGF0ZSAqYnMsDQo+IEBAIC0zNzMsNyArMzc2LDcgQEAgdm9pZCBiZHJ2X2RpcnR5X2Jp dG1hcF90cnVuY2F0ZShCbG9ja0RyaXZlclN0YXRlICpicywgaW50NjRfdCBieXRlcykNCj4gICAN Cj4gICAgICAgYmRydl9kaXJ0eV9iaXRtYXBzX2xvY2soYnMpOw0KPiAgICAgICBRTElTVF9GT1JF QUNIKGJpdG1hcCwgJmJzLT5kaXJ0eV9iaXRtYXBzLCBsaXN0KSB7DQo+IC0gICAgICAgIGFzc2Vy dCghYmRydl9kaXJ0eV9iaXRtYXBfZnJvemVuKGJpdG1hcCkpOw0KPiArICAgICAgICBhc3NlcnQo IWJkcnZfZGlydHlfYml0bWFwX3VzZXJfbG9ja2VkKGJpdG1hcCkpOw0KDQphbmQgaGVyZSB0b28u IEFzIHdlIGRvbid0IHRydW5jYXRlIHN1Y2Nlc3NvcnMuDQoNCj4gICAgICAgICAgIGFzc2VydCgh Yml0bWFwLT5hY3RpdmVfaXRlcmF0b3JzKTsNCj4gICAgICAgICAgIGhiaXRtYXBfdHJ1bmNhdGUo Yml0bWFwLT5iaXRtYXAsIGJ5dGVzKTsNCj4gICAgICAgICAgIGJpdG1hcC0+c2l6ZSA9IGJ5dGVz Ow0KPiBAQCAtMzkxLDcgKzM5NCw3IEBAIHZvaWQgYmRydl9yZWxlYXNlX2RpcnR5X2JpdG1hcChC bG9ja0RyaXZlclN0YXRlICpicywgQmRydkRpcnR5Qml0bWFwICpiaXRtYXApDQo+ICAgDQo+ICAg LyoqDQo+ICAgICogUmVsZWFzZSBhbGwgbmFtZWQgZGlydHkgYml0bWFwcyBhdHRhY2hlZCB0byBh IEJEUyAoZm9yIHVzZSBpbiBiZHJ2X2Nsb3NlKCkpLg0KPiAtICogVGhlcmUgbXVzdCBub3QgYmUg YW55IGZyb3plbiBiaXRtYXBzIGF0dGFjaGVkLg0KPiArICogVGhlcmUgbXVzdCBub3QgYmUgYW55 IHVzZXJfbG9ja2VkIGJpdG1hcHMgYXR0YWNoZWQuDQo+ICAgICogVGhpcyBmdW5jdGlvbiBkb2Vz IG5vdCByZW1vdmUgcGVyc2lzdGVudCBiaXRtYXBzIGZyb20gdGhlIHN0b3JhZ2UuDQo+ICAgICog Q2FsbGVkIHdpdGggQlFMIHRha2VuLg0KPiAgICAqLw0KPiBAQCAtNDI4LDcgKzQzMSw2IEBAIHZv aWQgYmRydl9yZW1vdmVfcGVyc2lzdGVudF9kaXJ0eV9iaXRtYXAoQmxvY2tEcml2ZXJTdGF0ZSAq YnMsDQo+ICAgdm9pZCBiZHJ2X2Rpc2FibGVfZGlydHlfYml0bWFwKEJkcnZEaXJ0eUJpdG1hcCAq Yml0bWFwKQ0KPiAgIHsNCj4gICAgICAgYmRydl9kaXJ0eV9iaXRtYXBfbG9jayhiaXRtYXApOw0K PiAtICAgIGFzc2VydCghYmRydl9kaXJ0eV9iaXRtYXBfZnJvemVuKGJpdG1hcCkpOw0KPiAgICAg ICBiaXRtYXAtPmRpc2FibGVkID0gdHJ1ZTsNCj4gICAgICAgYmRydl9kaXJ0eV9iaXRtYXBfdW5s b2NrKGJpdG1hcCk7DQo+ICAgfQ0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ibG9jay9kaXJ0eS1i aXRtYXAuaCBiL2luY2x1ZGUvYmxvY2svZGlydHktYml0bWFwLmgNCj4gaW5kZXggMDRhMTE3ZmM4 MS4uY2RiYjRkZmVmZCAxMDA2NDQNCj4gLS0tIGEvaW5jbHVkZS9ibG9jay9kaXJ0eS1iaXRtYXAu aA0KPiArKysgYi9pbmNsdWRlL2Jsb2NrL2RpcnR5LWJpdG1hcC5oDQoNCkNvdWxkIHlvdSBwbGVh c2UgYWRkIHNjcmlwdHMvZ2l0Lm9yZGVyZmlsZSB0byB5b3VyIC5naXQvY29uZmlnLCBsaWtlDQoN CltkaWZmXQ0KICAgICBvcmRlckZpbGUgPSAvcGF0aC90by9zY3JpcHRzL2dpdC5vcmRlcmZpbGUN Cg0KPw0KDQo+IEBAIC0zNiw3ICszNiw3IEBAIEJsb2NrRGlydHlJbmZvTGlzdCAqYmRydl9xdWVy eV9kaXJ0eV9iaXRtYXBzKEJsb2NrRHJpdmVyU3RhdGUgKmJzKTsNCj4gICB1aW50MzJfdCBiZHJ2 X2dldF9kZWZhdWx0X2JpdG1hcF9ncmFudWxhcml0eShCbG9ja0RyaXZlclN0YXRlICpicyk7DQo+ ICAgdWludDMyX3QgYmRydl9kaXJ0eV9iaXRtYXBfZ3JhbnVsYXJpdHkoY29uc3QgQmRydkRpcnR5 Qml0bWFwICpiaXRtYXApOw0KPiAgIGJvb2wgYmRydl9kaXJ0eV9iaXRtYXBfZW5hYmxlZChCZHJ2 RGlydHlCaXRtYXAgKmJpdG1hcCk7DQo+IC1ib29sIGJkcnZfZGlydHlfYml0bWFwX2Zyb3plbihC ZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCk7DQo+ICtib29sIGJkcnZfZGlydHlfYml0bWFwX2hhc19z dWNjZXNzb3IoQmRydkRpcnR5Qml0bWFwICpiaXRtYXApOw0KPiAgIGNvbnN0IGNoYXIgKmJkcnZf ZGlydHlfYml0bWFwX25hbWUoY29uc3QgQmRydkRpcnR5Qml0bWFwICpiaXRtYXApOw0KPiAgIGlu dDY0X3QgYmRydl9kaXJ0eV9iaXRtYXBfc2l6ZShjb25zdCBCZHJ2RGlydHlCaXRtYXAgKmJpdG1h cCk7DQo+ICAgRGlydHlCaXRtYXBTdGF0dXMgYmRydl9kaXJ0eV9iaXRtYXBfc3RhdHVzKEJkcnZE aXJ0eUJpdG1hcCAqYml0bWFwKTsNCj4gZGlmZiAtLWdpdCBhL21pZ3JhdGlvbi9ibG9jay1kaXJ0 eS1iaXRtYXAuYyBiL21pZ3JhdGlvbi9ibG9jay1kaXJ0eS1iaXRtYXAuYw0KPiBpbmRleCA2NDI2 MTUxZTRmLi5hYzY5NTQxNDJmIDEwMDY0NA0KPiAtLS0gYS9taWdyYXRpb24vYmxvY2stZGlydHkt Yml0bWFwLmMNCj4gKysrIGIvbWlncmF0aW9uL2Jsb2NrLWRpcnR5LWJpdG1hcC5jDQo+IEBAIC01 NDIsNyArNTQyLDcgQEAgc3RhdGljIHZvaWQgZGlydHlfYml0bWFwX2xvYWRfY29tcGxldGUoUUVN VUZpbGUgKmYsIERpcnR5Qml0bWFwTG9hZFN0YXRlICpzKQ0KPiAgICAgICAgICAgfQ0KPiAgICAg ICB9DQo+ICAgDQo+IC0gICAgaWYgKGJkcnZfZGlydHlfYml0bWFwX2Zyb3plbihzLT5iaXRtYXAp KSB7DQo+ICsgICAgaWYgKGJkcnZfZGlydHlfYml0bWFwX2hhc19zdWNjZXNzb3Iocy0+Yml0bWFw KSkgew0KPiAgICAgICAgICAgYmRydl9kaXJ0eV9iaXRtYXBfbG9jayhzLT5iaXRtYXApOw0KPiAg ICAgICAgICAgaWYgKGVuYWJsZWRfYml0bWFwcyA9PSBOVUxMKSB7DQo+ICAgICAgICAgICAgICAg LyogaW4gcG9zdGNvcHkgKi8NCj4gDQoNCg0KV2l0aCBteSBzdWdnZXN0aW9ucyBvciB3aXRob3V0 Og0KUmV2aWV3ZWQtYnk6IFZsYWRpbWlyIFNlbWVudHNvdi1PZ2lldnNraXkgPHZzZW1lbnRzb3ZA dmlydHVvenpvLmNvbT4NCg0KQW5kIHRoYW5rIHlvdSBmb3IgcmV3cml0aW5nIGNvbW1pdCBtZXNz YWdlLCBpdCdzIG1vcmUgY2xlYXIgbm93IQ0KDQotLSANCkJlc3QgcmVnYXJkcywNClZsYWRpbWly DQo=