From: Usama Arif <usama.arif@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] board: armltd: Add support for Total Compute platform
Date: Wed, 12 Aug 2020 16:11:07 +0100 [thread overview]
Message-ID: <8d55c625-5ba7-6a48-3799-8446a5e21b2e@arm.com> (raw)
In-Reply-To: <20200812145305.GK20605@bill-the-cat>
On 12/08/2020 15:53, Tom Rini wrote:
> On Wed, Aug 12, 2020 at 03:08:14PM +0100, Usama Arif wrote:
>> Total Compute is based on ARM architecture and has
>> the following features enabled in u-boot:
>> - PL011 UART
>> - PL180 MMC
>> - NOR Flash
>> - FIT image with Signature
>> - AVB
>>
>> Signed-off-by: Usama Arif <usama.arif@arm.com>
>> ---
>> Changes for v2:
>> - Added arch/arm/dts/total_compute.dts to board/armltd/total_compute/MAINTAINERS
>> - Added bootm_size of 512 MB for total compute board.
> [snip]
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> + "bootm_size=0x20000000\0" \
>> + "load_addr=0xa0000000\0" \
>> + "kernel_addr_r=0x80080000\0" \
>> + "initrd_addr_r=0x88000000\0" \
>> + "fdt_addr_r=0x83000000\0" \
>> + "fdt_high=0xffffffffffffffff\0" \
>> + "initrd_high=0xffffffffffffffff\0"
>
> You need to drop fdt_high/initrd_high too as that's disabling relocation
> and that is almost never the right choice. Thanks!
>
Removed fdt_high and initrd_high in v3 to allow relocation. Thanks again
for the review.
Usama
prev parent reply other threads:[~2020-08-12 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:08 [PATCH v2] board: armltd: Add support for Total Compute platform Usama Arif
2020-08-12 14:53 ` Tom Rini
2020-08-12 15:11 ` Usama Arif [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d55c625-5ba7-6a48-3799-8446a5e21b2e@arm.com \
--to=usama.arif@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.