From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from osg.samsung.com ([64.30.133.232]:64169 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbeEDUtr (ORCPT ); Fri, 4 May 2018 16:49:47 -0400 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Randy Dunlap , tomi.valkeinen@ti.com, linux-omap@vger.kernel.org Subject: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Date: Fri, 4 May 2018 16:49:32 -0400 Message-Id: <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> In-Reply-To: <201805050150.CmagcMOg%fengguang.wu@intel.com> References: <201805050150.CmagcMOg%fengguang.wu@intel.com> To: unlisted-recipients:; (no To-header on input)@bombadil.infradead.org Sender: linux-media-owner@vger.kernel.org List-ID: Just checking for ifdefs cause build issues as reported by kernel test: config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration] mgr = omapdss_find_mgr_from_display(def_dssdev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration] def_name = omapdss_get_default_display_name(); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] def_name = omapdss_get_default_display_name(); ^ So, use IS_ENABLED() instead. Cc: Bartlomiej Zolnierkiewicz Cc: Randy Dunlap Cc: tomi.valkeinen@ti.com Cc: linux-omap@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP") Signed-off-by: Mauro Carvalho Chehab --- include/video/omapfb_dss.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h index e9775144ff3b..12755d8d9b4f 100644 --- a/include/video/omapfb_dss.h +++ b/include/video/omapfb_dss.h @@ -778,7 +778,7 @@ struct omap_dss_driver { typedef void (*omap_dispc_isr_t) (void *arg, u32 mask); -#ifdef CONFIG_FB_OMAP2 +#if IS_ENABLED(CONFIG_FB_OMAP2) enum omapdss_version omapdss_get_version(void); bool omapdss_is_initialized(void); -- 2.17.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Fri, 04 May 2018 20:49:32 +0000 Subject: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Message-Id: <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> List-Id: References: <201805050150.CmagcMOg%fengguang.wu@intel.com> In-Reply-To: <201805050150.CmagcMOg%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Randy Dunlap , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , tomi.valkeinen@ti.com, Mauro Carvalho Chehab , linux-omap@vger.kernel.org, Linux Media Mailing List Just checking for ifdefs cause build issues as reported by kernel test: config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration] mgr = omapdss_find_mgr_from_display(def_dssdev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration] def_name = omapdss_get_default_display_name(); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] def_name = omapdss_get_default_display_name(); ^ So, use IS_ENABLED() instead. Cc: Bartlomiej Zolnierkiewicz Cc: Randy Dunlap Cc: tomi.valkeinen@ti.com Cc: linux-omap@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP") Signed-off-by: Mauro Carvalho Chehab --- include/video/omapfb_dss.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h index e9775144ff3b..12755d8d9b4f 100644 --- a/include/video/omapfb_dss.h +++ b/include/video/omapfb_dss.h @@ -778,7 +778,7 @@ struct omap_dss_driver { typedef void (*omap_dispc_isr_t) (void *arg, u32 mask); -#ifdef CONFIG_FB_OMAP2 +#if IS_ENABLED(CONFIG_FB_OMAP2) enum omapdss_version omapdss_get_version(void); bool omapdss_is_initialized(void); -- 2.17.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Date: Fri, 4 May 2018 16:49:32 -0400 Message-ID: <8d55f45b6aa36f5c758d191825f14cd31723b371.1525466956.git.mchehab+samsung@kernel.org> References: <201805050150.CmagcMOg%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201805050150.CmagcMOg%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Randy Dunlap , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , tomi.valkeinen@ti.com, Mauro Carvalho Chehab , linux-omap@vger.kernel.org, Linux Media Mailing List List-Id: linux-omap@vger.kernel.org SnVzdCBjaGVja2luZyBmb3IgaWZkZWZzIGNhdXNlIGJ1aWxkIGlzc3VlcyBhcyByZXBvcnRlZCBi eQprZXJuZWwgdGVzdDoKCmNvbmZpZzogb3BlbnJpc2MtYWxsbW9kY29uZmlnIChhdHRhY2hlZCBh cyAuY29uZmlnKQpjb21waWxlcjogb3Ixay1saW51eC1nY2MgKEdDQykgNi4wLjAgMjAxNjAzMjcg KGV4cGVyaW1lbnRhbCkKCkFsbCBlcnJvcnMgKG5ldyBvbmVzIHByZWZpeGVkIGJ5ID4+KToKCiAg IGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL29tYXBmYi1tYWluLmM6IEluIGZ1bmN0 aW9uICdvbWFwZmJfaW5pdF9jb25uZWN0aW9ucyc6Cj4+IGRyaXZlcnMvdmlkZW8vZmJkZXYvb21h cDIvb21hcGZiL29tYXBmYi1tYWluLmM6MjM5Njo4OiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRp b24gb2YgZnVuY3Rpb24gJ29tYXBkc3NfZmluZF9tZ3JfZnJvbV9kaXNwbGF5JyBbLVdlcnJvcj1p bXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KICAgICBtZ3IgPSBvbWFwZHNzX2ZpbmRfbWdy X2Zyb21fZGlzcGxheShkZWZfZHNzZGV2KTsKICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fgogICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9vbWFwZmItbWFp bi5jOjIzOTY6Njogd2FybmluZzogYXNzaWdubWVudCBtYWtlcyBwb2ludGVyIGZyb20gaW50ZWdl ciB3aXRob3V0IGEgY2FzdCBbLVdpbnQtY29udmVyc2lvbl0KICAgICBtZ3IgPSBvbWFwZHNzX2Zp bmRfbWdyX2Zyb21fZGlzcGxheShkZWZfZHNzZGV2KTsKICAgICAgICAgXgogICBkcml2ZXJzL3Zp ZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9vbWFwZmItbWFpbi5jOiBJbiBmdW5jdGlvbiAnb21hcGZi X2ZpbmRfZGVmYXVsdF9kaXNwbGF5JzoKPj4gZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFw ZmIvb21hcGZiLW1haW4uYzoyNDMwOjEzOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2Yg ZnVuY3Rpb24gJ29tYXBkc3NfZ2V0X2RlZmF1bHRfZGlzcGxheV9uYW1lJyBbLVdlcnJvcj1pbXBs aWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KICAgICBkZWZfbmFtZSA9IG9tYXBkc3NfZ2V0X2Rl ZmF1bHRfZGlzcGxheV9uYW1lKCk7CiAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fgogICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9vbWFwZmIt bWFpbi5jOjI0MzA6MTE6IHdhcm5pbmc6IGFzc2lnbm1lbnQgbWFrZXMgcG9pbnRlciBmcm9tIGlu dGVnZXIgd2l0aG91dCBhIGNhc3QgWy1XaW50LWNvbnZlcnNpb25dCiAgICAgZGVmX25hbWUgPSBv bWFwZHNzX2dldF9kZWZhdWx0X2Rpc3BsYXlfbmFtZSgpOwogICAgICAgICAgICAgIF4KClNvLCB1 c2UgSVNfRU5BQkxFRCgpIGluc3RlYWQuCgpDYzogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8 Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgpDYzogUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJh ZGVhZC5vcmc+CkNjOiB0b21pLnZhbGtlaW5lbkB0aS5jb20KQ2M6IGxpbnV4LW9tYXBAdmdlci5r ZXJuZWwub3JnCkNjOiBsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcKRml4ZXM6IDc3MWY3YmU4 N2ZmOSAoIm1lZGlhOiBvbWFwZmI6IG9tYXBmYl9kc3MuaDogYWRkIHN0dWJzIHRvIGJ1aWxkIHdp dGggQ09NUElMRV9URVNUICYmIERSTV9PTUFQIikKU2lnbmVkLW9mZi1ieTogTWF1cm8gQ2FydmFs aG8gQ2hlaGFiIDxtY2hlaGFiK3NhbXN1bmdAa2VybmVsLm9yZz4KLS0tCiBpbmNsdWRlL3ZpZGVv L29tYXBmYl9kc3MuaCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2luY2x1ZGUvdmlkZW8vb21hcGZiX2Rzcy5oIGIvaW5j bHVkZS92aWRlby9vbWFwZmJfZHNzLmgKaW5kZXggZTk3NzUxNDRmZjNiLi4xMjc1NWQ4ZDliNGYg MTAwNjQ0Ci0tLSBhL2luY2x1ZGUvdmlkZW8vb21hcGZiX2Rzcy5oCisrKyBiL2luY2x1ZGUvdmlk ZW8vb21hcGZiX2Rzcy5oCkBAIC03NzgsNyArNzc4LDcgQEAgc3RydWN0IG9tYXBfZHNzX2RyaXZl ciB7CiAKIHR5cGVkZWYgdm9pZCAoKm9tYXBfZGlzcGNfaXNyX3QpICh2b2lkICphcmcsIHUzMiBt YXNrKTsKIAotI2lmZGVmIENPTkZJR19GQl9PTUFQMgorI2lmIElTX0VOQUJMRUQoQ09ORklHX0ZC X09NQVAyKQogCiBlbnVtIG9tYXBkc3NfdmVyc2lvbiBvbWFwZHNzX2dldF92ZXJzaW9uKHZvaWQp OwogYm9vbCBvbWFwZHNzX2lzX2luaXRpYWxpemVkKHZvaWQpOwotLSAKMi4xNy4wCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK