All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] board/qemu/post-image.sh: start from a shell
Date: Mon, 27 Apr 2020 09:23:59 -0700	[thread overview]
Message-ID: <8d5c237d-4790-83c3-ccc6-d01184d93a3f@infradead.org> (raw)
In-Reply-To: <d499ec8a-9e8f-b900-04d2-654df9f8f9fb@gmail.com>

On 4/27/20 9:09 AM, Romain Naour wrote:
>>  	export PATH="${HOST_DIR}/bin:\${PATH}"
>> -	exec ${QEMU_CMD_LINE} \${EXTRA_ARGS}
>> +	exec sh -c "${QEMU_CMD_LINE} \${EXTRA_ARGS}"
> 
> This patch is not ok as is since we need to escape double quotes from
> "${QEMU_CMD_LINE}
> 
> example:
> -append \"rootwait root=/dev/sda console=ttySC1,115200 noiotrap\"

Maybe use something like:

  CMD="${QEMU_CMD_LINE} ${EXTRA_ARGS}"
  eval exec ${CMD}

-Geoff

  reply	other threads:[~2020-04-27 16:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 22:33 [Buildroot] [PATCH 1/6] package/python-pycryptodomex: add host variant Romain Naour
2020-04-26 22:33 ` [Buildroot] [PATCH 2/6] package/crda: replace pycrypto by pycryptodomex Romain Naour
2020-05-31 20:39   ` Peter Korsgaard
2020-04-26 22:33 ` [Buildroot] [PATCH 3/6] boot/optee-os: " Romain Naour
2020-04-26 22:33 ` [Buildroot] [PATCH 4/6] package/python-pycrypto: remove package Romain Naour
2020-05-31 20:40   ` Peter Korsgaard
2020-04-26 22:33 ` [Buildroot] [PATCH 5/6] board/qemu/post-image.sh: start from a shell Romain Naour
2020-04-27 16:09   ` Romain Naour
2020-04-27 16:23     ` Geoff Levand [this message]
2020-04-26 22:33 ` [Buildroot] [PATCH 6/6] configs/qemu_arm_vexpress_tz_defconfig: build start-qemu.sh Romain Naour
2020-05-31 20:39 ` [Buildroot] [PATCH 1/6] package/python-pycryptodomex: add host variant Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d5c237d-4790-83c3-ccc6-d01184d93a3f@infradead.org \
    --to=geoff@infradead.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.