From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DE1C433ED for ; Thu, 6 May 2021 08:30:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01B0F610EA for ; Thu, 6 May 2021 08:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233408AbhEFIbT (ORCPT ); Thu, 6 May 2021 04:31:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58693 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231880AbhEFIbQ (ORCPT ); Thu, 6 May 2021 04:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620289818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JRKbW/sCgPPWfrkPLI5ab6dF91rPfojdvFAM5kCKO64=; b=XkdO0nBNj7p2TDp0Wv5rgx8a9K1hteiFMOqqKS9NOFIj08D/wxG/pqSrB3wb2i63ZmegrS ShpT6S8nUjXB25YvWWE8Wf+Zao6rd/aeN70NqtYWAgclif14yH7R94m64RrhOuyedCmwWo xgHKD8yLA2BB+joOEXniWfUkIHzit/c= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-rCunSlY1MgCsZj4jJ8anqQ-1; Thu, 06 May 2021 04:30:14 -0400 X-MC-Unique: rCunSlY1MgCsZj4jJ8anqQ-1 Received: by mail-ed1-f69.google.com with SMTP id g17-20020aa7dd910000b029038843570b67so2246533edv.9 for ; Thu, 06 May 2021 01:30:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JRKbW/sCgPPWfrkPLI5ab6dF91rPfojdvFAM5kCKO64=; b=brbDsEGmEgno5dc5Dq3NweZTrq3KH1m14CD2xAOOEy7Mm7FMLENFd+MZa72I08YvmZ 3oSQpFuxHc+GcyjTKLwuGdeqUvXMqdylAeFCsiiWqjbMsJnOOXz214sBhlMQJY1AqLha L8h0nhNF8BcK7uiBkC6QejNNMgECvL7gi3dIP0/21IjY9fM6laMJKAw3/qk8WDWurh1u 2ifqWSHTNbQfCR09uYM7NlFGq5z+6cMnMBfDvko6T/ShNvj270eI769PQCufmKioUoWU QVnwoFtYWHig7fBe/SFQTK1p/mNnP/oFUddAtcU7Xom+s7yciblkBNMXjlyjFZDo5/ZK lPDQ== X-Gm-Message-State: AOAM531AGAzeGbzSr0Tr/Hij0sTiioPqmD0fxxDX/nvy+0xdTxvIQBV6 whPXK4D5zFk6aJq9fPeKhyhTHe8qU1MNJBZAMzi5R+aM+wf9f5vAxIdPLqZ38AM9FOy2OFRwllP TrfiH9/1kGhL1J7GEdHjA3IXT X-Received: by 2002:a17:907:7216:: with SMTP id dr22mr3131470ejc.185.1620289812993; Thu, 06 May 2021 01:30:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaTJLRRAe4z6xxP1wNQ3FfUihWzvJu3i6TGt4G0aTcNF32m7/5tO+Y7AeF4ilAxH6schuy5g== X-Received: by 2002:a17:907:7216:: with SMTP id dr22mr3131456ejc.185.1620289812828; Thu, 06 May 2021 01:30:12 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id um2sm939292ejb.4.2021.05.06.01.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 01:30:12 -0700 (PDT) Subject: Re: [PATCH] iio:accel:stk8312: Remove ACPI support To: Guenter Roeck , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Andy Shevchenko References: <20210506035659.765109-1-linux@roeck-us.net> From: Hans de Goede Message-ID: <8d6a5c4e-f81a-51c2-cd7f-4a9e9895c8c1@redhat.com> Date: Thu, 6 May 2021 10:30:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210506035659.765109-1-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/6/21 5:56 AM, Guenter Roeck wrote: > With CONFIG_ACPI=n, W=1 and -Werror, 0-day reports: > > drivers/iio/accel/stk8312.c:644:36: error: > 'stk8312_acpi_id' defined but not used > > Apparently STK8312 is not a valid ACPI ID. Remove it and with it > ACPI support from the stk8312 driver. > > Reported-by: kernel test robot > Cc: Andy Shevchenko > Cc: Hans de Goede > Signed-off-by: Guenter Roeck Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > There is another patch pending which makes whitespace changes in struct > acpi_device_id stk8312_acpi_id. This will result in a conflict if this > patch is applied. In that patch, it is claimed that the driver would > possibly only be used based on its ACPI ID (even though that ACPI device > ID is not official). > Link: https://patchwork.kernel.org/project/linux-iio/patch/20210401144226.225928-1-jic23@kernel.org/ > I can not determine if that claim has any truth in it. Still, it appears > that the device ID is not an official device ID. > > drivers/iio/accel/stk8312.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c > index 157d8faefb9e..2fc30cfe1457 100644 > --- a/drivers/iio/accel/stk8312.c > +++ b/drivers/iio/accel/stk8312.c > @@ -7,7 +7,6 @@ > * IIO driver for STK8312; 7-bit I2C address: 0x3D. > */ > > -#include > #include > #include > #include > @@ -640,18 +639,10 @@ static const struct i2c_device_id stk8312_i2c_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id); > > -static const struct acpi_device_id stk8312_acpi_id[] = { > - {"STK8312", 0}, > - {} > -}; > - > -MODULE_DEVICE_TABLE(acpi, stk8312_acpi_id); > - > static struct i2c_driver stk8312_driver = { > .driver = { > .name = STK8312_DRIVER_NAME, > .pm = STK8312_PM_OPS, > - .acpi_match_table = ACPI_PTR(stk8312_acpi_id), > }, > .probe = stk8312_probe, > .remove = stk8312_remove, >