From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C04E6C433F5 for ; Wed, 23 Mar 2022 06:46:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CFDE483B1A; Wed, 23 Mar 2022 07:46:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648018014; bh=AeWGdH6qitddRx408yLut3UVysFzLR0evpgst3U8Rtg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IO7fHCHzORd4sDRKXMjJuUA3gdXprRYtGGovQG6nDXc6mT/iroXmLo/D7Ftjpwca1 2OKyX5USvRBrWbuuA5pfm/91UZIyQmgGrqKZzzcnvdFTSl5BlNHGcCraPM7Yj9a89r dGfTiC/iCTMD9PurFYELg6fRK0PstCttK09ZspKzKdnjUyd+M1KBp7Ukgzyc6LM6NF MH23SyYDyHxp60MiuGPrgHc9JmcYqrjDrTlGf42wI1Nk9Ic36W6rtRYWNiKJH6lCJP tNEgGEDuE99JPbI3JwqzoHcbuLhesbL5/Pg97kh/KS6bBIitWuLB9JQVBy8FaDlFWQ pVfjcTGRe4jRQ== Received: by phobos.denx.de (Postfix, from userid 109) id 8AD5783B1A; Wed, 23 Mar 2022 07:46:51 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4308883954 for ; Wed, 23 Mar 2022 07:46:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4KNf6016T0z9sQv; Wed, 23 Mar 2022 07:46:48 +0100 (CET) Message-ID: <8d6e84f8-e7da-b204-814e-ce3d86cbcc02@denx.de> Date: Wed, 23 Mar 2022 07:46:40 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Content-Language: en-US From: Stefan Roese To: =?UTF-8?Q?Marek_Beh=c3=ban?= , Tom Rini Cc: u-boot@lists.denx.de, pali@kernel.org, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20220322161759.24301-1-kabel@kernel.org> <21b4f647-c7ae-60e3-6ec3-a6f5a2ae8ec3@denx.de> In-Reply-To: <21b4f647-c7ae-60e3-6ec3-a6f5a2ae8ec3@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Added Tom to Cc. On 3/23/22 06:55, Stefan Roese wrote: > On 3/22/22 17:17, Marek Behún wrote: >> From: Marek Behún >> >> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from >> upstream Linux kernel") ported Linux's device-tree files for Armada 3720 >> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus >> voltage supply is described as a `phy-supply` property of connector >> node, a mechanism that is not supported in U-Boot yet. >> >> For now, fix this by adding `vbus-supply` to usb3 node. >> >> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from >> upstream Linux kernel") >> Signed-off-by: Marek Behún > > Reviewed-by: Stefan Roese > >> --- >> Dear Stefan, as with the network issue, could we get this to master ASAP? > > Sure. Let me try... Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot": https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results This should not result from this patch though. Could you please pull this patch/fix directly? Thanks, Stefan > Thanks, > Stefan > >> --- >>   arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi >> b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi >> index 2e05b973d2..28a36a6103 100644 >> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi >> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi >> @@ -21,3 +21,7 @@ >>   }; >>   /delete-node/ &mdio; >> + >> +&usb3 { >> +    vbus-supply = <&exp_usb3_vbus>; >> +}; > > Viele Grüße, > Stefan Roese > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de