From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 19 Apr 2018 23:53:58 +0200 Subject: [U-Boot] [PATCH v2 6/8] distro: Extend with RISC-V defines In-Reply-To: References: <20180419154923.70719-1-agraf@suse.de> <20180419154923.70719-7-agraf@suse.de> <0760fe8c-03b9-8a9c-87a5-916d1e07684a@gmx.de> Message-ID: <8d788f7e-dd4b-6336-f187-edd482987927@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On 19.04.18 21:44, Heinrich Schuchardt wrote: > > > On 04/19/2018 07:19 PM, Heinrich Schuchardt wrote: >> >> >> On 04/19/2018 05:49 PM, Alexander Graf wrote: >>> While we don't have VCI or UEFI naming conventions for RISC-V file >>> paths yet, >>> we need to search for something. So let's make up a few defines that >>> at least >>> allow us to get started until the specs officially include RISC-V. >>> >>> Signed-off-by: Alexander Graf >>> >>> --- >>> >>> v1 -> v2: >>> >>>    - Use edk2 default boot file names >>> --- >>>   include/config_distro_bootcmd.h | 14 +++++++++++++- >>>   1 file changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/config_distro_bootcmd.h >>> b/include/config_distro_bootcmd.h >>> index f567cebd38..eefdfb51cc 100644 >>> --- a/include/config_distro_bootcmd.h >>> +++ b/include/config_distro_bootcmd.h >>> @@ -100,6 +100,10 @@ >>>   #define BOOTEFI_NAME "bootia32.efi" >>>   #elif defined(CONFIG_X86_RUN_64BIT) >>>   #define BOOTEFI_NAME "bootx64.efi" >>> +#elif defined(CONFIG_CPU_RISCV_32) >>> +#define BOOTEFI_NAME "bootriscv32.efi" >>> +#elif defined(CONFIG_CPU_RISCV_64) >>> +#define BOOTEFI_NAME "bootriscv64.efi" >> >> Thanks for updating this. >> >>>   #endif >>>   #endif >>> @@ -250,7 +254,15 @@ >>>   #elif defined(CONFIG_X86) >>>   /* Always assume we're running 64bit */ >>>   #define BOOTENV_EFI_PXE_ARCH "0x7" >>> -#define BOOTENV_EFI_PXE_VCI "PXEClient:Arch:00007:UNDI:003000" >>> +#define BOOTENV_EFI_PXE_VCI "PXEClient:Arch:0000:UNDI:003000" >> >> Did you inadvertently modify this line? The change does not relate to >> the commit message. >> >>> +#elif defined(CONFIG_CPU_RISCV_32) >>> +/* TODO: Register VCI identifier via RFC */ >>> +#define BOOTENV_EFI_PXE_ARCH "0x5032" >>> +#define BOOTENV_EFI_PXE_VCI "PXEClient:Arch:5032:UNDI:003000" >> >> Should this be 05032? X86 uses 5 digits. > > These are decimal numbers so this should be > PXEClient:Arch:20530:UNDI:003000 Turns out there are values defined: http://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml I'll update it accordingly. Alex