From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6227AC3A5A0 for ; Mon, 19 Aug 2019 18:29:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A434218BA for ; Mon, 19 Aug 2019 18:29:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A434218BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzmPL-0002dD-EE for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 14:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57136) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzmOf-0001zv-4o for qemu-devel@nongnu.org; Mon, 19 Aug 2019 14:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzmOe-0005Ls-2l for qemu-devel@nongnu.org; Mon, 19 Aug 2019 14:28:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56906) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzmOd-0005L3-QM for qemu-devel@nongnu.org; Mon, 19 Aug 2019 14:28:48 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D74F4811D8 for ; Mon, 19 Aug 2019 18:28:46 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id o13so5624174wrx.20 for ; Mon, 19 Aug 2019 11:28:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V4/aFq6DDEPmRVpJY8yCxsJYN8Z3oDBG76SrumSRDN4=; b=MvY+jEL5FRbRW9ENdpSsnnyhIlDWa+9jAcj9jfYrn/qDXXRpxbUkRdEUTh/smh8ae0 KD3TIWcDUf9agfKnKtkjcBmKsUHJaUipUCzGS1meTNeyqog9A2SvNqTQucQJyGThaQU4 DboFHuDmHkLmSOp0nplEh9Pk6dTINmd+1kK3mXnC77uD2UJl6ZEKuPJojOTgF199tQrg qjeXD/VGjYUBF2H0Ik+9jcpslQpOZY/BVhJjr4B5uYx0VoSy4lFIkUdcWMUUjtNoFuyx 4nY9VYdAKD53e/EHqIaT5Sw4NdZxgTjplaN2JzwDcAIhSugSB6vJO1L1h8mgB8GRUili UU0A== X-Gm-Message-State: APjAAAWhkTvNcu1pEYeCwZ0hLZfPUQZ+hTD4I2bh5q+BX3kTCEgWpILi qMSbwjqS8BvLn0FntLnWUduAmSmOg8S7XLuVVqOY3BWHnLCCkfFo5J2uV+Rko0sD8nUVbYKp241 CkIjWZeNpjKbM/Ko= X-Received: by 2002:adf:8364:: with SMTP id 91mr29003165wrd.13.1566239325377; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUtjtGjGnkBVkOZjVo/50Uby5R91gtIkNP9G8lQQx5CBDC3ajHH42W8ebY9hYyiOtnQTbC1A== X-Received: by 2002:adf:8364:: with SMTP id 91mr29003101wrd.13.1566239325062; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:399c:411e:1ccb:f240? ([2001:b07:6468:f312:399c:411e:1ccb:f240]) by smtp.gmail.com with ESMTPSA id f7sm21779124wrf.8.2019.08.19.11.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2019 11:28:44 -0700 (PDT) To: Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> Date: Mon, 19 Aug 2019 20:28:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, philmd@redhat.com, green@moxielogic.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, amarkovic@wavecomp.com, jan.kiszka@web.de, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, jasowang@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, lersek@redhat.com, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, stefanb@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/08/19 12:12, Thomas Huth wrote: > This patch is *huge*, more than 800kB. It keeps being stuck in the the > filter of the qemu-s390x list each time you send it. Please: > > 1) Try to break it up in more digestible pieces, e.g. change only one > subsystem at a time (this is also better reviewable by people who are > interested in one area) This is not really possible, since the patch is basically a search-and-replace. You could perhaps use some magic ("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it would introduce more complication than anything else. Agreed on the HTML though. :) Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EF9C3A5A0 for ; Mon, 19 Aug 2019 18:29:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46514218BA for ; Mon, 19 Aug 2019 18:29:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46514218BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzmOg-0004Kg-51; Mon, 19 Aug 2019 18:28:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzmOe-0004KW-Tn for xen-devel@lists.xenproject.org; Mon, 19 Aug 2019 18:28:48 +0000 X-Inumbo-ID: 2f47207a-c2af-11e9-a661-bc764e2007e4 Received: from mx1.redhat.com (unknown [209.132.183.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f47207a-c2af-11e9-a661-bc764e2007e4; Mon, 19 Aug 2019 18:28:48 +0000 (UTC) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79B78C057EC0 for ; Mon, 19 Aug 2019 18:28:47 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id k14so5657858wrv.2 for ; Mon, 19 Aug 2019 11:28:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V4/aFq6DDEPmRVpJY8yCxsJYN8Z3oDBG76SrumSRDN4=; b=A+gDVeWHOFkUTk6u+gBAB2O/6P+tn9fYaXE/ffwW49vbCzZoHkKvmHVHYJ+Io5xNSN 0jq6i5/eO7pBiY5c/9fAr7HH0FVUzywKp03uvfbI/R8Hr/L3dAACCutHfM45IMaFJUfG oiHZWGjc2xzk11sFEcZ3enYnzMKCn7NjnYs/hdoe/x4l01lniyhU8cBeZkikUz0jGhP/ W2fgaNDRvmEpJSn5jW7xbphhdMzr/U1rLkaUdByNWvRAhJj0wz4tCZtyce+z2IPDT21A ejVoUDfwc2x8GiwLccu8j89IIwUacXScT1Dhg0WqEaNGUbcwz3HJmT3QoxXS/+ZjCScU I8QA== X-Gm-Message-State: APjAAAXUysbKy1zL+hdbSq22XMy2YBM0w0iEX/GJwrTUUujMGi+CuOUn h4XFdJhQH4YD85Zz5ynM8W641gTJOj5Ptyap9sotPzAZKT6HGbk5PxPpzQodH7DG3tHduodK0Lg 1Tt55HkYMrfPvCQ6fjVMK52ERouM= X-Received: by 2002:adf:8364:: with SMTP id 91mr29003162wrd.13.1566239325376; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUtjtGjGnkBVkOZjVo/50Uby5R91gtIkNP9G8lQQx5CBDC3ajHH42W8ebY9hYyiOtnQTbC1A== X-Received: by 2002:adf:8364:: with SMTP id 91mr29003101wrd.13.1566239325062; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:399c:411e:1ccb:f240? ([2001:b07:6468:f312:399c:411e:1ccb:f240]) by smtp.gmail.com with ESMTPSA id f7sm21779124wrf.8.2019.08.19.11.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2019 11:28:44 -0700 (PDT) To: Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> Date: Mon, 19 Aug 2019 20:28:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> Content-Language: en-US Subject: Re: [Xen-devel] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, philmd@redhat.com, green@moxielogic.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, balaton@eik.bme.hu, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, marcel.apfelbaum@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, amarkovic@wavecomp.com, jan.kiszka@web.de, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, jasowang@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, lersek@redhat.com, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, balrogg@gmail.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, stefanb@linux.ibm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTYvMDgvMTkgMTI6MTIsIFRob21hcyBIdXRoIHdyb3RlOgo+IFRoaXMgcGF0Y2ggaXMgKmh1 Z2UqLCBtb3JlIHRoYW4gODAwa0IuIEl0IGtlZXBzIGJlaW5nIHN0dWNrIGluIHRoZSB0aGUKPiBm aWx0ZXIgb2YgdGhlIHFlbXUtczM5MHggbGlzdCBlYWNoIHRpbWUgeW91IHNlbmQgaXQuIFBsZWFz ZToKPiAKPiAxKSBUcnkgdG8gYnJlYWsgaXQgdXAgaW4gbW9yZSBkaWdlc3RpYmxlIHBpZWNlcywg ZS5nLiBjaGFuZ2Ugb25seSBvbmUKPiBzdWJzeXN0ZW0gYXQgYSB0aW1lICh0aGlzIGlzIGFsc28g YmV0dGVyIHJldmlld2FibGUgYnkgcGVvcGxlIHdobyBhcmUKPiBpbnRlcmVzdGVkIGluIG9uZSBh cmVhKQoKVGhpcyBpcyBub3QgcmVhbGx5IHBvc3NpYmxlLCBzaW5jZSB0aGUgcGF0Y2ggaXMgYmFz aWNhbGx5IGEKc2VhcmNoLWFuZC1yZXBsYWNlLiAgWW91IGNvdWxkIHBlcmhhcHMgdXNlIHNvbWUg bWFnaWMKKCJERVZJQ0VfTUVNT1BfRU5ESUFOIiBvciBzb21ldGhpbmcgbGlrZSB0aGF0KSB0byBh bGxvdyBhIHNwbGl0LCBidXQgaXQKd291bGQgaW50cm9kdWNlIG1vcmUgY29tcGxpY2F0aW9uIHRo YW4gYW55dGhpbmcgZWxzZS4KCkFncmVlZCBvbiB0aGUgSFRNTCB0aG91Z2guIDopCgpQYW9sbwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1hzmOh-00021V-VL for mharc-qemu-riscv@gnu.org; Mon, 19 Aug 2019 14:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57162) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzmOf-000200-MX for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 14:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzmOe-0005MH-Er for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 14:28:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzmOe-0005Lf-6N for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 14:28:48 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36A7D11A1E for ; Mon, 19 Aug 2019 18:28:47 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id a17so5647124wrr.10 for ; Mon, 19 Aug 2019 11:28:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V4/aFq6DDEPmRVpJY8yCxsJYN8Z3oDBG76SrumSRDN4=; b=sXY9a69aRdb/19uqpiMpTo2jmrj/o57bZ4XQ1g6C5ME69sL9MY835sxORCbrABL6+7 xROvWDSmIGDGxlU1hO337q9hb86SH86eiGR1/CZqGhDLYNtz5DyAvIqA1SMQJecOpu2Q YtXWtREtBam89cOtu8jaRPhvYIZmuGLcIefdsrhOL4x72pQye9H9L5R/INJJUy5PobJq TNss0tSRKZgYXgmmZv/Ry4O7C2lVkcT43zRfQWYVG++tgy2NyajLASrsEU3znjgJEVxd SJhJy2p5hp2JmNrgMaEJDtBCYEQg6GCqYQjYoXMpyISfzVgn81oc8ac87ZlZOlDNTI0l Dqsg== X-Gm-Message-State: APjAAAVRaWnmotLvHlNGVQJrbzsM7jDkCf+LdZwcnzNVNEj1iWnrVcLn y9CLPn3APMtmbDJJ+G3PkcSV+B/JM9DpEsnf7XSUqe8SN0irWBrznh8/0TLD+8/nTgULTK00oF6 ItDfBUcsMVj+skkc= X-Received: by 2002:adf:8364:: with SMTP id 91mr29003124wrd.13.1566239325369; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUtjtGjGnkBVkOZjVo/50Uby5R91gtIkNP9G8lQQx5CBDC3ajHH42W8ebY9hYyiOtnQTbC1A== X-Received: by 2002:adf:8364:: with SMTP id 91mr29003101wrd.13.1566239325062; Mon, 19 Aug 2019 11:28:45 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:399c:411e:1ccb:f240? ([2001:b07:6468:f312:399c:411e:1ccb:f240]) by smtp.gmail.com with ESMTPSA id f7sm21779124wrf.8.2019.08.19.11.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2019 11:28:44 -0700 (PDT) To: Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, lersek@redhat.com, jasowang@redhat.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, balaton@eik.bme.hu, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, marcel.apfelbaum@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, jan.kiszka@web.de, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, philmd@redhat.com, amarkovic@wavecomp.com, peter.chubb@nicta.com.au, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, green@moxielogic.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, balrogg@gmail.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, stefanb@linux.ibm.com References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> Date: Mon, 19 Aug 2019 20:28:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-riscv] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2019 18:28:50 -0000 On 16/08/19 12:12, Thomas Huth wrote: > This patch is *huge*, more than 800kB. It keeps being stuck in the the > filter of the qemu-s390x list each time you send it. Please: > > 1) Try to break it up in more digestible pieces, e.g. change only one > subsystem at a time (this is also better reviewable by people who are > interested in one area) This is not really possible, since the patch is basically a search-and-replace. You could perhaps use some magic ("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it would introduce more complication than anything else. Agreed on the HTML though. :) Paolo