From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: dm644x: remove unnecessary postcore_initcall()
Date: Thu, 5 Apr 2018 11:40:17 +0530 [thread overview]
Message-ID: <8da02a5b-7c29-eb5d-374e-00515e1e30f6@ti.com> (raw)
In-Reply-To: <87b4ad61-93f4-db74-d373-9e8ac0d1a5b9@lechnology.com>
On Wednesday 04 April 2018 09:22 PM, David Lechner wrote:
>>
>> --- a/arch/arm/mach-davinci/board-sffsdr.c
>> +++ b/arch/arm/mach-davinci/board-sffsdr.c
>> @@ -133,6 +133,12 @@ static void __init davinci_sffsdr_map_io(void)
>> ? static __init void davinci_sffsdr_init(void)
>> ? {
>> ????? struct davinci_soc_info *soc_info = &davinci_soc_info;
>> +??? int ret;
>> +
>> +??? ret = dm644x_init_devices();
>> +??? if (ret)
>> +??????? pr_warn("%s: dm644x_init_devices() failed: %d\n",
>> +??????????? __func__, ret);
>
> dm644x_init_devices() already prints a warning in all failure cases, so
> printing another warning seems a bit redundant. It is probably OK to just
> ignore the return value here and in the similar uses above.
Alright, will fix and send v2.
Regards,
Sekhar
prev parent reply other threads:[~2018-04-05 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 12:57 [PATCH] ARM: davinci: dm644x: remove unnecessary postcore_initcall() Sekhar Nori
2018-04-04 15:52 ` David Lechner
2018-04-05 6:10 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da02a5b-7c29-eb5d-374e-00515e1e30f6@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.