From: Javier Martinez Canillas <javierm@redhat.com>
To: Carlos Maiolino <cmaiolino@redhat.com>, grub-devel@gnu.org
Cc: daniel.kiper@oracle.com
Subject: Re: [PATCH 1/2] Add bigtime support for xfs driver
Date: Tue, 13 Apr 2021 19:12:25 +0200 [thread overview]
Message-ID: <8dc09b75-bd64-fa74-1216-9484457975dd@redhat.com> (raw)
In-Reply-To: <20210323132959.1594989-2-cmaiolino@redhat.com>
Hello Carlos,
Please add a "fs/xfs:" prefix to your subject line.
On 3/23/21 2:29 PM, Carlos Maiolino wrote:
> XFS filesystem now supports bigtime feature, to overcome y2038 problem.
> This patch makes grub able to support xfs filesystems with this feature
> enabled.
>
> xfs counter for bigtime enable timestamps starts on 0, which translates
> to INT32_MIN (Dec 31 20:45:52 UTC 1901) in the legacy timestamps. The
> conversion to unix timestamps is made before passing the value to
> grub-core.
>
> For this to work properly, grub requires to access flags2 field in the
> xfs ondisk inode, so, the grub_xfs_inode structure has been updated to
> the full ondisk inode size.
>
> This patch is enough to make grub work properly with files with
> timestamps up to INT32_MAX (y2038), any file with timestamps bigger than
> this will overflow the counter, causing grub to show wrong timestamps
> (not really much difference on current situation).
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
next prev parent reply other threads:[~2021-04-13 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:29 [PATCH 0/2] Enable bigtime feature for xfs driver Carlos Maiolino
2021-03-23 13:29 ` [PATCH 1/2] Add bigtime support " Carlos Maiolino
2021-04-13 17:12 ` Javier Martinez Canillas [this message]
2021-03-23 13:29 ` [PATCH 2/2] Use 64bit type for filesystem timestamp Carlos Maiolino
2021-04-13 17:26 ` Javier Martinez Canillas
2021-03-23 18:09 ` [PATCH 0/2] Enable bigtime feature for xfs driver Daniel Kiper
2021-03-24 10:54 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc09b75-bd64-fa74-1216-9484457975dd@redhat.com \
--to=javierm@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.