Re: [PATCH/RFC 02/02] ravb: Clean up duplex handling

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 07/19/2018 02:51 PM, Magnus Damm wrote:

> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Since only full-duplex operation is supported by the
> hardware, remove duplex handling code and keep the
> register setting of ECMR.DM fixed at 1.
> 
> This updates the driver implementation to follow the
> data sheet text "This bit should always be set to 1."
> 
> Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

   Sounds like a fix, please provide a Fixes: tag (I think we're fixing
the initial driver commit here). 

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
> 
>  Written on top of renesas-drivers-2018-07-17-v4.18-rc5

   Next time please base atop of DaveM's net.git repo.

[...]
> --- 0003/drivers/net/ethernet/renesas/ravb_main.c
> +++ work/drivers/net/ethernet/renesas/ravb_main.c	2018-07-19 19:44:14.370607110 +0900
[...]
> @@ -1131,13 +1114,6 @@ static int ravb_set_link_ksettings(struc
>  	if (error)
>  		goto error_exit;
>  
> -	if (cmd->base.duplex == DUPLEX_FULL)
> -		priv->duplex = 1;
> -	else
> -		priv->duplex = 0;
> -
> -	ravb_set_duplex(ndev);
> -

   This fragment no longer exists in net.git...

[...]

MBR, Sergei