From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30CDC7EE23 for ; Fri, 24 Feb 2023 19:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbjBXTSE (ORCPT ); Fri, 24 Feb 2023 14:18:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbjBXTSA (ORCPT ); Fri, 24 Feb 2023 14:18:00 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13EE66A7A2 for ; Fri, 24 Feb 2023 11:17:31 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id bw19so162659wrb.13 for ; Fri, 24 Feb 2023 11:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nlPt4Q3q43f/kES2hajYBu0feYXRxIPRsViZnbHRgo8=; b=ULOxdkQfJSc2wzWXnZzkcOyay31tWrkYETOwBzB86fVZxSrlFxO0D+wFcUzNSs6OEy G/Wj5Om0d1dD3bur8hORomrHxlcp2EbExVSVCLMSKMGK2NC7h+NFjFMV7o67rbfpdPJe IeIpNPsVMo+s+E7ly717Zk+OS1Cl+Gkl9QbLcj3fT3nhhNHD2KH0fO3KZ5srXAerW70V tMXC90LPZ9cSFAyS4VDbe7A4PUZgMQ9Wp0rQS6agHwqpMfgMxvvB9otmc4DTHrlHl4/M oNvhx15NDacei8jDIfP7/qN6BwU6owh6GMJBAE5cP+r6LbEuEks5hO4JemkXa5R1bXEO QiwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nlPt4Q3q43f/kES2hajYBu0feYXRxIPRsViZnbHRgo8=; b=LJVp5YJ5DOd2aFgrd9dCSipNeqi+eqiSerP0fCexxpPIOm9yZ35ILRYF/Kaj4U7mBI JSb5LQpdYUEitzo7XKNg96fKlOCYreL7er0U1CTkKABLaweCZaQVIn4Lz8ASSR6WqY/O ns099mEUzB8LRP7OWkx+m78myWJelIPqSnS/2QG6tcLcoQY6LB4eXKz1dnR0GRGxZRlS V9LWd5GAxDLQKy0v5/0GTe/VEahOT2YgkkUyi4CQVz3thQQUjqXGN9N0UWr/BR0staTZ fIcbE1k7tzQ1q39Q1gm2LixVXOc8YsNSEjBfrw4fu9mWrgO8aP61KnR4fi4OGAC+NJJD 3kyQ== X-Gm-Message-State: AO0yUKVRhpHYBYlc3zFd+INy/onkk7vfATnsmjPYfMt91OHCXIomu0fr lKrk8kRndFjI9VqAkykJxE1l/Q== X-Google-Smtp-Source: AK7set8bcMpUzNCKsQ+jr5w1UWR23aN9ub4GLVSYhJodv/gdPO0QitNKBJ4ItzsHaFeUGdPOLJvusA== X-Received: by 2002:a5d:6f01:0:b0:2bf:d937:3589 with SMTP id ay1-20020a5d6f01000000b002bfd9373589mr594169wrb.14.1677266249149; Fri, 24 Feb 2023 11:17:29 -0800 (PST) Received: from ?IPV6:2a02:6b6a:b566:0:d12b:5d7b:42ef:d31a? ([2a02:6b6a:b566:0:d12b:5d7b:42ef:d31a]) by smtp.gmail.com with ESMTPSA id x8-20020adfdd88000000b002c58ca558b6sm13612940wrl.88.2023.02.24.11.17.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 11:17:28 -0800 (PST) Message-ID: <8dcac250-474a-6102-1a60-b8ad84eb0a4b@bytedance.com> Date: Fri, 24 Feb 2023 19:17:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [External] Re: [PATCH v11 09/12] x86/smpboot: Remove initial_stack on 64-bit Content-Language: en-US To: David Woodhouse , "Michael Kelley (LINUX)" , "tglx@linutronix.de" , "kim.phillips@amd.com" , "brgerst@gmail.com" Cc: "piotrgorski@cachyos.org" , "oleksandr@natalenko.name" , "arjan@linux.intel.com" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "x86@kernel.org" , "pbonzini@redhat.com" , "paulmck@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "rcu@vger.kernel.org" , "mimoja@mimoja.de" , "hewenliang4@huawei.com" , "thomas.lendacky@amd.com" , "seanjc@google.com" , "pmenzel@molgen.mpg.de" , "fam.zheng@bytedance.com" , "punit.agrawal@bytedance.com" , "simon.evans@bytedance.com" , "liangma@liangbit.com" References: <20230223191140.4155012-1-usama.arif@bytedance.com> <20230223191140.4155012-10-usama.arif@bytedance.com> <2c3abf634824f2b7207a3ac94985863472d67608.camel@infradead.org> From: Usama Arif In-Reply-To: <2c3abf634824f2b7207a3ac94985863472d67608.camel@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2023 18:28, David Woodhouse wrote: > On Fri, 2023-02-24 at 18:24 +0000, Michael Kelley (LINUX) wrote: >> I'm getting a compile error on the new reference to PTREGS_SIZE: > > Is it just that is included conditionally, and not > in your build? What if you include it directly from This is fixed in the v2 patch that Brian sent. diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 9c4a5c4d46c1..bdde7316e75b 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -650,8 +650,8 @@ static inline void spin_lock_prefetch(const void *x) #else extern unsigned long __end_init_task[]; -#define INIT_THREAD { \ - .sp = (unsigned long)&__end_init_task - PTREGS_SIZE, \ +#define INIT_THREAD { \ + .sp = (unsigned long)&__end_init_task - sizeof(struct pt_regs), \ } extern unsigned long KSTK_ESP(struct task_struct *task);