From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6936CC43331 for ; Tue, 31 Mar 2020 14:43:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 386E62071A for ; Tue, 31 Mar 2020 14:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="SNVk/6Bi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 386E62071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJI6f-0008TD-NO; Tue, 31 Mar 2020 14:43:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jJI6e-0008T7-CF for xen-devel@lists.xenproject.org; Tue, 31 Mar 2020 14:43:08 +0000 X-Inumbo-ID: ef406080-735d-11ea-ba29-12813bfff9fa Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ef406080-735d-11ea-ba29-12813bfff9fa; Tue, 31 Mar 2020 14:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1585665787; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=k6sZErTXX4Dd552tIFSDCVBDQcP3WdIiGGyfrIjjaDw=; b=SNVk/6Bih9lUmD7xwsCx8l3Ehvm/fuRXTZQi+p+RtOPf6Ihq/ehIgFH7 8ntg9dcf6qZn8/cJkpfsJxWKfF7pvNFCCJo8+YQzSjsf+9shG12Oyyiu0 jI1hbsjdnJulN5PQiShTEiDzgpe68q2Ds+N9zAUIa3FP+zpnIGvPUlOhB k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ut3ilwmamlN3xwyygqWv9XHpyxF0X2O/NjIwQ6Ss0Ecoy88DNrOxxhgtDZheIn2ys37Ei/uSi6 qULAVUpu+DAVksG7zn+LtCpTEf0gN97fXyXt+gpam2vOEWpN8DsfLDHbdGLFhGIhbX0egp73FN dpwl7ZhUbFhjgvQSlvgpTrXdwHv3dtZkCZZNIkmuORXF1HP6TZi7mSxw2Nxcci6T0JstGtQZKf 5Hc0N8aZdeNsjZ4WwRK2p1/UY0wn/weHtS4ny+Gk/UgdZunQMvWvcE2QGRhTd7H4rtXF/5YHWa Dvk= X-SBRS: 2.7 X-MesageID: 15591251 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,328,1580792400"; d="scan'208";a="15591251" Subject: Re: [PATCH 08/11] x86/ucode/amd: Rename bufsize to size in cpu_request_microcode() To: Jan Beulich References: <20200331100531.4294-1-andrew.cooper3@citrix.com> <20200331100531.4294-9-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: <8dd2e9f1-99d1-2e5c-b710-b4fa92b34b97@citrix.com> Date: Tue, 31 Mar 2020 15:43:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31/03/2020 15:41, Jan Beulich wrote: > On 31.03.2020 12:05, Andrew Cooper wrote: >> To simplify future cleanup, rename this variable. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich > >> @@ -438,7 +437,7 @@ static struct microcode_patch *cpu_request_microcode(const void *buf, >> unsigned int cpu = smp_processor_id(); >> const struct cpu_signature *sig = &per_cpu(cpu_sig, cpu); >> >> - if ( bufsize < 4 || >> + if ( size < 4 || >> *(const uint32_t *)buf != UCODE_MAGIC ) > Take the opportunity and put this on a single line? I have actually done that in a later patch. This was introduced in patch 1, so I'll fix there and rebase it throughout the series. ~Andrew