All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian von Ohr <vonohr@smaract.com>
To: Felipe Balbi <balbi@kernel.org>,
	Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Thinh Nguyen <thinhn@synopsys.com>
Subject: RE: [BUG REPORT] usb: dwc3: Timeouts with USB 2.0 LPM active
Date: Wed, 12 May 2021 09:28:10 +0000	[thread overview]
Message-ID: <8ddf90943cd84c23966eb93fbc00722b@smaract.com> (raw)
In-Reply-To: <878s4ticf7.fsf@kernel.org>

> From: Felipe Balbi [mailto:balbi@kernel.org]
> > For a test I've changed some conditions in the driver so that
> > __dwc3_gadget_wakeup is also called on transfer updates and the link state
> > change also happens when in U2. This change actually fixed my timeout issue.
> > However, I'm not sure if this is actually the correct thing to do. I'm by far
> > no USB expert and I don't have access to the dwc3 databook.
> 
> Right, AFAIR the databook was a bit unclear about this. It stated that
> it was required only for Start Transfer, but I always had the same
> doubt. No idea if the databook has been clarified since then.

Maybe somebody with access to the databook can clarify this? Since dwc3 defaults
to USB 3.0 speed and LPM enabled this should affect most USB gadgets users and 
I'd like to see this issue fixed. I'm still wondering why there have been no
previous reports for this bug (that I know of). Surely I'm not the only one
using a function FS usb gadget.

  reply	other threads:[~2021-05-12  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 13:12 [BUG REPORT] usb: dwc3: Timeouts with USB 2.0 LPM active Sebastian von Ohr
2021-05-03 13:52 ` Felipe Balbi
2021-05-03 14:15   ` Sebastian von Ohr
2021-05-04  6:28     ` Felipe Balbi
2021-05-04  9:47       ` Sebastian von Ohr
2021-05-05 12:37         ` Felipe Balbi
2021-05-12  9:28           ` Sebastian von Ohr [this message]
2021-05-05  8:02   ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ddf90943cd84c23966eb93fbc00722b@smaract.com \
    --to=vonohr@smaract.com \
    --cc=balbi@kernel.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=thinhn@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.