From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DE2C433EF for ; Tue, 29 Mar 2022 02:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbiC2CaA (ORCPT ); Mon, 28 Mar 2022 22:30:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230358AbiC2C34 (ORCPT ); Mon, 28 Mar 2022 22:29:56 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736453A5; Mon, 28 Mar 2022 19:28:13 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 011495C01FC; Mon, 28 Mar 2022 22:28:11 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute5.internal (MEProxy); Mon, 28 Mar 2022 22:28:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=Tg9t/nSNCv1cymBb9h1DbMyvjS3EsvJEQGzQp2 TOyM8=; b=XFkdhraQUwYLP4o4yQoWxpA4KPNvgAs2MZq5+h6OpbYKgarMR4XyAq eG954aYjmlj8D2qo8GV/K665oRn6qcrLy1ZbDcfjin8++CdViVHiXBeFEGy16Age YdaQXEW/CF8BBxVa16ceFrWcYrlpsGnPhjyhMTzW5VrJU8K5nc6QXadF9VbKXR5x LXE1RgCvGYE4TgQb3RwT/b76aKSXiGYC6OJz/p+Yd0fdVi25dpT95casX3VTTGAl mFWYEESn1vqThBiSwqFQkYHV2J5lb//emdr4G4JpxYwDs8eEv1Mguex0xjZD+Z1c o6NDTk+UVfKg6m+fhtwlY2YvN9ALrkbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Tg9t/nSNCv1cymBb9 h1DbMyvjS3EsvJEQGzQp2TOyM8=; b=ll4aACnB0xXdqAGPRtbi6xARgqY3/Dv6v +P6I5Nha/DNjDpYCXI/weghAkDyzJS9w4tn8KIom47b7WZlcPLwtC/414LGdtKfZ D96ceFgosXG/PtyVWM7kLWsvRWao0fZGFk9S4CuikDiFy4LjdU1o6fdh8RMxUJXb LwVOWEFkq4S18j1cSy/jn9iHtzFh7kJXf9ZyWCEyXNbP1x/6zjdESpu/1G+m0lLQ jMgAmdqHBtCcJGN4Zf1SV7gifBLgKz9ONov5rkJvQubwrHdCgWk1P71EUReQTgei Dyn+ZQ9RLZzOM1zEv1+1/VHVuXT8p1BsrOtugf492fJ5Hy/lZDeDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehkedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 76362F6043F; Mon, 28 Mar 2022 22:28:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4911-g925b585eab-fm-20220323.003-g925b585e Mime-Version: 1.0 Message-Id: <8de31099-3695-4d9c-a656-525ff1945112@www.fastmail.com> In-Reply-To: References: Date: Tue, 29 Mar 2022 12:57:39 +1030 From: "Andrew Jeffery" To: "Howard Chiu" , "Rob Herring" , "Joel Stanley" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Cc: "Troy Lee" Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Howard, On Tue, 29 Mar 2022, at 12:08, Howard Chiu wrote: > The ast2600 SoC has an embedded video engine > This node was removed by commit 645afe7 The summary line of the commit should follow the commit ID (which should also be 12 characters not 7) here, so: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node") > And then you also need a fixes tag: Fixes: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node") > Signed-off-by: Howard Chiu > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index c32e87fad4dc..aac55b3aeded 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -389,6 +389,16 @@ sbc: secure-boot-controller@1e6f2000 { > reg = <0x1e6f2000 0x1000>; > }; > > + video: video@1e700000 { > + compatible = "aspeed,ast2600-video-engine"; > + reg = <0x1e700000 0x1000>; > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, > + <&syscon ASPEED_CLK_GATE_ECLK>; > + clock-names = "vclk", "eclk"; > + interrupts = ; > + status = "disabled"; > + }; > + > gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; > -- > 2.25.1 Cheers, Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1919DC433F5 for ; Tue, 29 Mar 2022 02:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G1hBFsQehBIXs1hQJH300mDYKpqoGiFETQ4C1ksBkvo=; b=kIlijBaT+AWYfS EgezeAym00jkjp1vjEgO7OGm1mh+9NxTLqfJSZRjYGUOyJL86WAdBDUytjMfDBvBaqQX9ApkujvsE dL/b4fj19J7Yfqcv67ZbLmCFkRa3a3sERQ3jyc/C3t7TttEVGSwqy/0Oo9KYMKuqdY80oxUPWIcgG 98RMxFfbU1r7ZhGla/MUPB8D71kPn0xRLNm9mIVaQhce9h9ZTlKeLQ0hiuiYJOwWPnxuEWBNUj9yl WatLtS+hGLdhfAtC5DaGkvgQOZy5EgaazjfMtM09NmfaxMwKYTqX5t3wW1IZ9qFhGq4lwk8BNKmL7 rq7ZeGI4Z4jkd4zW5gMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ1aj-00Ak2i-6K; Tue, 29 Mar 2022 02:28:17 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ1ag-00Ak1j-49 for linux-arm-kernel@lists.infradead.org; Tue, 29 Mar 2022 02:28:15 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 011495C01FC; Mon, 28 Mar 2022 22:28:11 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute5.internal (MEProxy); Mon, 28 Mar 2022 22:28:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=Tg9t/nSNCv1cymBb9h1DbMyvjS3EsvJEQGzQp2 TOyM8=; b=XFkdhraQUwYLP4o4yQoWxpA4KPNvgAs2MZq5+h6OpbYKgarMR4XyAq eG954aYjmlj8D2qo8GV/K665oRn6qcrLy1ZbDcfjin8++CdViVHiXBeFEGy16Age YdaQXEW/CF8BBxVa16ceFrWcYrlpsGnPhjyhMTzW5VrJU8K5nc6QXadF9VbKXR5x LXE1RgCvGYE4TgQb3RwT/b76aKSXiGYC6OJz/p+Yd0fdVi25dpT95casX3VTTGAl mFWYEESn1vqThBiSwqFQkYHV2J5lb//emdr4G4JpxYwDs8eEv1Mguex0xjZD+Z1c o6NDTk+UVfKg6m+fhtwlY2YvN9ALrkbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Tg9t/nSNCv1cymBb9 h1DbMyvjS3EsvJEQGzQp2TOyM8=; b=ll4aACnB0xXdqAGPRtbi6xARgqY3/Dv6v +P6I5Nha/DNjDpYCXI/weghAkDyzJS9w4tn8KIom47b7WZlcPLwtC/414LGdtKfZ D96ceFgosXG/PtyVWM7kLWsvRWao0fZGFk9S4CuikDiFy4LjdU1o6fdh8RMxUJXb LwVOWEFkq4S18j1cSy/jn9iHtzFh7kJXf9ZyWCEyXNbP1x/6zjdESpu/1G+m0lLQ jMgAmdqHBtCcJGN4Zf1SV7gifBLgKz9ONov5rkJvQubwrHdCgWk1P71EUReQTgei Dyn+ZQ9RLZzOM1zEv1+1/VHVuXT8p1BsrOtugf492fJ5Hy/lZDeDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehkedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 76362F6043F; Mon, 28 Mar 2022 22:28:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4911-g925b585eab-fm-20220323.003-g925b585e Mime-Version: 1.0 Message-Id: <8de31099-3695-4d9c-a656-525ff1945112@www.fastmail.com> In-Reply-To: References: Date: Tue, 29 Mar 2022 12:57:39 +1030 From: "Andrew Jeffery" To: "Howard Chiu" , "Rob Herring" , "Joel Stanley" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Cc: "Troy Lee" Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_192814_343339_88707A8D X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Howard, On Tue, 29 Mar 2022, at 12:08, Howard Chiu wrote: > The ast2600 SoC has an embedded video engine > This node was removed by commit 645afe7 The summary line of the commit should follow the commit ID (which should also be 12 characters not 7) here, so: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node") > And then you also need a fixes tag: Fixes: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node") > Signed-off-by: Howard Chiu > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index c32e87fad4dc..aac55b3aeded 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -389,6 +389,16 @@ sbc: secure-boot-controller@1e6f2000 { > reg = <0x1e6f2000 0x1000>; > }; > > + video: video@1e700000 { > + compatible = "aspeed,ast2600-video-engine"; > + reg = <0x1e700000 0x1000>; > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>, > + <&syscon ASPEED_CLK_GATE_ECLK>; > + clock-names = "vclk", "eclk"; > + interrupts = ; > + status = "disabled"; > + }; > + > gpio0: gpio@1e780000 { > #gpio-cells = <2>; > gpio-controller; > -- > 2.25.1 Cheers, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel