All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <Martin.Wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH] libmultipath: simplify failed wwid code
Date: Fri, 8 May 2020 19:25:42 +0000	[thread overview]
Message-ID: <8de715fa759f8f28bb0e5321201d7f34cdd3ae4e.camel@suse.com> (raw)
In-Reply-To: <20200508163200.GQ5907@octiron.msp.redhat.com>

On Fri, 2020-05-08 at 11:32 -0500, Benjamin Marzinski wrote:
> On Fri, May 08, 2020 at 09:15:32AM +0000, Martin Wilck wrote:
> > 
> > Please consider adding the attached patch on top, which switches
> > back
> > to atomic creation of the failed_wwids file, with just a little bit
> > more compexity. I prefer the creation of the file to be atomic on
> > the
> > file system level. IMO that's how "flag" files like this should be
> > handled in principle, and doing it correctly makes me feel better,
> > even
> > though I have to concur that an actual race is hardly possible.
> 
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> 
> Or where you looking for me to respin with this included? Either way
> is
> fine.

Please respin, to have a clean patch set on the ML.

Regards,
Martin

      reply	other threads:[~2020-05-08 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 22:39 [PATCH] libmultipath: simplify failed wwid code Benjamin Marzinski
2020-05-08  9:15 ` Martin Wilck
2020-05-08 16:32   ` Benjamin Marzinski
2020-05-08 19:25     ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8de715fa759f8f28bb0e5321201d7f34cdd3ae4e.camel@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.