From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C70BC433DF for ; Thu, 28 May 2020 07:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25CCD207D3 for ; Thu, 28 May 2020 07:22:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KgZbRJWm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbgE1HWA (ORCPT ); Thu, 28 May 2020 03:22:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:50753 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725601AbgE1HV7 (ORCPT ); Thu, 28 May 2020 03:21:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590650517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=KgZbRJWmJOOTW8jTKbf6lqP3lTKEobDoLRc0+EYDE1JF68OXGYG+IJ3XSkcU9g+E6LgMZa 4fvIqfuXB4+VPbYcA4Jha+Kw/vqc8rf9V6TBhyRPzmrXM8PUWA2DtsfNDztmNYXaRLpr5J ygg6nwLbYlAXcVNL2RcwlzvtwtaYATg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-coeiy8M4OwqtVw4hX2GvfQ-1; Thu, 28 May 2020 03:21:55 -0400 X-MC-Unique: coeiy8M4OwqtVw4hX2GvfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCF0C107ACCD; Thu, 28 May 2020 07:21:53 +0000 (UTC) Received: from [10.36.113.56] (ovpn-113-56.ams2.redhat.com [10.36.113.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8AA410013DB; Thu, 28 May 2020 07:21:48 +0000 (UTC) Subject: Re: [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address To: Robin Murphy , Srinath Mannam , Will Deacon , Joerg Roedel Cc: bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alex Williamson , Jean-Philippe Brucker References: <1590595398-4217-1-git-send-email-srinath.mannam@broadcom.com> From: Auger Eric Message-ID: <8de9d9dd-16f9-482b-0ecf-f2f103ede86b@redhat.com> Date: Thu, 28 May 2020 09:21:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/27/20 7:30 PM, Robin Murphy wrote: > On 2020-05-27 17:03, Srinath Mannam wrote: >> This patch gives the provision to change default value of MSI IOVA base >> to platform's suitable IOVA using module parameter. The present >> hardcoded MSI IOVA base may not be the accessible IOVA ranges of >> platform. > > That in itself doesn't seem entirely unreasonable; IIRC the current > address is just an arbitrary choice to fit nicely into Qemu's memory > map, correct and there was always the possibility that it wouldn't suit everything. Indeed I also recently had this case of PCI host bridge collision with the SW MSI reserved window - maybe that's the same ;-) -. > >> Since commit aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible >> DMA address"), inaccessible IOVA address ranges parsed from dma-ranges >> property are reserved. > > That, however, doesn't seem to fit here; iommu-dma maps MSI doorbells > dynamically, so they aren't affected by reserved regions any more than > regular DMA pages are. In fact, it explicitly ignores the software MSI > region, since as the comment says, it *is* the software that manages those. > > The MSI_IOVA_BASE region exists for VFIO, precisely because in that case > the kernel *doesn't* control the address space, but still needs some way > to steal a bit of it for MSIs that the guest doesn't necessarily know > about, and give userspace a fighting chance of knowing what it's taken. > I think at the time we discussed the idea of adding something to the > VFIO uapi such that userspace could move this around if it wanted or > needed to, but decided we could live without that initially. Yes indeed ;-) Perhaps now > the time has come? Do you mean you would welcome a VFIO based approach or would a driver parameter be sufficient? Thanks Eric > > Robin. > >> If any platform has the limitaion to access default MSI IOVA, then it can >> be changed using "arm-smmu.msi_iova_base=0xa0000000" command line >> argument. >> >> Signed-off-by: Srinath Mannam >> --- >>   drivers/iommu/arm-smmu.c | 5 ++++- >>   1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c >> index 4f1a350..5e59c9d 100644 >> --- a/drivers/iommu/arm-smmu.c >> +++ b/drivers/iommu/arm-smmu.c >> @@ -72,6 +72,9 @@ static bool disable_bypass = >>   module_param(disable_bypass, bool, S_IRUGO); >>   MODULE_PARM_DESC(disable_bypass, >>       "Disable bypass streams such that incoming transactions from >> devices that are not attached to an iommu domain will report an abort >> back to the device and will not be allowed to pass through the SMMU."); >> +static unsigned long msi_iova_base = MSI_IOVA_BASE; >> +module_param(msi_iova_base, ulong, S_IRUGO); >> +MODULE_PARM_DESC(msi_iova_base, "msi iova base address."); >>     struct arm_smmu_s2cr { >>       struct iommu_group        *group; >> @@ -1566,7 +1569,7 @@ static void arm_smmu_get_resv_regions(struct >> device *dev, >>       struct iommu_resv_region *region; >>       int prot = IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO; >>   -    region = iommu_alloc_resv_region(MSI_IOVA_BASE, MSI_IOVA_LENGTH, >> +    region = iommu_alloc_resv_region(msi_iova_base, MSI_IOVA_LENGTH, >>                        prot, IOMMU_RESV_SW_MSI); >>       if (!region) >>           return; >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBABC433DF for ; Thu, 28 May 2020 07:22:05 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E94B207BC for ; Thu, 28 May 2020 07:22:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UkueWRj7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E94B207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E76C6889CA; Thu, 28 May 2020 07:22:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v7pzVtezs3Pn; Thu, 28 May 2020 07:22:04 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 3D94088888; Thu, 28 May 2020 07:22:04 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 223C8C07FF; Thu, 28 May 2020 07:22:04 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 468F7C016F for ; Thu, 28 May 2020 07:22:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3E879888F8 for ; Thu, 28 May 2020 07:22:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CDMMf9wgUe6t for ; Thu, 28 May 2020 07:22:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by hemlock.osuosl.org (Postfix) with ESMTPS id 4186388888 for ; Thu, 28 May 2020 07:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590650519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=UkueWRj7YHIxLvaz11ZyjhAJXikivu4+C4al5kopX4kyrEP9h9b9q7UzuUi4WkHe2aiutG sxn/+OC73k24yFDBfDfOkDFurk+s03wz1whhjDCyxt9+sCEtocczrExW6m6Hk8D/WyCimL oGnQva+gunXGVQbqan1fZ7f53aVeZ3w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-coeiy8M4OwqtVw4hX2GvfQ-1; Thu, 28 May 2020 03:21:55 -0400 X-MC-Unique: coeiy8M4OwqtVw4hX2GvfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCF0C107ACCD; Thu, 28 May 2020 07:21:53 +0000 (UTC) Received: from [10.36.113.56] (ovpn-113-56.ams2.redhat.com [10.36.113.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8AA410013DB; Thu, 28 May 2020 07:21:48 +0000 (UTC) Subject: Re: [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address To: Robin Murphy , Srinath Mannam , Will Deacon , Joerg Roedel References: <1590595398-4217-1-git-send-email-srinath.mannam@broadcom.com> From: Auger Eric Message-ID: <8de9d9dd-16f9-482b-0ecf-f2f103ede86b@redhat.com> Date: Thu, 28 May 2020 09:21:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Cc: Jean-Philippe Brucker , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alex Williamson , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGksCgpPbiA1LzI3LzIwIDc6MzAgUE0sIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAyMDIwLTA1 LTI3IDE3OjAzLCBTcmluYXRoIE1hbm5hbSB3cm90ZToKPj4gVGhpcyBwYXRjaCBnaXZlcyB0aGUg cHJvdmlzaW9uIHRvIGNoYW5nZSBkZWZhdWx0IHZhbHVlIG9mIE1TSSBJT1ZBIGJhc2UKPj4gdG8g cGxhdGZvcm0ncyBzdWl0YWJsZSBJT1ZBIHVzaW5nIG1vZHVsZSBwYXJhbWV0ZXIuIFRoZSBwcmVz ZW50Cj4+IGhhcmRjb2RlZCBNU0kgSU9WQSBiYXNlIG1heSBub3QgYmUgdGhlIGFjY2Vzc2libGUg SU9WQSByYW5nZXMgb2YKPj4gcGxhdGZvcm0uCj4gCj4gVGhhdCBpbiBpdHNlbGYgZG9lc24ndCBz ZWVtIGVudGlyZWx5IHVucmVhc29uYWJsZTsgSUlSQyB0aGUgY3VycmVudAo+IGFkZHJlc3MgaXMg anVzdCBhbiBhcmJpdHJhcnkgY2hvaWNlIHRvIGZpdCBuaWNlbHkgaW50byBRZW11J3MgbWVtb3J5 Cj4gbWFwLApjb3JyZWN0CiBhbmQgdGhlcmUgd2FzIGFsd2F5cyB0aGUgcG9zc2liaWxpdHkgdGhh dCBpdCB3b3VsZG4ndCBzdWl0IGV2ZXJ5dGhpbmcuCgpJbmRlZWQgSSBhbHNvIHJlY2VudGx5IGhh ZCB0aGlzIGNhc2Ugb2YgUENJIGhvc3QgYnJpZGdlIGNvbGxpc2lvbiB3aXRoCnRoZSBTVyBNU0kg cmVzZXJ2ZWQgd2luZG93IC0gbWF5YmUgdGhhdCdzIHRoZSBzYW1lIDstKSAtLgo+IAo+PiBTaW5j ZSBjb21taXQgYWFkYWQwOTdjZDQ2ICgiaW9tbXUvZG1hOiBSZXNlcnZlIElPVkEgZm9yIFBDSWUg aW5hY2Nlc3NpYmxlCj4+IERNQSBhZGRyZXNzIiksIGluYWNjZXNzaWJsZSBJT1ZBIGFkZHJlc3Mg cmFuZ2VzIHBhcnNlZCBmcm9tIGRtYS1yYW5nZXMKPj4gcHJvcGVydHkgYXJlIHJlc2VydmVkLgo+ IAo+IFRoYXQsIGhvd2V2ZXIsIGRvZXNuJ3Qgc2VlbSB0byBmaXQgaGVyZTsgaW9tbXUtZG1hIG1h cHMgTVNJIGRvb3JiZWxscwo+IGR5bmFtaWNhbGx5LCBzbyB0aGV5IGFyZW4ndCBhZmZlY3RlZCBi eSByZXNlcnZlZCByZWdpb25zIGFueSBtb3JlIHRoYW4KPiByZWd1bGFyIERNQSBwYWdlcyBhcmUu IEluIGZhY3QsIGl0IGV4cGxpY2l0bHkgaWdub3JlcyB0aGUgc29mdHdhcmUgTVNJCj4gcmVnaW9u LCBzaW5jZSBhcyB0aGUgY29tbWVudCBzYXlzLCBpdCAqaXMqIHRoZSBzb2Z0d2FyZSB0aGF0IG1h bmFnZXMgdGhvc2UuCj4gCj4gVGhlIE1TSV9JT1ZBX0JBU0UgcmVnaW9uIGV4aXN0cyBmb3IgVkZJ TywgcHJlY2lzZWx5IGJlY2F1c2UgaW4gdGhhdCBjYXNlCj4gdGhlIGtlcm5lbCAqZG9lc24ndCog Y29udHJvbCB0aGUgYWRkcmVzcyBzcGFjZSwgYnV0IHN0aWxsIG5lZWRzIHNvbWUgd2F5Cj4gdG8g c3RlYWwgYSBiaXQgb2YgaXQgZm9yIE1TSXMgdGhhdCB0aGUgZ3Vlc3QgZG9lc24ndCBuZWNlc3Nh cmlseSBrbm93Cj4gYWJvdXQsIGFuZCBnaXZlIHVzZXJzcGFjZSBhIGZpZ2h0aW5nIGNoYW5jZSBv ZiBrbm93aW5nIHdoYXQgaXQncyB0YWtlbi4KPiBJIHRoaW5rIGF0IHRoZSB0aW1lIHdlIGRpc2N1 c3NlZCB0aGUgaWRlYSBvZiBhZGRpbmcgc29tZXRoaW5nIHRvIHRoZQo+IFZGSU8gdWFwaSBzdWNo IHRoYXQgdXNlcnNwYWNlIGNvdWxkIG1vdmUgdGhpcyBhcm91bmQgaWYgaXQgd2FudGVkIG9yCj4g bmVlZGVkIHRvLCBidXQgZGVjaWRlZCB3ZSBjb3VsZCBsaXZlIHdpdGhvdXQgdGhhdCBpbml0aWFs bHkuCgpZZXMgaW5kZWVkIDstKQoKIFBlcmhhcHMgbm93Cj4gdGhlIHRpbWUgaGFzIGNvbWU/CgpE byB5b3UgbWVhbiB5b3Ugd291bGQgd2VsY29tZSBhIFZGSU8gYmFzZWQgYXBwcm9hY2ggb3Igd291 bGQgYSBkcml2ZXIKcGFyYW1ldGVyIGJlIHN1ZmZpY2llbnQ/CgpUaGFua3MKCkVyaWMKCgo+IAo+ IFJvYmluLgo+IAo+PiBJZiBhbnkgcGxhdGZvcm0gaGFzIHRoZSBsaW1pdGFpb24gdG8gYWNjZXNz IGRlZmF1bHQgTVNJIElPVkEsIHRoZW4gaXQgY2FuCj4+IGJlIGNoYW5nZWQgdXNpbmcgImFybS1z bW11Lm1zaV9pb3ZhX2Jhc2U9MHhhMDAwMDAwMCIgY29tbWFuZCBsaW5lCj4+IGFyZ3VtZW50Lgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBTcmluYXRoIE1hbm5hbSA8c3JpbmF0aC5tYW5uYW1AYnJvYWRj b20uY29tPgo+PiAtLS0KPj4gwqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS5jIHwgNSArKysrLQo+ PiDCoCAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LmMgYi9kcml2ZXJzL2lvbW11L2Fy bS1zbW11LmMKPj4gaW5kZXggNGYxYTM1MC4uNWU1OWM5ZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9pb21tdS9hcm0tc21tdS5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUuYwo+PiBA QCAtNzIsNiArNzIsOSBAQCBzdGF0aWMgYm9vbCBkaXNhYmxlX2J5cGFzcyA9Cj4+IMKgIG1vZHVs ZV9wYXJhbShkaXNhYmxlX2J5cGFzcywgYm9vbCwgU19JUlVHTyk7Cj4+IMKgIE1PRFVMRV9QQVJN X0RFU0MoZGlzYWJsZV9ieXBhc3MsCj4+IMKgwqDCoMKgwqAgIkRpc2FibGUgYnlwYXNzIHN0cmVh bXMgc3VjaCB0aGF0IGluY29taW5nIHRyYW5zYWN0aW9ucyBmcm9tCj4+IGRldmljZXMgdGhhdCBh cmUgbm90IGF0dGFjaGVkIHRvIGFuIGlvbW11IGRvbWFpbiB3aWxsIHJlcG9ydCBhbiBhYm9ydAo+ PiBiYWNrIHRvIHRoZSBkZXZpY2UgYW5kIHdpbGwgbm90IGJlIGFsbG93ZWQgdG8gcGFzcyB0aHJv dWdoIHRoZSBTTU1VLiIpOwo+PiArc3RhdGljIHVuc2lnbmVkIGxvbmcgbXNpX2lvdmFfYmFzZSA9 IE1TSV9JT1ZBX0JBU0U7Cj4+ICttb2R1bGVfcGFyYW0obXNpX2lvdmFfYmFzZSwgdWxvbmcsIFNf SVJVR08pOwo+PiArTU9EVUxFX1BBUk1fREVTQyhtc2lfaW92YV9iYXNlLCAibXNpIGlvdmEgYmFz ZSBhZGRyZXNzLiIpOwo+PiDCoCDCoCBzdHJ1Y3QgYXJtX3NtbXVfczJjciB7Cj4+IMKgwqDCoMKg wqAgc3RydWN0IGlvbW11X2dyb3VwwqDCoMKgwqDCoMKgwqAgKmdyb3VwOwo+PiBAQCAtMTU2Niw3 ICsxNTY5LDcgQEAgc3RhdGljIHZvaWQgYXJtX3NtbXVfZ2V0X3Jlc3ZfcmVnaW9ucyhzdHJ1Y3QK Pj4gZGV2aWNlICpkZXYsCj4+IMKgwqDCoMKgwqAgc3RydWN0IGlvbW11X3Jlc3ZfcmVnaW9uICpy ZWdpb247Cj4+IMKgwqDCoMKgwqAgaW50IHByb3QgPSBJT01NVV9XUklURSB8IElPTU1VX05PRVhF QyB8IElPTU1VX01NSU87Cj4+IMKgIC3CoMKgwqAgcmVnaW9uID0gaW9tbXVfYWxsb2NfcmVzdl9y ZWdpb24oTVNJX0lPVkFfQkFTRSwgTVNJX0lPVkFfTEVOR1RILAo+PiArwqDCoMKgIHJlZ2lvbiA9 IGlvbW11X2FsbG9jX3Jlc3ZfcmVnaW9uKG1zaV9pb3ZhX2Jhc2UsIE1TSV9JT1ZBX0xFTkdUSCwK Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJvdCwgSU9N TVVfUkVTVl9TV19NU0kpOwo+PiDCoMKgwqDCoMKgIGlmICghcmVnaW9uKQo+PiDCoMKgwqDCoMKg wqDCoMKgwqAgcmV0dXJuOwo+Pgo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5k YXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279DCC433DF for ; Thu, 28 May 2020 07:22:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B55207BC for ; Thu, 28 May 2020 07:22:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IoJqI5qI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="o2mngaR/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KgZbRJWm"; dkim=neutral (0-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+/NXMFl"; dkim=neutral (0-bit key) header.d=redhat.com header.i=@redhat.com header.b="d5tFP94y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B55207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OJ0xjpRnp9XcKE/FNISPWvwVOraMs/nZ6oZxLV9Nreo=; b=IoJqI5qIwu77bQ vRGc1733oIi8BkWojvvCzv8rLs0kwP9PxdXVIiLyruurtm1eq0Y1anLfNksR0SMDDcTqdaiWT4rWI iDYyAK7lCzM56OOZs99RVw8KX3QxYSsbUhmPul5Is/1o0h46WcIEohPaMA+7rVdZPl70THJpvORgO Ccx5GIK/f3Ug5vpF8D/QQdNW0BghP9BAUZca/ihzOjEtci9fwpx5N/xJVt05QGZ6jxIIg1fPz4H/g CL0CD6MYWT6EV1uIbBMGP2EWl4HX7Ur+rswd7dI7ykiVI41M6LQ32ahWKBsLcSI6ghKc7FZw+Z57U 9Mp7XYhYefNHJ8Ne3mYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeCsQ-0007De-J9; Thu, 28 May 2020 07:22:54 +0000 Received: from merlin.infradead.org ([205.233.59.134]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeCsK-0007DM-Rf for linux-arm-kernel@bombadil.infradead.org; Thu, 28 May 2020 07:22:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=o2mngaR/2MbShS6tZY8tZnQ9FB 60lLTvJP8Q7Vf7WK/tCu0PrMX63qYTz8XJStgaXtRCPrSfETDSvCZeDXeBZxJzHFj1VHPVAYzUDJK QvyR10JKZ2Pc6gPHZAKaSxT7WMKl5tV8VdQJWhTrpl2UJYeBB+0ivMm/vbGXUUkUrpkM8QPiRAnpL 8QdCa4KiDN8NYTmJPxRrO9LJkNOvkjFAHgEUbGeeGlsNF+JPo/Gbl7ZmgCfeLCmyUggmjc8w3HxhJ UR+mFspRc59u9rWyZiw+cPTaSJ46FMtkSOri7Ln4HABy12Urdk35N8jiYP2SsPN4ORTc+umY2TscS 3QoNpCSg==; Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeCsH-0007H1-02 for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 07:22:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590650517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=KgZbRJWmJOOTW8jTKbf6lqP3lTKEobDoLRc0+EYDE1JF68OXGYG+IJ3XSkcU9g+E6LgMZa 4fvIqfuXB4+VPbYcA4Jha+Kw/vqc8rf9V6TBhyRPzmrXM8PUWA2DtsfNDztmNYXaRLpr5J ygg6nwLbYlAXcVNL2RcwlzvtwtaYATg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590650539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=i+/NXMFlqj+0vGByx4olXzLFYpsIIoZeXm+LAv82iLLJut9OWRITkK0eSZwWdvyAdzE3Wh 8wSWxrDUZg9KB2yVhosr2wv28lOGGXNB641+Iy4nekL7jrp02Rru2yglOjyfnl3lUaWbyj SD9udv+oj7a2YlDQ2P9eXouB3js1A7Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590650563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEBM0q4fZKyfjw7D1kyoHM1xb9sriIyKbIiYsNtDAYk=; b=d5tFP94yczCIRH4wOF7CP+EpribSr7UbPAfxnvRi+k61kqsi2R4D3Y4oQv+QxLCSqG7nAq hHoneiT650JwqhFHJXCDIlb9tn0ftfnmO91/jY47BJh5e0ml1MV8OZCVE/5gRc4OlzQjEA sDj4tjGEzdLQc1Fdf3SgMZFS7Qno0W0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-coeiy8M4OwqtVw4hX2GvfQ-1; Thu, 28 May 2020 03:21:55 -0400 X-MC-Unique: coeiy8M4OwqtVw4hX2GvfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCF0C107ACCD; Thu, 28 May 2020 07:21:53 +0000 (UTC) Received: from [10.36.113.56] (ovpn-113-56.ams2.redhat.com [10.36.113.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8AA410013DB; Thu, 28 May 2020 07:21:48 +0000 (UTC) Subject: Re: [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address To: Robin Murphy , Srinath Mannam , Will Deacon , Joerg Roedel References: <1590595398-4217-1-git-send-email-srinath.mannam@broadcom.com> From: Auger Eric Message-ID: <8de9d9dd-16f9-482b-0ecf-f2f103ede86b@redhat.com> Date: Thu, 28 May 2020 09:21:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alex Williamson , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiA1LzI3LzIwIDc6MzAgUE0sIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAyMDIwLTA1 LTI3IDE3OjAzLCBTcmluYXRoIE1hbm5hbSB3cm90ZToKPj4gVGhpcyBwYXRjaCBnaXZlcyB0aGUg cHJvdmlzaW9uIHRvIGNoYW5nZSBkZWZhdWx0IHZhbHVlIG9mIE1TSSBJT1ZBIGJhc2UKPj4gdG8g cGxhdGZvcm0ncyBzdWl0YWJsZSBJT1ZBIHVzaW5nIG1vZHVsZSBwYXJhbWV0ZXIuIFRoZSBwcmVz ZW50Cj4+IGhhcmRjb2RlZCBNU0kgSU9WQSBiYXNlIG1heSBub3QgYmUgdGhlIGFjY2Vzc2libGUg SU9WQSByYW5nZXMgb2YKPj4gcGxhdGZvcm0uCj4gCj4gVGhhdCBpbiBpdHNlbGYgZG9lc24ndCBz ZWVtIGVudGlyZWx5IHVucmVhc29uYWJsZTsgSUlSQyB0aGUgY3VycmVudAo+IGFkZHJlc3MgaXMg anVzdCBhbiBhcmJpdHJhcnkgY2hvaWNlIHRvIGZpdCBuaWNlbHkgaW50byBRZW11J3MgbWVtb3J5 Cj4gbWFwLApjb3JyZWN0CiBhbmQgdGhlcmUgd2FzIGFsd2F5cyB0aGUgcG9zc2liaWxpdHkgdGhh dCBpdCB3b3VsZG4ndCBzdWl0IGV2ZXJ5dGhpbmcuCgpJbmRlZWQgSSBhbHNvIHJlY2VudGx5IGhh ZCB0aGlzIGNhc2Ugb2YgUENJIGhvc3QgYnJpZGdlIGNvbGxpc2lvbiB3aXRoCnRoZSBTVyBNU0kg cmVzZXJ2ZWQgd2luZG93IC0gbWF5YmUgdGhhdCdzIHRoZSBzYW1lIDstKSAtLgo+IAo+PiBTaW5j ZSBjb21taXQgYWFkYWQwOTdjZDQ2ICgiaW9tbXUvZG1hOiBSZXNlcnZlIElPVkEgZm9yIFBDSWUg aW5hY2Nlc3NpYmxlCj4+IERNQSBhZGRyZXNzIiksIGluYWNjZXNzaWJsZSBJT1ZBIGFkZHJlc3Mg cmFuZ2VzIHBhcnNlZCBmcm9tIGRtYS1yYW5nZXMKPj4gcHJvcGVydHkgYXJlIHJlc2VydmVkLgo+ IAo+IFRoYXQsIGhvd2V2ZXIsIGRvZXNuJ3Qgc2VlbSB0byBmaXQgaGVyZTsgaW9tbXUtZG1hIG1h cHMgTVNJIGRvb3JiZWxscwo+IGR5bmFtaWNhbGx5LCBzbyB0aGV5IGFyZW4ndCBhZmZlY3RlZCBi eSByZXNlcnZlZCByZWdpb25zIGFueSBtb3JlIHRoYW4KPiByZWd1bGFyIERNQSBwYWdlcyBhcmUu IEluIGZhY3QsIGl0IGV4cGxpY2l0bHkgaWdub3JlcyB0aGUgc29mdHdhcmUgTVNJCj4gcmVnaW9u LCBzaW5jZSBhcyB0aGUgY29tbWVudCBzYXlzLCBpdCAqaXMqIHRoZSBzb2Z0d2FyZSB0aGF0IG1h bmFnZXMgdGhvc2UuCj4gCj4gVGhlIE1TSV9JT1ZBX0JBU0UgcmVnaW9uIGV4aXN0cyBmb3IgVkZJ TywgcHJlY2lzZWx5IGJlY2F1c2UgaW4gdGhhdCBjYXNlCj4gdGhlIGtlcm5lbCAqZG9lc24ndCog Y29udHJvbCB0aGUgYWRkcmVzcyBzcGFjZSwgYnV0IHN0aWxsIG5lZWRzIHNvbWUgd2F5Cj4gdG8g c3RlYWwgYSBiaXQgb2YgaXQgZm9yIE1TSXMgdGhhdCB0aGUgZ3Vlc3QgZG9lc24ndCBuZWNlc3Nh cmlseSBrbm93Cj4gYWJvdXQsIGFuZCBnaXZlIHVzZXJzcGFjZSBhIGZpZ2h0aW5nIGNoYW5jZSBv ZiBrbm93aW5nIHdoYXQgaXQncyB0YWtlbi4KPiBJIHRoaW5rIGF0IHRoZSB0aW1lIHdlIGRpc2N1 c3NlZCB0aGUgaWRlYSBvZiBhZGRpbmcgc29tZXRoaW5nIHRvIHRoZQo+IFZGSU8gdWFwaSBzdWNo IHRoYXQgdXNlcnNwYWNlIGNvdWxkIG1vdmUgdGhpcyBhcm91bmQgaWYgaXQgd2FudGVkIG9yCj4g bmVlZGVkIHRvLCBidXQgZGVjaWRlZCB3ZSBjb3VsZCBsaXZlIHdpdGhvdXQgdGhhdCBpbml0aWFs bHkuCgpZZXMgaW5kZWVkIDstKQoKIFBlcmhhcHMgbm93Cj4gdGhlIHRpbWUgaGFzIGNvbWU/CgpE byB5b3UgbWVhbiB5b3Ugd291bGQgd2VsY29tZSBhIFZGSU8gYmFzZWQgYXBwcm9hY2ggb3Igd291 bGQgYSBkcml2ZXIKcGFyYW1ldGVyIGJlIHN1ZmZpY2llbnQ/CgpUaGFua3MKCkVyaWMKCgo+IAo+ IFJvYmluLgo+IAo+PiBJZiBhbnkgcGxhdGZvcm0gaGFzIHRoZSBsaW1pdGFpb24gdG8gYWNjZXNz IGRlZmF1bHQgTVNJIElPVkEsIHRoZW4gaXQgY2FuCj4+IGJlIGNoYW5nZWQgdXNpbmcgImFybS1z bW11Lm1zaV9pb3ZhX2Jhc2U9MHhhMDAwMDAwMCIgY29tbWFuZCBsaW5lCj4+IGFyZ3VtZW50Lgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBTcmluYXRoIE1hbm5hbSA8c3JpbmF0aC5tYW5uYW1AYnJvYWRj b20uY29tPgo+PiAtLS0KPj4gwqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS5jIHwgNSArKysrLQo+ PiDCoCAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LmMgYi9kcml2ZXJzL2lvbW11L2Fy bS1zbW11LmMKPj4gaW5kZXggNGYxYTM1MC4uNWU1OWM5ZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9pb21tdS9hcm0tc21tdS5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUuYwo+PiBA QCAtNzIsNiArNzIsOSBAQCBzdGF0aWMgYm9vbCBkaXNhYmxlX2J5cGFzcyA9Cj4+IMKgIG1vZHVs ZV9wYXJhbShkaXNhYmxlX2J5cGFzcywgYm9vbCwgU19JUlVHTyk7Cj4+IMKgIE1PRFVMRV9QQVJN X0RFU0MoZGlzYWJsZV9ieXBhc3MsCj4+IMKgwqDCoMKgwqAgIkRpc2FibGUgYnlwYXNzIHN0cmVh bXMgc3VjaCB0aGF0IGluY29taW5nIHRyYW5zYWN0aW9ucyBmcm9tCj4+IGRldmljZXMgdGhhdCBh cmUgbm90IGF0dGFjaGVkIHRvIGFuIGlvbW11IGRvbWFpbiB3aWxsIHJlcG9ydCBhbiBhYm9ydAo+ PiBiYWNrIHRvIHRoZSBkZXZpY2UgYW5kIHdpbGwgbm90IGJlIGFsbG93ZWQgdG8gcGFzcyB0aHJv dWdoIHRoZSBTTU1VLiIpOwo+PiArc3RhdGljIHVuc2lnbmVkIGxvbmcgbXNpX2lvdmFfYmFzZSA9 IE1TSV9JT1ZBX0JBU0U7Cj4+ICttb2R1bGVfcGFyYW0obXNpX2lvdmFfYmFzZSwgdWxvbmcsIFNf SVJVR08pOwo+PiArTU9EVUxFX1BBUk1fREVTQyhtc2lfaW92YV9iYXNlLCAibXNpIGlvdmEgYmFz ZSBhZGRyZXNzLiIpOwo+PiDCoCDCoCBzdHJ1Y3QgYXJtX3NtbXVfczJjciB7Cj4+IMKgwqDCoMKg wqAgc3RydWN0IGlvbW11X2dyb3VwwqDCoMKgwqDCoMKgwqAgKmdyb3VwOwo+PiBAQCAtMTU2Niw3 ICsxNTY5LDcgQEAgc3RhdGljIHZvaWQgYXJtX3NtbXVfZ2V0X3Jlc3ZfcmVnaW9ucyhzdHJ1Y3QK Pj4gZGV2aWNlICpkZXYsCj4+IMKgwqDCoMKgwqAgc3RydWN0IGlvbW11X3Jlc3ZfcmVnaW9uICpy ZWdpb247Cj4+IMKgwqDCoMKgwqAgaW50IHByb3QgPSBJT01NVV9XUklURSB8IElPTU1VX05PRVhF QyB8IElPTU1VX01NSU87Cj4+IMKgIC3CoMKgwqAgcmVnaW9uID0gaW9tbXVfYWxsb2NfcmVzdl9y ZWdpb24oTVNJX0lPVkFfQkFTRSwgTVNJX0lPVkFfTEVOR1RILAo+PiArwqDCoMKgIHJlZ2lvbiA9 IGlvbW11X2FsbG9jX3Jlc3ZfcmVnaW9uKG1zaV9pb3ZhX2Jhc2UsIE1TSV9JT1ZBX0xFTkdUSCwK Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJvdCwgSU9N TVVfUkVTVl9TV19NU0kpOwo+PiDCoMKgwqDCoMKgIGlmICghcmVnaW9uKQo+PiDCoMKgwqDCoMKg wqDCoMKgwqAgcmV0dXJuOwo+Pgo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK