From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B896BC433ED for ; Fri, 16 Apr 2021 00:59:07 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 05FD561002 for ; Fri, 16 Apr 2021 00:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05FD561002 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D155F1624C4; Fri, 16 Apr 2021 02:59:05 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id B06B140140 for ; Fri, 16 Apr 2021 02:59:04 +0200 (CEST) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FLySl4rDpzPqnK; Fri, 16 Apr 2021 08:56:07 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Fri, 16 Apr 2021 08:59:00 +0800 To: , dev , Ferruh Yigit References: <1616670560-62333-1-git-send-email-oulijun@huawei.com> <1618454426-21457-1-git-send-email-oulijun@huawei.com> <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> <9356626.RYGqZy0Vls@thomas> From: oulijun Message-ID: <8ded3a05-65b8-25b4-f10e-39cabe98603e@huawei.com> Date: Fri, 16 Apr 2021 08:58:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [Linuxarm] Re: [PATCH V3] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/15 20:45, Ferruh Yigit 写道: > On 4/15/2021 1:36 PM, Thomas Monjalon wrote: >> 15/04/2021 14:33, Ferruh Yigit: >>> On 4/15/2021 3:40 AM, Lijun Ou wrote: >>>> Currently, upper-layer application could get queue state only >>>> through pointers such as dev->data->tx_queue_state[queue_id], >>>> this is not the recommended way to access it. So this patch >>>> add get queue state when call rte_eth_rx_queue_info_get and >>>> rte_eth_tx_queue_info_get API. >>>> >>>> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >>>> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >>>> it could be ABI compatible. >>>> >>>> Signed-off-by: Chengwen Feng >>>> Signed-off-by: Lijun Ou >>> >>> Looks good to me, but it is causing an ABI error as we already >>> discussed before >>> as that is false positive. >>> >>> >>> Ray, David, >>> >>> Should we add any exception to libabigail.abignore for this? >> >> We do not tolerate any ABI warning. >> If we are sure the ABI change is false positive, >> it must be suppressed in libabigail.abignore in the same patch. >> > > A new field is added to public structs, but struct size or the location > of the existing fields are not changing (struct is cache aligned). > > Can you please support how this can be added to 'libabigail.abignore'? > > Lijun can you please send a new version with 'libabigail.abignore' update? > Yes, I can do that. But at the moment I don't know how to update libabigil.abinore. I don't know where to modify Is there any relevant documentation? > Thanks, > ferruh > _______________________________________________ > Linuxarm mailing list -- linuxarm@openeuler.org > To unsubscribe send an email to linuxarm-leave@openeuler.org