From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6216CC433F5 for ; Sun, 17 Apr 2022 19:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234907AbiDQTWp (ORCPT ); Sun, 17 Apr 2022 15:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232144AbiDQTWn (ORCPT ); Sun, 17 Apr 2022 15:22:43 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DC0162D2 for ; Sun, 17 Apr 2022 12:20:07 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id x33so21486791lfu.1 for ; Sun, 17 Apr 2022 12:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=; b=anmuYIHMR44DHUBsKUVkyea2mPIgGJA1WVaLfL42XbsYHNLQ0QX5zF1vmXuveOfZa4 TlIHgkTCOoYjOOVnzvPRkPqi+LYsmZYW7I9daLrolOUzGvJlP00NxPg1O42tKDiJdj3F W9UfoOoRhm9POPkypEpow7p+m6+WvsPwt0uKdYh6rfDXjumAupEnI2eqJ5bvdLrMXSrC Cydz5opZP1kh8wO33oIdvdQNglyjqHQLYMwCMFJqbSQLDJLtzHIrpnxoZKpVTXJ6x3oS ln3RXLd9fG/Z8R9g6sIQ9UgqXuc/KTif0O4MOzEsU4QUu9/7gdRIRnOzt0xx7Xe7vU1v 3hVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=; b=pGNA3JB767d77WW52sF7A4xhYsx4M8BqQNaF/ZVD3MaNTuWvz//11fGAmiCKw6fu9o 4bgXcT/IileL2xmosB1ffIy9phFWZpbcTdEzSY0iRvPyI/3/nnjE+YtJ2CF4w6X82k74 ff1epwBM8oQQLs24gq27ySWfX/tnoB8bdjy0mQKD76PDbSH3NOgN5WRsZr4vAv58zUMf mVJ29dMDZatgP/4AeW7rPgY1S7o1IMSxVeh+L92VPkF/mPt2ExAPMACWTmz8FMIhEBAn BTopJCJTzj4FtH/2V/JQeMPbcFDUEwUfEULDHwMy0fZAjvIx/v7XO5d41BpTSFeZHrPH FEXA== X-Gm-Message-State: AOAM531OtGVmYKhsLsUZt+UolUiej3TnYXA41fg790nscM89A5iK+H0g 9JuBzdqb+Mpgw2jjMrG/hJY= X-Google-Smtp-Source: ABdhPJwipgGgKdPerX/TjaWsmOWeRcT7lQlBUqHmoX8ARPDdhaoRZak1gHU/2o+0U1HoS6YY+cJbTA== X-Received: by 2002:a05:6512:c21:b0:471:9935:f8f2 with SMTP id z33-20020a0565120c2100b004719935f8f2mr35608lfu.650.1650223205568; Sun, 17 Apr 2022 12:20:05 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id f3-20020a056512322300b0046bbce218f2sm1005348lfe.79.2022.04.17.12.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 12:20:05 -0700 (PDT) Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <8df1dc60-614a-67fa-3a9d-e2db4a7e0132@gmail.com> Date: Sun, 17 Apr 2022 22:20:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.04.22 01:02, Stefano Stabellini wrote: Hello Stefano > On Thu, 14 Apr 2022, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Call xen_virtio_setup_dma_ops() only for Xen-aware virtio devices >> in Xen guests if restricted access to the guest memory is enabled. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> include/xen/arm/xen-ops.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h >> index 621da05..28b2ad3 100644 >> --- a/include/xen/arm/xen-ops.h >> +++ b/include/xen/arm/xen-ops.h >> @@ -2,12 +2,19 @@ >> #ifndef _ASM_ARM_XEN_OPS_H >> #define _ASM_ARM_XEN_OPS_H >> >> +#include >> #include >> +#include >> >> static inline void xen_setup_dma_ops(struct device *dev) >> { >> if (xen_swiotlb_detect()) >> dev->dma_ops = &xen_swiotlb_dma_ops; >> + >> +#ifdef CONFIG_XEN_VIRTIO >> + if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev)) >> + xen_virtio_setup_dma_ops(dev); >> +#endif > This makes sense overall. thank you > Considering that the swiotlb-xen case and the > virtio case are mutually exclusive, I would write it like this: > > if (arch_has_restricted_virtio_memory_access() && xen_is_virtio_device(dev)) > xen_virtio_setup_dma_ops(dev); > else if (xen_swiotlb_detect()) > dev->dma_ops = &xen_swiotlb_dma_ops; Agree, will do > > There is no need for #ifdef (also see other comments). Agree, if !CONFIG_XEN_VIRTIO then xen_virtio_ are just stubs. #ifdef CONFIG_XEN_VIRTIO void xen_virtio_setup_dma_ops(struct device *dev); bool xen_is_virtio_device(struct device *dev); #else static inline void xen_virtio_setup_dma_ops(struct device *dev) { } static inline bool xen_is_virtio_device(struct device *dev) {     return false; } #endif /* CONFIG_XEN_VIRTIO */ -- Regards, Oleksandr Tyshchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36F34C433EF for ; Sun, 17 Apr 2022 19:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u+iPXZe/kv57EZQt8GTZy1P6YhchRuDxyea4O49r59I=; b=1WR9IhmgLbnazUrFnEzZqI4FF0 82HGHNn7J259IbGyBVw/umEHUCrtPzeVVQTRzny4dcNA31ZQb6n1aTk5CJO6Y8tzAZKFZj8+Fv3BO YskFRpbzbwl3jowt7qOU3RxfujwBoyXQ/n/2BJnYZuQNwqpwqQjot/9As24gRIti020G3/Zo/fLB1 YkSKvwp2EHFkIER53SQLVSFBZ5w+ndeEzRV3fRoL2jqUyrDxbTv+1Bwvhzmy1DExGYBFem8SvX4iX ppnwgQBJTNgMq5jFSY0CKXHkTG6qShUsoceBuNLcgUBbZLo9gxGwOtgzjFC0bCxowsUfWcAUKV/LV JiObKlfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngARO-00ErLg-Dn; Sun, 17 Apr 2022 19:20:10 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngARL-00ErJq-9i for linux-arm-kernel@lists.infradead.org; Sun, 17 Apr 2022 19:20:08 +0000 Received: by mail-lf1-x134.google.com with SMTP id o2so21395296lfu.13 for ; Sun, 17 Apr 2022 12:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=; b=anmuYIHMR44DHUBsKUVkyea2mPIgGJA1WVaLfL42XbsYHNLQ0QX5zF1vmXuveOfZa4 TlIHgkTCOoYjOOVnzvPRkPqi+LYsmZYW7I9daLrolOUzGvJlP00NxPg1O42tKDiJdj3F W9UfoOoRhm9POPkypEpow7p+m6+WvsPwt0uKdYh6rfDXjumAupEnI2eqJ5bvdLrMXSrC Cydz5opZP1kh8wO33oIdvdQNglyjqHQLYMwCMFJqbSQLDJLtzHIrpnxoZKpVTXJ6x3oS ln3RXLd9fG/Z8R9g6sIQ9UgqXuc/KTif0O4MOzEsU4QUu9/7gdRIRnOzt0xx7Xe7vU1v 3hVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UX+UJJi6cm6n3siakzXlqA7VdWeUuC0amPEI0CKnoy8=; b=Fd2hZKOJwBWznbV4PnWMYrfr9nDTrP6N5mRFSuRYimY7c2Z9BpReCI835kDdaKbWaM 8ue9L3vVOn+OA862uhizKqBowfcTzGLis2+BI8WJMoJw6GgCVRmV19Sth1WA3366IS+M fLo097LuKu0iS+0d585Zm+k8WKAIJ07WgEoAKF06BKHizAej/m0SZBRnZL+HFRUzqDC6 R9zxeaXu8sb7wnH26m/meTJsycJwLhVmNhgZJkCIangc+4Hw5IvQru+P9iLwA5KfyBv3 WNmCTYzXEIaoKBfwX4/QAuO7o23imMtdM/8wUJIWppMASLvdXkXD+NdvfBT4iJoyz2L4 IYbQ== X-Gm-Message-State: AOAM531A8hi6J7K+YFrc2hkoWF+lE/uKewbWuaGKt7b/pFiYn5g6LUOz //6Cfum5UrEUx0eoBqrZ42PdrSWbwDw= X-Google-Smtp-Source: ABdhPJwipgGgKdPerX/TjaWsmOWeRcT7lQlBUqHmoX8ARPDdhaoRZak1gHU/2o+0U1HoS6YY+cJbTA== X-Received: by 2002:a05:6512:c21:b0:471:9935:f8f2 with SMTP id z33-20020a0565120c2100b004719935f8f2mr35608lfu.650.1650223205568; Sun, 17 Apr 2022 12:20:05 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id f3-20020a056512322300b0046bbce218f2sm1005348lfe.79.2022.04.17.12.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 12:20:05 -0700 (PDT) Subject: Re: [RFC PATCH 6/6] arm/xen: Assign xen-virtio DMA ops for virtio devices in Xen guests To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> <1649963973-22879-7-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <8df1dc60-614a-67fa-3a9d-e2db4a7e0132@gmail.com> Date: Sun, 17 Apr 2022 22:20:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_122007_380751_6E5CDA7E X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDE2LjA0LjIyIDAxOjAyLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6CgoKSGVsbG8gU3Rl ZmFubwoKPiBPbiBUaHUsIDE0IEFwciAyMDIyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToK Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0u Y29tPgo+Pgo+PiBDYWxsIHhlbl92aXJ0aW9fc2V0dXBfZG1hX29wcygpIG9ubHkgZm9yIFhlbi1h d2FyZSB2aXJ0aW8gZGV2aWNlcwo+PiBpbiBYZW4gZ3Vlc3RzIGlmIHJlc3RyaWN0ZWQgYWNjZXNz IHRvIHRoZSBndWVzdCBtZW1vcnkgaXMgZW5hYmxlZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogT2xl a3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPgo+PiAtLS0K Pj4gICBpbmNsdWRlL3hlbi9hcm0veGVuLW9wcy5oIHwgNyArKysrKysrCj4+ICAgMSBmaWxlIGNo YW5nZWQsIDcgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS94ZW4vYXJt L3hlbi1vcHMuaCBiL2luY2x1ZGUveGVuL2FybS94ZW4tb3BzLmgKPj4gaW5kZXggNjIxZGEwNS4u MjhiMmFkMyAxMDA2NDQKPj4gLS0tIGEvaW5jbHVkZS94ZW4vYXJtL3hlbi1vcHMuaAo+PiArKysg Yi9pbmNsdWRlL3hlbi9hcm0veGVuLW9wcy5oCj4+IEBAIC0yLDEyICsyLDE5IEBACj4+ICAgI2lm bmRlZiBfQVNNX0FSTV9YRU5fT1BTX0gKPj4gICAjZGVmaW5lIF9BU01fQVJNX1hFTl9PUFNfSAo+ PiAgIAo+PiArI2luY2x1ZGUgPGxpbnV4L3ZpcnRpb19jb25maWcuaD4KPj4gICAjaW5jbHVkZSA8 eGVuL3N3aW90bGIteGVuLmg+Cj4+ICsjaW5jbHVkZSA8eGVuL3hlbi1vcHMuaD4KPj4gICAKPj4g ICBzdGF0aWMgaW5saW5lIHZvaWQgeGVuX3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2 KQo+PiAgIHsKPj4gICAJaWYgKHhlbl9zd2lvdGxiX2RldGVjdCgpKQo+PiAgIAkJZGV2LT5kbWFf b3BzID0gJnhlbl9zd2lvdGxiX2RtYV9vcHM7Cj4+ICsKPj4gKyNpZmRlZiBDT05GSUdfWEVOX1ZJ UlRJTwo+PiArCWlmIChhcmNoX2hhc19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKCkg JiYgeGVuX2lzX3ZpcnRpb19kZXZpY2UoZGV2KSkKPj4gKwkJeGVuX3ZpcnRpb19zZXR1cF9kbWFf b3BzKGRldik7Cj4+ICsjZW5kaWYKPiBUaGlzIG1ha2VzIHNlbnNlIG92ZXJhbGwuCgoKdGhhbmsg eW91CgoKPiBDb25zaWRlcmluZyB0aGF0IHRoZSBzd2lvdGxiLXhlbiBjYXNlIGFuZCB0aGUKPiB2 aXJ0aW8gY2FzZSBhcmUgbXV0dWFsbHkgZXhjbHVzaXZlLCBJIHdvdWxkIHdyaXRlIGl0IGxpa2Ug dGhpczoKPgo+IAlpZiAoYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcygp ICYmIHhlbl9pc192aXJ0aW9fZGV2aWNlKGRldikpCj4gCQl4ZW5fdmlydGlvX3NldHVwX2RtYV9v cHMoZGV2KTsKPiAJZWxzZSBpZiAoeGVuX3N3aW90bGJfZGV0ZWN0KCkpCj4gCQlkZXYtPmRtYV9v cHMgPSAmeGVuX3N3aW90bGJfZG1hX29wczsKCgpBZ3JlZSwgd2lsbCBkbwoKCj4KPiBUaGVyZSBp cyBubyBuZWVkIGZvciAjaWZkZWYgKGFsc28gc2VlIG90aGVyIGNvbW1lbnRzKS4KCgpBZ3JlZSwg aWYgIUNPTkZJR19YRU5fVklSVElPIHRoZW4geGVuX3ZpcnRpb18gYXJlIGp1c3Qgc3R1YnMuCgoK I2lmZGVmIENPTkZJR19YRU5fVklSVElPCnZvaWQgeGVuX3ZpcnRpb19zZXR1cF9kbWFfb3BzKHN0 cnVjdCBkZXZpY2UgKmRldik7CmJvb2wgeGVuX2lzX3ZpcnRpb19kZXZpY2Uoc3RydWN0IGRldmlj ZSAqZGV2KTsKI2Vsc2UKc3RhdGljIGlubGluZSB2b2lkIHhlbl92aXJ0aW9fc2V0dXBfZG1hX29w cyhzdHJ1Y3QgZGV2aWNlICpkZXYpCnsKfQpzdGF0aWMgaW5saW5lIGJvb2wgeGVuX2lzX3ZpcnRp b19kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQp7CiDCoMKgwqAgcmV0dXJuIGZhbHNlOwp9CiNl bmRpZiAvKiBDT05GSUdfWEVOX1ZJUlRJTyAqLwoKCgotLSAKUmVnYXJkcywKCk9sZWtzYW5kciBU eXNoY2hlbmtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=