From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F04C433FE for ; Wed, 3 Nov 2021 09:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D241061156 for ; Wed, 3 Nov 2021 09:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231964AbhKCJWC (ORCPT ); Wed, 3 Nov 2021 05:22:02 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:38900 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231240AbhKCJWB (ORCPT ); Wed, 3 Nov 2021 05:22:01 -0400 X-UUID: 81b2f125b4a4481993f1f838972f7b03-20211103 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FdCg3e0Gwi5y3/o458qrVWVoU7UhKyiLjyePMFkXn6E=; b=utOpz18/wQtiEKpwmNI7KOxcqS+RbDlTyqGnjgnswtKNLOYNRMUVR+6CZ5rGnIW44DzHfEAjSlX/XYEjZCO4MOe8uImCGe1bLR9zipuayjxLfJHt7sKKMzBGtSie39viC1utEIxTA8iMdayGZ5biXLPjjil+DR/+O4KeWhGjswU=; X-UUID: 81b2f125b4a4481993f1f838972f7b03-20211103 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 766378157; Wed, 03 Nov 2021 17:19:21 +0800 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 3 Nov 2021 17:19:21 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs10n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 3 Nov 2021 17:19:20 +0800 Message-ID: <8dfc07306b853126e8109fc953fd6388b63c65d2.camel@mediatek.com> Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: Irui Wang To: houlong wei , Dafna Hirschfeld , Alexandre Courbot , Hans Verkuil CC: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , LKML , "kernel@collabora.com" , Enric Balletbo i Serra , Dafna Hirschfeld , "Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?=" , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , Mauro Carvalho Chehab , Matthias Brugger Date: Wed, 3 Nov 2021 17:19:19 +0800 In-Reply-To: References: <20210920170408.1561-1-dafna.hirschfeld@collabora.com> <9475ac5b-79fe-da0e-ed1c-a91275cad46e@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksDQoNClRoZSAibGVuIiBvZiBzaGFyZV9idWYgY29waWVkIHNob3VsZCBiZSBhbHdheXMgOCBh bGlnbm1lbnQ7DQpkbyB5b3UgaGF2ZSBvdGhlciBsb2dzIHRvIHByb3ZlIHRoZSBsZW4gaXMgbm90 IDggYWxpZ25tZW50IHdoZW4gZXJyb3JzDQphcHBlYXI/IA0KPj4gWzU4LjM1MDg0MV0gbXRrLW1k cCAxNDAwMTAwMC5yZG1hOiBwcm9jZXNzaW5nIGZhaWxlZDogLTIyDQoNCk9uIFdlZCwgMjAyMS0x MS0wMyBhdCAxNjowMyArMDgwMCwgaG91bG9uZyB3ZWkgd3JvdGU6DQo+IEFkZCBtdGstdnB1IGRy aXZlciBleHBlcnQgaXJ1aS53YW5nIGluIHRoZSBsb29wLg0KPiANCj4gT24gTW9uLCAyMDIxLTEw LTE4IGF0IDE1OjA3ICswODAwLCBEYWZuYSBIaXJzY2hmZWxkIHdyb3RlOg0KPiA+IA0KPiA+IE9u IDE4LjEwLjIxIDAzOjE2LCBBbGV4YW5kcmUgQ291cmJvdCB3cm90ZToNCj4gPiA+IEhpIEhhbnMh DQo+ID4gPiANCj4gPiA+IE9uIE1vbiwgT2N0IDQsIDIwMjEgYXQgNjozNyBQTSBIYW5zIFZlcmt1 aWwgPGh2ZXJrdWlsQHhzNGFsbC5ubD4NCj4gPiA+IHdyb3RlOg0KPiA+ID4gPiANCj4gPiA+ID4g T24gMjAvMDkvMjAyMSAxOTowNCwgRGFmbmEgSGlyc2NoZmVsZCB3cm90ZToNCj4gPiA+ID4gPiBG cm9tOiBBbGV4YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAY2hyb21pdW0ub3JnPg0KPiA+ID4gPiA+ IA0KPiA+ID4gPiA+IFdoZW4gcnVubmluZyBtZW1jcHlfdG9pbzoNCj4gPiA+ID4gPiBtZW1jcHlf dG9pbyhzZW5kX29iai0+c2hhcmVfYnVmLCBidWYsIGxlbik7DQo+ID4gPiA+ID4gaXQgd2FzIGZv dW5kIHRoYXQgZXJyb3JzIGFwcGVhciBpZiBsZW4gaXMgbm90IGEgbXVsdGlwbGUgb2YNCj4gPiA+ ID4gPiA4Og0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IFs1OC4zNTA4NDFdIG10ay1tZHAgMTQwMDEw MDAucmRtYTogcHJvY2Vzc2luZyBmYWlsZWQ6IC0yMg0KPiA+ID4gPiANCj4gPiA+ID4gV2h5IGRv IGVycm9ycyBhcHBlYXI/IElzIHRoYXQgZHVlIHRvIGEgSFcgYnVnPyBTb21lIG90aGVyDQo+ID4g PiA+IHJlYXNvbj8NCj4gPiA+IA0KPiA+ID4gTVRLIGZvbGtzIHdvdWxkIGJlIHRoZSBiZXN0IHBs YWNlZCB0byBhbnN3ZXIgdGhpcywgYnV0IHNpbmNlIHRoZQ0KPiA+ID4gZmFpbHVyZSBpcyByZXBv cnRlZCBieSB0aGUgZmlybXdhcmUgSSdkIHN1c3BlY3QgZWl0aGVyIGEgZmlybXdhcmUNCj4gPiA+ IG9yDQo+ID4gPiBoYXJkd2FyZSBsaW1pdGF0aW9uLg0KPiA+ID4gDQo+ID4gPiA+IA0KPiA+ID4g PiA+IA0KPiA+ID4gPiA+IFRoaXMgcGF0Y2ggZW5zdXJlcyB0aGUgY29weSBvZiBhIG11bHRpcGxl IG9mIDggc2l6ZSBieQ0KPiA+ID4gPiA+IGNhbGxpbmcNCj4gPiA+ID4gPiByb3VuZF91cChsZW4s IDgpIHdoZW4gY29weWluZw0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IEZpeGVzOiBlNjU5OWFkZmFk MzAgKCJtZWRpYTogbXRrLXZwdTogYXZvaWQgdW5hbGlnbmVkIGFjY2Vzcw0KPiA+ID4gPiA+IHRv DQo+ID4gPiA+ID4gRFRDTSBidWZmZXIuIikNCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBbGV4 YW5kcmUgQ291cmJvdCA8YWNvdXJib3RAY2hyb21pdW0ub3JnPg0KPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPA0KPiA+ID4gPiA+IGVucmljLmJhbGxldGJv QGNvbGxhYm9yYS5jb20+DQo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRGFmbmEgSGlyc2NoZmVs ZCA8DQo+ID4gPiA+ID4gZGFmbmEuaGlyc2NoZmVsZEBjb2xsYWJvcmEuY29tDQo+ID4gPiA+ID4g PiANCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBSZXZpZXdlZC1ieTogSG91bG9uZyBXZWkgPGhvdWxv bmcud2VpQG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4gPiAtLS0NCj4gPiA+ID4gPiBjaGFuZ2VzIHNp bmNlIHYzOg0KPiA+ID4gPiA+IDEuIG11bHRpbGUgLT4gbXVsdGlwbGUNCj4gPiA+ID4gPiAyLiBh ZGQgaW5saW5lIGRvYw0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IGNoYW5nZXMgc2luY2UgdjI6DQo+ ID4gPiA+ID4gMS4gZG8gdGhlIGV4dHJhIGNvcHkgb25seSBpZiBsZW4gaXMgbm90IG11bHRpcGxl IG9mIDgNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBjaGFuZ2VzIHNpbmNlIHYxOg0KPiA+ID4gPiA+ IDEuIGNoYW5nZSBzaWduLW9mZi1ieSB0YWdzDQo+ID4gPiA+ID4gMi4gY2hhbmdlIHZhbHVlcyB0 byBtZW1zZXQNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0v bXRrLXZwdS9tdGtfdnB1LmMgfCAxNQ0KPiA+ID4gPiA+ICsrKysrKysrKysrKysrLQ0KPiA+ID4g PiA+ICAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4g PiA+ID4gPiANCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9t dGstdnB1L210a192cHUuYw0KPiA+ID4gPiA+IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGst dnB1L210a192cHUuYw0KPiA+ID4gPiA+IGluZGV4IGVjMjkwZGRlNTljZi4uMWRmMDMxNzE2Yzhm IDEwMDY0NA0KPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZwdS9t dGtfdnB1LmMNCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12cHUv bXRrX3ZwdS5jDQo+ID4gPiA+ID4gQEAgLTM0OSw3ICszNDksMjAgQEAgaW50IHZwdV9pcGlfc2Vu ZChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlDQo+ID4gPiA+ID4gKnBkZXYsDQo+ID4gPiA+ID4gICAg ICAgICAgICAgICAgfQ0KPiA+ID4gPiA+ICAgICAgICB9IHdoaWxlICh2cHVfY2ZnX3JlYWRsKHZw dSwgSE9TVF9UT19WUFUpKTsNCj4gPiA+ID4gPiANCj4gPiA+ID4gPiAtICAgICBtZW1jcHlfdG9p byhzZW5kX29iai0+c2hhcmVfYnVmLCBidWYsIGxlbik7DQo+ID4gPiA+ID4gKyAgICAgLyoNCj4g PiA+ID4gPiArICAgICAgKiB3aGVuIGNvcHlpbmcgZGF0YSB0byB0aGUgdnB1IGhhcmR3YXJlLCB0 aGUNCj4gPiA+ID4gPiBtZW1jcHlfdG9pbw0KPiA+ID4gPiA+IG9wZXJhdGlvbiBtdXN0IGNvcHkN Cj4gPiA+ID4gPiArICAgICAgKiBhIG11bHRpcGxlIG9mIDguIE90aGVyd2lzZSB0aGUgcHJvY2Vz c2luZyBmYWlscw0KPiA+ID4gPiANCj4gPiA+ID4gU2FtZSBoZXJlOiBpdCBuZWVkcyB0byBleHBs YWluIHdoeSB0aGUgcHJvY2Vzc2luZyBmYWlscy4NCj4gPiANCj4gPiBJcyB3cml0aW5nICdkdWUg dG8gaGFyZHdhcmUgb3IgZmlybXdhcmUgbGltaXRhdGlvbicgZW5vdWdoPw0KPiA+IElmIG5vdCwg dGhlbiB3ZSBzaG91bGQgd2FpdCBmb3IgbWVkaWF0ZWsgcGVvcGxlJ3MgcmVzcG9uc2UgdG8NCj4g PiBleHBsYWluDQo+ID4gaWYgdGhleSBrbm93IG1vcmUNCj4gPiANCj4gPiA+ID4gDQo+ID4gPiA+ ID4gKyAgICAgICovDQo+ID4gPiA+ID4gKyAgICAgaWYgKGxlbiAlIDggIT0gMCkgew0KPiA+ID4g PiA+ICsgICAgICAgICAgICAgdW5zaWduZWQgY2hhciBkYXRhW1NIQVJFX0JVRl9TSVpFXTsNCj4g PiA+ID4gDQo+ID4gPiA+IFdvdWxkbid0IGl0IGJlIG1vcmUgcm9idXN0IGlmIHlvdSBzYXk6DQo+ ID4gPiA+IA0KPiA+ID4gPiAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIgZGF0YVtzaXpl b2Yoc2VuZF9vYmotDQo+ID4gPiA+ID5zaGFyZV9idWYpXTsNCj4gPiA+IA0KPiA+ID4gRGVmaW5p dGVseSB5ZXMuDQo+ID4gDQo+ID4gSSdsbCBzZW5kIHY1IGZpeGluZyB0aGlzDQo+ID4gDQo+ID4g PiANCj4gPiA+ID4gDQo+ID4gPiA+IEkgYWxzbyB0aGluayB0aGF0IHRoZSBTSEFSRV9CVUZfU0la RSBkZWZpbmUgbmVlZHMgYSBjb21tZW50DQo+ID4gPiA+IHN0YXRpbmcgdGhhdCBpdCBtdXN0IGJl IGENCj4gPiA+ID4gbXVsdGlwbGUgb2YgOCwgb3RoZXJ3aXNlIHVuZXhwZWN0ZWQgdGhpbmdzIGNh biBoYXBwZW4uDQo+ID4gPiA+IA0KPiA+ID4gPiBZb3UgYWxzbyBub3RpY2VkIHRoYXQgdGhlIGN1 cnJlbnQgU0hBUkVfQlVGX1NJWkUgZGVmaW5lIGlzIHRvbw0KPiA+ID4gPiBsb3csIGJ1dCBJIHNh dw0KPiA+ID4gPiBubyBwYXRjaCBjb3JyZWN0aW5nIHRoaXMuIFNob3VsZG4ndCB0aGF0IGJlIGZp eGVkIGFzIHdlbGw/DQo+ID4gPiANCj4gPiA+IEFGQUlDVCB0aGUgZmlybXdhcmUgZXhwZWN0cyB0 aGlzIGV4YWN0IHNpemUgb24gaXRzIGVuZCwgc28gSQ0KPiA+ID4gZG9uJ3QNCj4gPiA+IGJlbGll dmUgaXQgY2FuIGJlIGNoYW5nZWQgdGhhdCBlYXNpbHkuIEJ1dCBtYXliZSBzb21lb25lIGZyb20g TVRLDQo+ID4gPiBjYW4NCj4gPiA+IHByb3ZlIG1lIHdyb25nLg0KPiA+ID4gDQo+ID4gDQo+ID4g SSBsb29rZWQgZnVydGhlciBhbmQgbm90ZWQgdGhhdCB0aGUgc3RydWN0cyB0aGF0IGFyZSBsYXJn ZXIgdGhhbg0KPiA+ICdTSEFSRV9CVUZfU0laRScNCj4gPiAodmVuY19hcF9pcGlfbXNnX2VuY19l eHQgdmVuY19hcF9pcGlfbXNnX3NldF9wYXJhbV9leHQpDQo+ID4gYXJlIHVzZWQgYnkgZHJpdmVy cyB0aGF0IGRvbid0IHVzZSB0aGlzIHZwdSBhcGksIHNvIGFjdHVhbGx5DQo+ID4gU0hBUkVfQlVG X1NJWkUgaXMNCj4gPiBub3QgdG9vIGxvdyBhbmQgYXMgQ29ydXJib3Qgd29ydGUgcHJvYmFibHkg bm90IGNoYW5nZWFibGUuDQo+ID4gDQo+ID4gDQo+ID4gVGhhbmtzLA0KPiA+IERhZm5hDQo+ID4g DQo+ID4gPiBDaGVlcnMsDQo+ID4gPiBBbGV4Lg0KPiA+ID4gDQo+IA0KPiANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313C2C433EF for ; Wed, 3 Nov 2021 09:19:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3F4E6115B for ; Wed, 3 Nov 2021 09:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E3F4E6115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3uaKiwyETemJs/jCUWVHI8UZpI9RjmJuSPYeo17TFDY=; b=A4C4WFqc7kAgwi nBsweOoq5wr17Wupl9pfNXKIWtWFVeP9Wf+yqkbkUKG0BYbEwne/pyciTiL1OtqkSBCJQYunxlLY5 jq79tzsme2WEBmEuS5rpcf7NThgTm0cEz0h0fXu1FWsXHz+YEJRw+bZkMJyeH8rNdMiiOg0q0Sj/U mTExDWWhj/XXwAkI77mNy5Tg3AcLtJ4OCGx5ryNKU+DcJ6nqtngVZ31Vjay0s9uVIRVco+ihVHwKH cGaGF4DpNUvIRYbrC94CfT0zJ4QqnJNkNXYPeBn4u+stY4J7lHjNXV5h426k+FxazJXD1jChnsoci 4MWmm3tTiPmjbdeWtl2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miCQd-004heY-E9; Wed, 03 Nov 2021 09:19:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miCQZ-004hdC-Q7 for linux-mediatek@lists.infradead.org; Wed, 03 Nov 2021 09:19:30 +0000 X-UUID: f9e80f8f39f34aa9b35007e18d0854ec-20211103 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FdCg3e0Gwi5y3/o458qrVWVoU7UhKyiLjyePMFkXn6E=; b=utOpz18/wQtiEKpwmNI7KOxcqS+RbDlTyqGnjgnswtKNLOYNRMUVR+6CZ5rGnIW44DzHfEAjSlX/XYEjZCO4MOe8uImCGe1bLR9zipuayjxLfJHt7sKKMzBGtSie39viC1utEIxTA8iMdayGZ5biXLPjjil+DR/+O4KeWhGjswU=; X-UUID: f9e80f8f39f34aa9b35007e18d0854ec-20211103 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 958780091; Wed, 03 Nov 2021 02:19:24 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Nov 2021 02:19:22 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 3 Nov 2021 17:19:21 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs10n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 3 Nov 2021 17:19:20 +0800 Message-ID: <8dfc07306b853126e8109fc953fd6388b63c65d2.camel@mediatek.com> Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer From: Irui Wang To: houlong wei , Dafna Hirschfeld , Alexandre Courbot , Hans Verkuil CC: Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" , LKML , "kernel@collabora.com" , Enric Balletbo i Serra , Dafna Hirschfeld , "Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?=" , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , Mauro Carvalho Chehab , Matthias Brugger Date: Wed, 3 Nov 2021 17:19:19 +0800 In-Reply-To: References: <20210920170408.1561-1-dafna.hirschfeld@collabora.com> <9475ac5b-79fe-da0e-ed1c-a91275cad46e@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_021928_308402_5ADE58C0 X-CRM114-Status: GOOD ( 44.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, The "len" of share_buf copied should be always 8 alignment; do you have other logs to prove the len is not 8 alignment when errors appear? >> [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 On Wed, 2021-11-03 at 16:03 +0800, houlong wei wrote: > Add mtk-vpu driver expert irui.wang in the loop. > > On Mon, 2021-10-18 at 15:07 +0800, Dafna Hirschfeld wrote: > > > > On 18.10.21 03:16, Alexandre Courbot wrote: > > > Hi Hans! > > > > > > On Mon, Oct 4, 2021 at 6:37 PM Hans Verkuil > > > wrote: > > > > > > > > On 20/09/2021 19:04, Dafna Hirschfeld wrote: > > > > > From: Alexandre Courbot > > > > > > > > > > When running memcpy_toio: > > > > > memcpy_toio(send_obj->share_buf, buf, len); > > > > > it was found that errors appear if len is not a multiple of > > > > > 8: > > > > > > > > > > [58.350841] mtk-mdp 14001000.rdma: processing failed: -22 > > > > > > > > Why do errors appear? Is that due to a HW bug? Some other > > > > reason? > > > > > > MTK folks would be the best placed to answer this, but since the > > > failure is reported by the firmware I'd suspect either a firmware > > > or > > > hardware limitation. > > > > > > > > > > > > > > > > > This patch ensures the copy of a multiple of 8 size by > > > > > calling > > > > > round_up(len, 8) when copying > > > > > > > > > > Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access > > > > > to > > > > > DTCM buffer.") > > > > > Signed-off-by: Alexandre Courbot > > > > > Signed-off-by: Enric Balletbo i Serra < > > > > > enric.balletbo@collabora.com> > > > > > Signed-off-by: Dafna Hirschfeld < > > > > > dafna.hirschfeld@collabora.com > > > > > > > > > > > > > > > > Reviewed-by: Houlong Wei > > > > > --- > > > > > changes since v3: > > > > > 1. multile -> multiple > > > > > 2. add inline doc > > > > > > > > > > changes since v2: > > > > > 1. do the extra copy only if len is not multiple of 8 > > > > > > > > > > changes since v1: > > > > > 1. change sign-off-by tags > > > > > 2. change values to memset > > > > > > > > > > drivers/media/platform/mtk-vpu/mtk_vpu.c | 15 > > > > > ++++++++++++++- > > > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > b/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > index ec290dde59cf..1df031716c8f 100644 > > > > > --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c > > > > > @@ -349,7 +349,20 @@ int vpu_ipi_send(struct platform_device > > > > > *pdev, > > > > > } > > > > > } while (vpu_cfg_readl(vpu, HOST_TO_VPU)); > > > > > > > > > > - memcpy_toio(send_obj->share_buf, buf, len); > > > > > + /* > > > > > + * when copying data to the vpu hardware, the > > > > > memcpy_toio > > > > > operation must copy > > > > > + * a multiple of 8. Otherwise the processing fails > > > > > > > > Same here: it needs to explain why the processing fails. > > > > Is writing 'due to hardware or firmware limitation' enough? > > If not, then we should wait for mediatek people's response to > > explain > > if they know more > > > > > > > > > > > + */ > > > > > + if (len % 8 != 0) { > > > > > + unsigned char data[SHARE_BUF_SIZE]; > > > > > > > > Wouldn't it be more robust if you say: > > > > > > > > unsigned char data[sizeof(send_obj- > > > > >share_buf)]; > > > > > > Definitely yes. > > > > I'll send v5 fixing this > > > > > > > > > > > > > I also think that the SHARE_BUF_SIZE define needs a comment > > > > stating that it must be a > > > > multiple of 8, otherwise unexpected things can happen. > > > > > > > > You also noticed that the current SHARE_BUF_SIZE define is too > > > > low, but I saw > > > > no patch correcting this. Shouldn't that be fixed as well? > > > > > > AFAICT the firmware expects this exact size on its end, so I > > > don't > > > believe it can be changed that easily. But maybe someone from MTK > > > can > > > prove me wrong. > > > > > > > I looked further and noted that the structs that are larger than > > 'SHARE_BUF_SIZE' > > (venc_ap_ipi_msg_enc_ext venc_ap_ipi_msg_set_param_ext) > > are used by drivers that don't use this vpu api, so actually > > SHARE_BUF_SIZE is > > not too low and as Corurbot worte probably not changeable. > > > > > > Thanks, > > Dafna > > > > > Cheers, > > > Alex. > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek