From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Mon, 13 Feb 2023 16:54:26 +0000 Subject: [Cluster-devel] [ClusterLabs] gfs2-utils 3.5.0 released In-Reply-To: <27e6ad15-381b-12b9-3c3a-310bd886a94a@redhat.com> References: <27e6ad15-381b-12b9-3c3a-310bd886a94a@redhat.com> Message-ID: <8e04ea90-b878-878d-71d0-776867546050@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 13/02/2023 09:58, Andrew Price wrote: > On 11/02/2023 17:16, Valentin Vidi? wrote: >> On Thu, Feb 09, 2023 at 01:12:58PM +0000, Andrew Price wrote: >>> gfs2-utils contains the tools needed to create, check, modify and >>> inspect >>> gfs2 filesystems along with support scripts needed on every gfs2 cluster >>> node. >> >> Hi, >> >> Some tests seem to be failing for the new version in Debian: >> >> gfs2_edit tests >> >> ? 37: Save/restoremeta, defaults????????????????????? FAILED (edit.at:14) >> ? 38: Save/restoremeta, no compression??????????????? FAILED (edit.at:24) >> ? 39: Save/restoremeta, min. block size?????????????? FAILED (edit.at:34) >> ? 40: Save/restoremeta, 4 journals??????????????????? FAILED (edit.at:44) >> ? 41: Save/restoremeta, min. block size, 4 journals?? FAILED (edit.at:54) >> ? 42: Save metadata to /dev/null????????????????????? ok >> >> It seems this is all on 32-bit architectures, more info here: >> >> https://buildd.debian.org/status/fetch.php?pkg=gfs2-utils&arch=armel&ver=3.5.0-1&stamp=1676127480&raw=0 >> https://buildd.debian.org/status/fetch.php?pkg=gfs2-utils&arch=armhf&ver=3.5.0-1&stamp=1676127632&raw=0 >> https://buildd.debian.org/status/fetch.php?pkg=gfs2-utils&arch=i386&ver=3.5.0-1&stamp=1676127477&raw=0 >> https://buildd.debian.org/status/fetch.php?pkg=gfs2-utils&arch=mipsel&ver=3.5.0-1&stamp=1676130593&raw=0 >> >> Can you check? >> > > The smoking gun is > > ??? "stderr: > ??? Error: File system is too small to restore this metadata. > ??? File system is 524287 blocks. Restore block = 537439" > > It's caused by size_t being used for a variable relating to file size > and it's too small in 32-bit environments. > > It should be fixed by this commit: > https://pagure.io/fork/andyp/gfs2-utils/c/a3f3aadc789f214cd24606808f5d8a6608e10219 > > It's waiting for the CI queue to flush after last week's outage but it > should be in main shortly. It's now in main: https://pagure.io/gfs2-utils/c/a3f3aadc Andy > I doubt we have any users on 32-bit architectures but perhaps we can get > a 32-bit test runner added to the CI pool to prevent these issues > slipping through anyway. > > Are you happy to carry the patch or do you think this is worth a 3.5.1? > > Thanks, > Andy