All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@virtuozzo.com>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Waiman Long <longman@redhat.com>
Subject: Re: [PATCH 7/7] sysvipc_find_ipc should increase position index
Date: Tue, 25 Feb 2020 09:35:34 +0300	[thread overview]
Message-ID: <8e097c72-5fd0-4a59-12e3-8298b9f5468e@virtuozzo.com> (raw)
In-Reply-To: <8ed2850e-7cec-ebeb-4e15-21da3715c42a@redhat.com>

Dear Andrew,
Could you please pick up this patch?

On 1/24/20 7:26 PM, Waiman Long wrote:
> On 1/24/20 2:03 AM, Vasily Averin wrote:
>> if seq_file .next fuction does not change position index,
>> read after some lseek can generate unexpected output.
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=206283
>> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
>> ---
>>  ipc/util.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ipc/util.c b/ipc/util.c
>> index 915eacb..7a3ab2e 100644
>> --- a/ipc/util.c
>> +++ b/ipc/util.c
>> @@ -764,13 +764,13 @@ static struct kern_ipc_perm *sysvipc_find_ipc(struct ipc_ids *ids, loff_t pos,
>>  			total++;
>>  	}
>>  
>> +	*new_pos = pos + 1;
>>  	if (total >= ids->in_use)
>>  		return NULL;
>>  
>>  	for (; pos < ipc_mni; pos++) {
>>  		ipc = idr_find(&ids->ipcs_idr, pos);
>>  		if (ipc != NULL) {
>> -			*new_pos = pos + 1;
>>  			rcu_read_lock();
>>  			ipc_lock_object(ipc);
>>  			return ipc;
> 
> Acked-by: Waiman Long <longman@redhat.com>
> 

  reply	other threads:[~2020-02-25  6:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24  7:03 [PATCH 7/7] sysvipc_find_ipc should increase position index Vasily Averin
2020-01-24 16:26 ` Waiman Long
2020-02-25  6:35   ` Vasily Averin [this message]
2020-05-05 16:13 ` Andreas Schwab
2020-05-06  5:03   ` Vasily Averin
2020-05-06  6:25     ` [PATCH] ipc/util.c: sysvipc_find_ipc() incorrectly updates " Vasily Averin
2020-05-06 15:59       ` Waiman Long
2020-05-07 12:29         ` Vasily Averin
2020-05-08  0:02       ` Andrew Morton
2020-05-08  3:36         ` Matthew Wilcox
2020-05-08  6:07           ` Vasily Averin
2020-05-08 10:01             ` Vasily Averin
2020-05-12  9:21               ` Jiri Slaby
2020-05-12 15:45                 ` Vasily Averin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e097c72-5fd0-4a59-12e3-8298b9f5468e@virtuozzo.com \
    --to=vvs@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.