All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Fedotov <ifedotov@mirantis.com>
To: Sage Weil <sage@newdream.net>, ceph-devel <ceph-devel@vger.kernel.org>
Subject: uint32_t BlueStore::Extent::logical_offset?
Date: Tue, 22 Nov 2016 19:58:55 +0300	[thread overview]
Message-ID: <8e0b5262-32ef-02a6-6812-a3e82369e9aa@mirantis.com> (raw)

Hi Sage,


I'm wondering why BlueStore::Extent::logical_offset is 32-bit wide.

IMHO it's to be uint64_t unless we limit onode size to 4Gb.

Looks like we have implicit truncate when doing set_lextent/new Extent 
at the moment and hence some issues with large onodes are possible.

Thanks,
Igor

             reply	other threads:[~2016-11-22 16:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 16:58 Igor Fedotov [this message]
2016-11-22 17:06 ` uint32_t BlueStore::Extent::logical_offset? Gregory Farnum
2016-11-22 17:15   ` Igor Fedotov
2016-11-22 21:47 ` Sage Weil
2016-11-22 21:53   ` Somnath Roy
2016-11-22 22:42     ` Matt Benjamin
2016-11-22 22:45       ` Sage Weil
2016-11-22 23:02         ` Matt Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e0b5262-32ef-02a6-6812-a3e82369e9aa@mirantis.com \
    --to=ifedotov@mirantis.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sage@newdream.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.