All of lore.kernel.org
 help / color / mirror / Atom feed
From: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
	Lee Jones <lee.jones@linaro.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-pwm@vger.kernel.org,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Luca Weiss <luca@z3ntu.xyz>
Subject: Re: [PATCH v7 1/6] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding
Date: Tue, 4 May 2021 09:29:09 -0700	[thread overview]
Message-ID: <8e2bdc31-2259-08c6-b50c-2b464bbc86bf@codeaurora.org> (raw)
In-Reply-To: <YJFcsRnki3XT3isk@mobian>

On 5/4/21 7:39 AM, Pavel Machek wrote:
> Hi!
> On Mon 2021-05-03 18:01:09, Subbaraman Narayanamurthy wrote:
>> On 4/29/21 2:15 PM, Bjorn Andersson wrote:
>>> This adds the binding document describing the three hardware blocks
>>> related to the Light Pulse Generator found in a wide range of Qualcomm
>>> PMICs.
>>>
>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ...
>>> +      "^led@[0-9a-f]$":
>>> +        type: object
>>> +        $ref: common.yaml#
>>> +
>>
>> Just a question more than a comment. From what I can see, when this device is specified as a multi-color device or an individual device (e.g. "red", "green" and "blue"), the user can only set "pattern" and "repeat" under the corresponding device after setting "pattern" to "trigger". Would you be planning to add a way (e.g. another set of DT properties) for the user to specify such patterns via the devicetree itself?
>>
> Please trim your replies and format emails to 72 columns or so.

Sure noted.

> If you need patterns in DTS that can be discussed, but it should be
> generic functionality not tied to one driver.

I agree. It's not tied up just with this driver but wanted to see whether
it's feasible/acceptable.

>
> Best regards,
>
>        	    	 	     	    	      	 	 Pavel

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project


  reply	other threads:[~2021-05-04 16:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 21:15 [PATCH v7 0/6] Qualcomm Light Pulse Generator Bjorn Andersson
2021-04-29 21:15 ` [PATCH v7 1/6] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson
2021-04-30 20:05   ` Rob Herring
2021-05-02 20:53     ` Bjorn Andersson
2021-05-04  1:01   ` Subbaraman Narayanamurthy
2021-05-04 14:39     ` Pavel Machek
2021-05-04 16:29       ` Subbaraman Narayanamurthy [this message]
2021-04-29 21:15 ` [PATCH v7 2/6] leds: Add driver for Qualcomm LPG Bjorn Andersson
2021-04-30  2:22   ` kernel test robot
2021-04-30  2:22     ` kernel test robot
2021-04-30  2:48   ` kernel test robot
2021-04-30  2:48     ` kernel test robot
2021-05-01 21:09   ` Marijn Suijten
2021-05-02 21:15     ` Bjorn Andersson
2021-05-04  1:20   ` Subbaraman Narayanamurthy
2021-04-29 21:15 ` [PATCH v7 3/6] arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998 Bjorn Andersson
2021-04-29 21:15 ` [PATCH v7 4/6] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c Bjorn Andersson
2021-04-29 21:15 ` [PATCH v7 5/6] arm64: dts: qcom: pmi8994: Define MPP block Bjorn Andersson
2021-04-29 21:15 ` [PATCH v7 6/6] arm64: dts: qcom: db820c: Add user LEDs Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2bdc31-2259-08c6-b50c-2b464bbc86bf@codeaurora.org \
    --to=subbaram@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=marijn.suijten@somainline.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.