All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Shay Drory <shayd@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [net V2 01/15] net/mlx5: Don't allow health work when device is uninitialized
Date: Fri, 02 Oct 2020 09:57:46 -0700	[thread overview]
Message-ID: <8e2c09c059b5866f3133d6d880c1f15becc4fc35.camel@kernel.org> (raw)
In-Reply-To: <20201001161558.1a095385@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Thu, 2020-10-01 at 16:15 -0700, Jakub Kicinski wrote:
> On Thu,  1 Oct 2020 12:52:33 -0700 saeed@kernel.org wrote:
> > From: Shay Drory <shayd@mellanox.com>
> > 
> > On error flow due to failure on driver load, driver can be
> > un-initializing while a health work is running in the background,
> > health work shouldn't be allowed at this point, as it needs
> > resources to
> > be initialized and there is no point to recover on driver load
> > failures.
> > 
> > Therefore, introducing a new state bit to indicated if device is
> > initialized, for health work to check before trying to recover the
> > driver.
> 
> Can't you cancel this work? Or make sure it's not scheduled?
> IMHO those "INITILIZED" bits are an anti-pattern.
> 

Shay didn't want to make this patch complicated for net, since this
health work should start as early as possible and should be kept
running after driver is initialized, even if the driver instance
reloads after .. the main issue of the design is that we initialize +
allocate the driver structures once on the first boot, after that all
reloads will reuse the same structure, so there is some asymmetry that
we need to deal with, but nothing is impossible, the solution will be
more complicated but won't be too big to make it to net (i hope), I
will drop this patch for now.

> > Fixes: b6e0b6bebe07 ("net/mlx5: Fix fatal error handling during
> > device load")
> > Signed-off-by: Shay Drory <shayd@mellanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> 
> You signed off twice :)
> 

Will fix this, old mellanox email :/

> We should teach verify_signoff to catch that..
it is not exactly twice, different emails.. 


  reply	other threads:[~2020-10-02 16:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 19:52 [pull request][net V2 00/15] mlx5 fixes 2020-09-30 saeed
2020-10-01 19:52 ` [net V2 01/15] net/mlx5: Don't allow health work when device is uninitialized saeed
2020-10-01 23:15   ` Jakub Kicinski
2020-10-02 16:57     ` Saeed Mahameed [this message]
2020-10-01 19:52 ` [net V2 02/15] net/mlx5: Fix a race when moving command interface to polling mode saeed
2020-10-01 19:52 ` [net V2 03/15] net/mlx5: Avoid possible free of command entry while timeout comp handler saeed
2020-10-01 19:52 ` [net V2 04/15] net/mlx5: poll cmd EQ in case of command timeout saeed
2020-10-01 19:52 ` [net V2 05/15] net/mlx5: Add retry mechanism to the command entry index allocation saeed
2020-10-01 23:23   ` Jakub Kicinski
2020-10-02 17:03     ` Saeed Mahameed
2020-10-01 19:52 ` [net V2 06/15] net/mlx5: cmdif, Avoid skipping reclaim pages if FW is not accessible saeed
2020-10-01 19:52 ` [net V2 07/15] net/mlx5: Fix request_irqs error flow saeed
2020-10-01 23:24   ` Jakub Kicinski
2020-10-02 17:05     ` Saeed Mahameed
2020-10-02 17:19       ` Mark Bloch
2020-10-02 17:27         ` Saeed Mahameed
2020-10-01 19:52 ` [net V2 08/15] net/mlx5e: Fix error path for RQ alloc saeed
2020-10-01 19:52 ` [net V2 09/15] net/mlx5e: Add resiliency in Striding RQ mode for packets larger than MTU saeed
2020-10-01 23:27   ` Jakub Kicinski
2020-10-02 17:06     ` Saeed Mahameed
2020-10-01 19:52 ` [net V2 10/15] net/mlx5e: CT, Fix coverity issue saeed
2020-10-01 19:52 ` [net V2 11/15] net/mlx5e: Fix driver's declaration to support GRE offload saeed
2020-10-01 19:52 ` [net V2 12/15] net/mlx5e: Fix return status when setting unsupported FEC mode saeed
2020-10-01 19:52 ` [net V2 13/15] net/mlx5e: Fix VLAN cleanup flow saeed
2020-10-01 19:52 ` [net V2 14/15] net/mlx5e: Fix VLAN create flow saeed
2020-10-01 19:52 ` [net V2 15/15] net/mlx5e: Fix race condition on nhe->n pointer in neigh update saeed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2c09c059b5866f3133d6d880c1f15becc4fc35.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=shayd@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.