From: Scott Garman <scott.a.garman@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 3/6] sanity.bbclass: warn the user if BBPATH contains wrong entries
Date: Mon, 18 Jun 2012 12:57:57 -0700 [thread overview]
Message-ID: <8e362de541f2827cb615e86b850353d929d33d24.1340038108.git.scott.a.garman@intel.com> (raw)
In-Reply-To: <cover.1340038108.git.scott.a.garman@intel.com>
In-Reply-To: <cover.1340038108.git.scott.a.garman@intel.com>
From: Laurentiu Palcu <laurentiu.palcu@intel.com>
If BBPATH references the working directory, the user is warned and asked
to fix the problem.
[Yocto #1465]
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Reworked commit to fix merge conflicts with denzil branch.
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
---
meta/classes/sanity.bbclass | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 9755694..298372b 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -310,7 +310,18 @@ def check_sanity(sanity_data):
if "." in data.getVar('PATH', sanity_data, True).split(":"):
messages = messages + "PATH contains '.' which will break the build, please remove this"
- if data.getVar('TARGET_ARCH', sanity_data, True) == "arm":
+ bbpaths = sanity_data.getVar('BBPATH', True).split(":")
+ if "." in bbpaths or "" in bbpaths:
+ # TODO: change the following message to fatal when all BBPATH issues
+ # are fixed
+ bb.warn("BBPATH references the current directory, either through " \
+ "an empty entry, or a '.'.\n\t This is unsafe and means your "\
+ "layer configuration is adding empty elements to BBPATH.\n\t "\
+ "Please check your layer.conf files and other BBPATH " \
+ "settings to remove the current working directory " \
+ "references.");
+
+ if sanity_data.getVar('TARGET_ARCH', True) == "arm":
# This path is no longer user-readable in modern (very recent) Linux
try:
if os.path.exists("/proc/sys/vm/mmap_min_addr"):
--
1.7.9.5
next prev parent reply other threads:[~2012-06-18 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 19:57 [PATCH 0/6] denzil pull request 3 Scott Garman
2012-06-18 19:57 ` [PATCH 1/6] openjade-native: Ensure we reautoconf the package Scott Garman
2012-06-18 19:57 ` [PATCH 2/6] webkit-gtk: Apply work around for all PowerPC targets Scott Garman
2012-06-18 19:57 ` Scott Garman [this message]
2012-06-21 10:54 ` [PATCH 3/6] sanity.bbclass: warn the user if BBPATH contains wrong entries Richard Purdie
2012-06-18 19:57 ` [PATCH 4/6] eglibc: package mtrace separately Scott Garman
2012-06-18 19:57 ` [PATCH 5/6] quilt: added ac_cv_path_BASH to CACHED_CONFIGUREVARS Scott Garman
2012-06-18 19:58 ` [PATCH 6/6] eglibc: added ac_cv_path_ " Scott Garman
2012-06-18 20:01 ` [PATCH 0/6] denzil pull request 3 Scott Garman
2012-06-21 11:00 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e362de541f2827cb615e86b850353d929d33d24.1340038108.git.scott.a.garman@intel.com \
--to=scott.a.garman@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.