From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3A0C433FE for ; Thu, 24 Nov 2022 10:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbiKXK5D (ORCPT ); Thu, 24 Nov 2022 05:57:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbiKXK4v (ORCPT ); Thu, 24 Nov 2022 05:56:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D32F48419; Thu, 24 Nov 2022 02:56:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6FE2B82777; Thu, 24 Nov 2022 10:56:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03929C433D7; Thu, 24 Nov 2022 10:56:43 +0000 (UTC) Message-ID: <8e3a3b74-0016-8e07-fa1b-fab34014f801@xs4all.nl> Date: Thu, 24 Nov 2022 11:56:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] media: v4l2-ctrl: Add main 10 still picture profile for hevc Content-Language: en-US To: "Dikshita Agarwal (QUIC)" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ezequiel@collabora.com" Cc: "stanimir.varbanov@linaro.org" , "linux-arm-msm@vger.kernel.org" , "Vikash Garodia (QUIC)" , "Maheshwar Ajja (QUIC)" , quic_jdas References: <1661239563-14346-1-git-send-email-quic_dikshita@quicinc.com> <7122b146-46c7-7e58-5b26-4b94d3a8c1d8@xs4all.nl> From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26/08/2022 08:34, Dikshita Agarwal (QUIC) wrote: > Hi Hans, > > -----Original Message----- > From: Hans Verkuil > Sent: Wednesday, August 24, 2022 5:36 PM > To: Dikshita Agarwal (QUIC) ; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; ezequiel@collabora.com > Cc: stanimir.varbanov@linaro.org; linux-arm-msm@vger.kernel.org; Vikash Garodia (QUIC) ; Maheshwar Ajja (QUIC) ; quic_jdas > Subject: Re: [PATCH] media: v4l2-ctrl: Add main 10 still picture profile for hevc > > Hi Dikshita, > > On 23/08/2022 09:26, Dikshita Agarwal wrote: >> Add main 10 still picture profile for HEVC encoder. > > Hmm, is this the same as the "Main 4:4:4 Still Picture" profile mentioned here: > > https://en.wikipedia.org/wiki/High_Efficiency_Video_Coding#Version_2_profiles > > If not, where it is defined? I would also prefer to have this patch merged together with a driver that uses it. > > It is different and definition can be found in Latest HEVC spec, Annex A, A.3.3 Main 10 and Main 10 Still Picture profiles. > https://www.itu.int/rec/dologin_pub.asp?lang=s&id=T-REC-H.265-201906-S!!PDF-E&type=items It will be useful to have a reference to that in the documentation. Also note that I can't merge this without a driver that uses it! Regards, Hans > > Thanks, > Dikshita > > Regards, > > Hans > >> >> Signed-off-by: Dikshita Agarwal >> --- >> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 2 ++ >> include/uapi/linux/v4l2-controls.h | 1 + >> 2 files changed, 3 insertions(+) >> >> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> index 2a165ae..5b2da84 100644 >> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> @@ -2424,6 +2424,8 @@ enum v4l2_mpeg_video_hevc_profile - >> - Main still picture profile. >> * - ``V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10`` >> - Main 10 profile. >> + * - ``V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10_STILL_PICTURE`` >> + - Main 10 still picture profile. >> >> .. raw:: latex >> >> diff --git a/include/uapi/linux/v4l2-controls.h >> b/include/uapi/linux/v4l2-controls.h >> index 5f46bf4..1159337 100644 >> --- a/include/uapi/linux/v4l2-controls.h >> +++ b/include/uapi/linux/v4l2-controls.h >> @@ -743,6 +743,7 @@ enum v4l2_mpeg_video_hevc_profile { >> V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN = 0, >> V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE = 1, >> V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 = 2, >> + V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10_STILL_PICTURE = 3, >> }; >> #define V4L2_CID_MPEG_VIDEO_HEVC_LEVEL (V4L2_CID_CODEC_BASE + 616) >> enum v4l2_mpeg_video_hevc_level {