All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Anup Patel <anup@brainfault.org>
Cc: Anup Patel <apatel@ventanamicro.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Atish Patra <atishp@atishpatra.org>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match
Date: Thu, 9 Jun 2022 06:58:28 -0700	[thread overview]
Message-ID: <8e48300c-9b30-728b-22ab-652476015975@linaro.org> (raw)
In-Reply-To: <CAAhSdy1JeAuz0YtMdKQjeJHpEG5_BL35v+OWiGsiPn4WgAsOaQ@mail.gmail.com>

On 6/8/22 20:16, Anup Patel wrote:
> On Wed, Jun 8, 2022 at 10:23 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 6/8/22 09:14, Anup Patel wrote:
>>> +    struct isa_ext_data isa_edata_arr[] = {
>>
>> static const?
> 
> Using const is fine but we can't use "static const" because
> the "struct isa_ext_data" has a pointer to ext_xyz which
> is different for each CPU.

Ah, I see.  Perhaps better to use offsetof then -- the data structure is not small...


r~


  reply	other threads:[~2022-06-09 14:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 16:14 [PATCH v4 0/4] QEMU RISC-V nested virtualization fixes Anup Patel
2022-06-08 16:14 ` [PATCH v4 1/4] target/riscv: Don't force update priv spec version to latest Anup Patel
2022-06-09  1:20   ` Bin Meng
2022-06-08 16:14 ` [PATCH v4 2/4] target/riscv: Add dummy mcountinhibit CSR for priv spec v1.11 or higher Anup Patel
2022-06-09  1:28   ` Bin Meng
2022-06-08 16:14 ` [PATCH v4 3/4] target/riscv: Update [m|h]tinst CSR in riscv_cpu_do_interrupt() Anup Patel
2022-06-08 16:14 ` [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match Anup Patel
2022-06-08 16:53   ` Richard Henderson
2022-06-09  3:16     ` Anup Patel
2022-06-09 13:58       ` Richard Henderson [this message]
2022-06-09 16:20         ` Anup Patel
2022-06-09  1:33   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e48300c-9b30-728b-22ab-652476015975@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=anup@brainfault.org \
    --cc=apatel@ventanamicro.com \
    --cc=atishp@atishpatra.org \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.