All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaco Kroon <jaco@uls.co.za>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>,
	"lkp@intel.com" <lkp@intel.com>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Sathya.Prakash@broadcom.com" <Sathya.Prakash@broadcom.com>,
	"suganath-prabu.subramani@broadcom.com"
	<suganath-prabu.subramani@broadcom.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: *** SPAM *** Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static
Date: Thu, 5 Apr 2018 13:43:55 +0200	[thread overview]
Message-ID: <8e5f96f8-0072-25b8-6403-6f93d4836131@uls.co.za> (raw)
In-Reply-To: <yq1370jj278.fsf@oracle.com>

Hi,

Further to that, in the second last hunk there is a very clear
functionality change:

@@ -8756,12 +8859,12 @@ _scsih_mark_responding_expander(struct
MPT3SAS_ADAPTER *ioc,
                        continue;
                sas_expander->responding = 1;

-               if (!encl_pg0_rc)
+               if (enclosure_dev) {
                        sas_expander->enclosure_logical_id =
-                           le64_to_cpu(enclosure_pg0.EnclosureLogicalID);
-
-               sas_expander->enclosure_handle =
-                   le16_to_cpu(expander_pg0->EnclosureHandle);
+                           le64_to_cpu(enclosure_dev->pg
0.EnclosureLogicalID);
+                       sas_expander->enclosure_handle =
+                           le16_to_cpu(expander_pg0->EnclosureHandle);
+               }

                if (sas_expander->handle == handle)
                        goto out;

Note that the assignment to sas_expander->enclosure_handle is now
dependent on enclosure_dev being non-NULL.

Busy applying the patch to 4.16 - and now I have no idea whether that
functionality change should be part of the change or not.  Having worked
through the rest of the patch it seems good otherwise (Keeping in mind
that I'm not familiar with the code in question, nor do I normally work
on kernel code, and this is definitely the first time I took a peek
anywhere near the IO subsystem).

Kind Regards,
Jaco

On 28/03/2018 23:54, Martin K. Petersen wrote:
> Bart,
>
>> Are you aware that if the 0-day test infrastructure suggests an improvement
>> for a patch that the patch that that improvement applies to gets ignored
>> unless either the patch is reposted with the improvement applied or that it
>> is explained why the suggested improvement is inappropriate?
> Correct. I don't apply anything that causes a 0-day warning. The patch
> will be closed with "Changes Required" status in patchwork.
>
> Always build patch submissions to linux-scsi with:
>
> 	make C=1 CF="-D__CHECK_ENDIAN__"
>

  reply	other threads:[~2018-04-05 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 10:15 [PATCH] mpt3sas: Cache enclosure pages during enclosure add Chaitra P B
2018-03-20 21:06 ` kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-20 21:06 ` [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-27 18:55   ` Bart Van Assche
2018-03-28 21:54     ` Martin K. Petersen
2018-03-28 21:54       ` Martin K. Petersen
2018-04-05 11:43       ` Jaco Kroon [this message]
2018-04-10  7:15       ` *** SPAM *** " Jaco Kroon
2018-04-10 12:46         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e5f96f8-0072-25b8-6403-6f93d4836131@uls.co.za \
    --to=jaco@uls.co.za \
    --cc=Bart.VanAssche@wdc.com \
    --cc=Sathya.Prakash@broadcom.com \
    --cc=chaitra.basappa@broadcom.com \
    --cc=kbuild-all@01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.