Re: [PATCH v2 4/4] bisect--helper: double-check run command on exit code 126 and 127

["René Scharfe" <l.s.r@web.de>]

Am 19.01.22 um 03:36 schrieb Junio C Hamano:
>> diff --git a/bisect.h b/bisect.h
>> index ec24ac2d7e..748adf0cff 100644
>> --- a/bisect.h
>> +++ b/bisect.h
>> @@ -69,4 +69,7 @@ void read_bisect_terms(const char **bad, const char **good);
>>
>>  int bisect_clean_state(void);
>>
>> +enum bisect_error bisect_checkout(const struct object_id *bisect_rev,
>> +                                 int no_checkout);
>> +
>>  #endif
>
> https://github.com/git/git/runs/4861805265?check_suite_focus=true#step:4:65
>
> In file included from bisect.hcc:2:0:
> bisect.h:72:48: error: ‘struct object_id’ declared inside parameter
> list will not be visible outside of this definition or declaration
> [-Werror]
>  enum bisect_error bisect_checkout(const struct object_id *bisect_rev,
>                                                 ^~~~~~~~~
> cc1: all warnings being treated as errors

Oops, and I didn't even know the make target hdr-check exists. :-/

--- >8 ---
Subject: [PATCH] fixup! bisect--helper: double-check run command on exit code 126 and 127

---
 bisect.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bisect.h b/bisect.h
index 748adf0cff..1015aeb8ea 100644
--- a/bisect.h
+++ b/bisect.h
@@ -3,6 +3,7 @@

 struct commit_list;
 struct repository;
+struct object_id;

 /*
  * Find bisection. If something is found, `reaches` will be the number of
--
2.34.1