Re: deterministic io throughput in multipath

[Muneendra Kumar M <mmandala@Brocade.com>]

[-- Attachment #1.1: Type: text/plain, Size: 4984 bytes --]

Hi Ben,
I did commit my  patches to a branch off the head of master
But when I used the below command iam getting the below errors. Not sure whether the mail has been sent to dm-devel@redhat.com<mailto:dm-devel@redhat.com>.

# git send-email --to "device-mapper development <dm-devel@redhat.com>" --cc "Christophe Varoqui <christophe.varoqui@opensvc.com>" --no-chain-reply-to --suppress-from <dir>

Iam seeing the below error. Could you please help me in this


Content-Description: Notification
Content-Type: text/plain; charset=us-ascii

This is the mail system at host localhost.localdomain.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to postmaster.

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

                   The mail system

<christophe.varoqui@opensvc.com>: host spool.mail.gandi.net[217.70.184.6] said:
    550 5.1.8 <root@localhost.localdomain>: Sender address rejected: Domain not
    found (in reply to RCPT TO command)

--E52C4C13C372.1486112814/localhost.localdomain
Content-Description: Delivery report
Content-Type: message/delivery-status

Reporting-MTA: dns; localhost.localdomain
X-Postfix-Queue-ID: E52C4C13C372
X-Postfix-Sender: rfc822; root@localhost.localdomain
Arrival-Date: Fri,  3 Feb 2017 14:36:22 +0530 (IST)

Final-Recipient: rfc822; christophe.varoqui@opensvc.com
Action: failed
Status: 5.1.8
Remote-MTA: dns; spool.mail.gandi.net
Diagnostic-Code: smtp; 550 5.1.8 <root@localhost.localdomain>: Sender address
    rejected: Domain not found

--E52C4C13C372.1486112814/localhost.localdomain
Content-Description: Undelivered Message
Content-Type: message/rfc822

Return-Path: <root@localhost.localdomain>
Received: by localhost.localdomain (Postfix, from userid 0)
        id E52C4C13C372; Fri,  3 Feb 2017 14:36:22 +0530 (IST)
From: M Muneendra Kumar <mmandala@brocade.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
        Benjamin Marzinski <bmarzins@redhat.com>
Subject: [PATCH 0/1] multipathd: deterministic io throughput in multipath
Date: Fri,  3 Feb 2017 14:36:21 +0530
Message-Id: <1486112782-12706-1-git-send-email-mmandala@brocade.com>
X-Mailer: git-send-email 1.8.3.1

Regards,
Muneendra.

-----Original Message-----
From: Benjamin Marzinski [mailto:bmarzins@redhat.com]
Sent: Friday, February 03, 2017 12:00 AM
To: Muneendra Kumar M <mmandala@Brocade.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [dm-devel] deterministic io throughput in multipath

On Thu, Feb 02, 2017 at 06:02:57PM +0000, Muneendra Kumar M wrote:
> Hi Ben,
> Thanks for the review.
> So can I push my changes as mentioned by you in the below mail using git.

Sure.

-Ben

>
> Regards,
> Muneendra.
>
>
> -----Original Message-----
> From: Benjamin Marzinski [mailto:bmarzins@redhat.com]
> Sent: Thursday, February 02, 2017 11:09 PM
> To: Muneendra Kumar M <mmandala@Brocade.com<mailto:mmandala@Brocade.com>>
> Cc: device-mapper development <dm-devel@redhat.com<mailto:dm-devel@redhat.com>>
> Subject: Re: [dm-devel] deterministic io throughput in multipath
>
> This looks fine. Thanks for all your work on this
>
> ACK
>
> -Ben
>
> On Thu, Feb 02, 2017 at 11:48:39AM +0000, Muneendra Kumar M wrote:
> > Hi Ben,
> > The below changes suggested by you are good. Thanks for it.
> > I have taken your changes and made few changes to make the functionality working.
> > I have tested the same on the setup which works fine.
> >
> > We need to increment the path_failures every time checker fails.
> > if a device is down for a while, when it comes back up, it will get delayed only if the path failures exceeds the error threshold.
> > Whether checker fails or kernel identifies the failures we need  to capture those as it tells the state of the path and target.
> > The below code has already taken care of this.
> >
> > Could you please review the attached patch and provide us your valuable comments .
> >
> > Below are the files that has been changed .
> >
> > libmultipath/config.c      |  6 ++++++
> >  libmultipath/config.h      |  9 +++++++++
> >  libmultipath/configure.c   |  3 +++
> >  libmultipath/defaults.h    |  3 ++-
> >  libmultipath/dict.c        | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------
> >  libmultipath/dict.h        |  3 +--
> >  libmultipath/propsel.c     | 48 ++++++++++++++++++++++++++++++++++++++++++++++--
> >  libmultipath/propsel.h     |  3 +++
> >  libmultipath/structs.h     | 14 ++++++++++----
> >  multipath/multipath.conf.5 | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  multipathd/main.c          | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  11 files changed, 281 insertions(+), 34 deletions(-)
> >
> > Regards,
> > Muneendra.
> >
> >


[-- Attachment #1.2: Type: text/html, Size: 10692 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]