From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49772)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bhZHQ-0000dI-Pe
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 05:36:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bhZHN-0002s2-FS
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 05:36:28 -0400
References: <1473167877-2545-1-git-send-email-lvivier@redhat.com>
	<1473167877-2545-3-git-send-email-lvivier@redhat.com>
	<20160906234111.02181f40@bahia>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <8e76a3be-cea1-d788-3f1d-045e896a6876@redhat.com>
Date: Wed, 7 Sep 2016 11:36:21 +0200
MIME-Version: 1.0
In-Reply-To: <20160906234111.02181f40@bahia>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make
 pc_alloc_init/init_flags/uninit generic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <groug@kaod.org>
Cc: david@gibson.dropbear.id.au, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org



On 06/09/2016 23:41, Greg Kurz wrote:
> On Tue,  6 Sep 2016 15:17:56 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
>> And add support for ppc64.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>> v2:
>> - remove useless parenthesis, inline
>>
> 
> This works indeed but I'm just feeling curious about the QOSOps type introduced
> by the following commit:
> 
> commit 90e5add6f2fa0b0bd9a4c1d5a4de2304b5f3e466
> Author: John Snow <jsnow@redhat.com>
> Date:   Mon Jan 19 15:15:55 2015 -0500
> 
>     libqos: add pc specific interface
> 
> Wouldn't this be better to implement something similar for ppc64 instead of
> relying on strcmp() ?

Tests can be generic and to be run on several archs: we need the
strcmp() to check the guest arch [1], it can't be hardcoded in the test.

Thanks,
Laurent

[1]
const char *qtest_get_arch(void)
{
    const char *qemu = getenv("QTEST_QEMU_BINARY");
    g_assert(qemu != NULL);
    const char *end = strrchr(qemu, '/');

    return end + strlen("/qemu-system-");
}